merlimat commented on a change in pull request #1124: Support Pulsar proxy from
C++/Python client library
URL: https://github.com/apache/incubator-pulsar/pull/1124#discussion_r164510154
##########
File path: pulsar-client-cpp/lib/Url.cc
##########
@@ -88,6 +88,12 @@ const std::string& Url::file() const { return file_; }
const std::string& Url::parameter() const { return parameter_; }
+std::string Url::hostPort() const {
Review comment:
To return a reference, we would have to store the `hostPort` as a member
variable. Since we don't always need the `hostPort()` in `Url` class, I prefer
to just create it on the fly when needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
