merlimat commented on a change in pull request #1129: Added end to end
encryption in C++ client
URL: https://github.com/apache/incubator-pulsar/pull/1129#discussion_r164523212
##########
File path: pulsar-client-cpp/lib/BatchMessageContainer.cc
##########
@@ -93,6 +93,10 @@ void BatchMessageContainer::sendMessage() {
impl_->metadata.set_num_messages_in_batch(messagesContainerListPtr_->size());
compressPayLoad();
+ SharedBuffer encryptedPayload;
Review comment:
Creating the `SharedBuffer` will need to malloc some stuff, can we just
doing when encryption is enabled?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
