zhaijack commented on a change in pull request #1103: PIP-13-1/3: Provide
`TopicsConsumer` to consume from several topics under same namespace
URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r167261106
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PartitionedConsumerImpl.java
##########
@@ -468,17 +468,20 @@ public void redeliverUnacknowledgedMessages() {
}
@Override
- public void redeliverUnacknowledgedMessages(Set<MessageIdImpl> messageIds)
{
+ public void redeliverUnacknowledgedMessages(Set<MessageId> messageIds) {
Review comment:
Thanks, As above reply, we also need this redeliverUnacknowledgedMessages
method in Consumer.java handling TopicMessageIdImpl. would like to change this
in Consumer.java and make the case in each child class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
