merlimat commented on a change in pull request #1208: Add hostname-verification
at client tls connection
URL: https://github.com/apache/incubator-pulsar/pull/1208#discussion_r167332300
##########
File path: pulsar-client-shaded/pom.xml
##########
@@ -81,6 +81,8 @@
<include>org.apache.pulsar:pulsar-checksum</include>
<include>net.jpountz.lz4:lz4</include>
<include>com.yahoo.datasketches:sketches-core</include>
+ <include>org.apache.httpcomponents:httpclient</include>
+ <include>commons-logging:commons-logging</include>
Review comment:
Can you also add these in `pulsar-broker-shaded/pom.xml` and
`pulsar-client-kafka-compat/pulsar-client-kafka/pom.xml`. I know it's painful,
but couldn't find a reliable way to do the shading in the different modules.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
