ivankelly commented on a change in pull request #1232: Schema registry (1/4)
URL: https://github.com/apache/incubator-pulsar/pull/1232#discussion_r168229944
##########
File path: pulsar-common/src/main/proto/PulsarApi.proto
##########
@@ -22,6 +22,20 @@ package pulsar.proto;
option java_package = "org.apache.pulsar.common.api.proto";
option optimize_for = LITE_RUNTIME;
+message Schema {
+ required string name = 1;
+ required bytes version = 2;
+ required bytes schema_data = 3;
+ repeated KeyValue properties = 4;
+}
+
+message Tombstone {}
+
+message SchemaEntry {
Review comment:
I assume this is part of a the schema registry part? Why is tombstone
separate from the schema? You have schema_data as required? If tombstoning a
schema (which I assume is deleting the schema) what should the data be?
Couldn't schema data itself being empty denote the tombstone?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
