merlimat commented on a change in pull request #1232: Schema registry (1/4)
URL: https://github.com/apache/incubator-pulsar/pull/1232#discussion_r171418590
##########
File path: pulsar-common/src/main/proto/PulsarApi.proto
##########
@@ -22,6 +22,13 @@ package pulsar.proto;
option java_package = "org.apache.pulsar.common.api.proto";
option optimize_for = LITE_RUNTIME;
+message Schema {
+ required string name = 1;
+ required bytes version = 2;
+ required bytes schema_data = 3;
+ repeated KeyValue properties = 4;
Review comment:
I think it was already pointed out, though it's missing now.
1. Shouldn't `version` be a `long` type?
2. Since we are not supporting arbitrary schemas, I think we should
identify the type of the schema that the client is sending. We should have an
enum of choices, but use `int` type on the wire to prepare for when adding new
enum values.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
