merlimat commented on issue #1527: Reduce un-necessary work when doing bundle lookup for partitioned topic URL: https://github.com/apache/incubator-pulsar/pull/1527#issuecomment-379817560 @zhaijack I need to look well into this change, though I think it looks good. I believe since adding to the ownership map and the linked list are not atomic there still might be some operations done multiple times. One other option could be to convert the `ownedBundlesCache` in `OwnershipCache` to use a `ConcurrentHashMap<String, CompletableFuture<OwnedBundle>>`. That's the same trick we use to load topic, ensuring only the first attempt triggers the load and subsequent attempts will just piggyback on it.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
