sijie commented on a change in pull request #1529: Fix delete topic check and
provide better error message.
URL: https://github.com/apache/incubator-pulsar/pull/1529#discussion_r180237264
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
##########
@@ -471,7 +471,8 @@ protected void internalDeleteTopic(boolean authoritative) {
if (topic.isReplicated()) {
// Delete is disallowed on global topic
log.error("[{}] Delete topic is forbidden on global namespace {}",
clientAppId(), topicName);
- throw new RestException(Status.FORBIDDEN, "Delete forbidden on
global namespace");
+ throw new RestException(Status.FORBIDDEN, "Delete forbidden topic
is replicated on clusters " +
Review comment:
nit: it might be good to keep the error message consistent between exception
and the logging statement above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
