This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git
The following commit(s) were added to refs/heads/master by this push: new edf01a8 Offloading prints wrong log on exception (#1643) edf01a8 is described below commit edf01a80cfc6759063bbf1751334fbbfcd91f55c Author: Ivan Kelly <iv...@apache.org> AuthorDate: Wed Apr 25 23:32:24 2018 +0200 Offloading prints wrong log on exception (#1643) The check for exception was backwards, so it was always warning in the happy case, and reporting success in the case of failure. Master Issue: #1511 --- .../main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java index 197f0b7..db644b2 100644 --- a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java +++ b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java @@ -2092,7 +2092,7 @@ public class ManagedLedgerImpl implements ManagedLedger, CreateCallback { } }) .whenComplete((result, exception) -> { - if (exception != null) { + if (exception == null) { log.info("[{}] End Offload. ledger={}, uuid={}", name, ledgerId, uuid); } else { log.warn("[{}] Failed to complete offload of ledger {}, uuid {}", -- To stop receiving notification emails like this one, please contact si...@apache.org.