jerrypeng commented on a change in pull request #1758: Windowing for Pulsar
Functions
URL: https://github.com/apache/incubator-pulsar/pull/1758#discussion_r187419648
##########
File path:
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
##########
@@ -323,56 +327,129 @@ void processArguments() throws Exception {
throw new IllegalArgumentException("Effectively-once
processing semantics can only be achieved using a Failover subscription type");
}
- functionConfig.setAutoAck(true);
+ // window configs
+ WindowConfig windowConfig = functionConfig.getWindowConfig();
+ if (null != windowLengthCount) {
+ if (windowConfig == null) {
Review comment:
I am not sure that buys us much. I can make the if statement one line:
if (windowConfig == null) windowConfig = new WindowConfig()
but having another function like this:
private void setWindowConfig(Object config, WindowConfig windowConfig) {
if (config != null) {
windowConfig = new WindowConfig();
}
}
is an overkill I think
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
