jerrypeng opened a new pull request #1766: Implementing PushSource on top of Source URL: https://github.com/apache/incubator-pulsar/pull/1766 Changes: 1. Modified the PushSource interface to change to an abstract function 2. Change setConsumer(Function<Record<T>, CompletableFuture<Void>> consumer) -> setConsumer(Consumer<Record<T>> consumer) Since record already has a ack method to indicate acknowledgement. We don't need to completable future mechanism any more
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services