srkukarni commented on a change in pull request #1766: Implementing PushSource on top of Source URL: https://github.com/apache/incubator-pulsar/pull/1766#discussion_r187529796
########## File path: pulsar-io/kafka/src/main/java/org/apache/pulsar/io/kafka/KafkaSource.java ########## @@ -19,6 +19,7 @@ package org.apache.pulsar.io.kafka; +import lombok.Getter; Review comment: kafka source is natively pull source. So we should actually implement it as source<T> ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
