ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader URL: https://github.com/apache/incubator-pulsar/pull/1746#discussion_r187597119
########## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/s3offload/S3ManagedLedgerOffloaderTest.java ########## @@ -18,30 +18,40 @@ */ package org.apache.pulsar.broker.s3offload; +import static org.mockito.Matchers.any; +import static org.testng.Assert.assertEquals; Review comment: why import static when Assert is already pulled in? I've seen other people seem to prefer the static as well. I'm just wondering what the reason behind it is. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
