bruth commented on issue #1764: WIP - Pulsar Go client library URL: https://github.com/apache/incubator-pulsar/pull/1764#issuecomment-389285771 @merlimat Interesting, thanks for the explanation. > we just rely on best-effort acks So in other words, the command is sent to the server *optimistically* and if it fails the observation of this failure is a redelivery. Presumably (and as you said) if there is a connection issue, then the client library will retry sending the command transparently. But once it is sent we are assuming the ack will be handled. So yes in this case you are right that the `context.Context` won't actually influence the outcome. That said, I am still torn if whether it should be part of the signature anyway for consistency or if there is any chance in the future acks could be synchronous. I will leave this for you to decide.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
