merlimat commented on a change in pull request #1845: Functions schema integration URL: https://github.com/apache/incubator-pulsar/pull/1845#discussion_r190985761
########## File path: pulsar-client/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java ########## @@ -94,6 +94,11 @@ */ ConsumerBuilder<T> topics(List<String> topicNames); + /** + * + */ + ConsumerBuilder<T> addTopic(String topicName, Schema<T> schema); Review comment: This is a bit different from the the other `topic()` `topics()` methods. Also I find it confusing having a per topic schema, when the consumer itself needs to be created with a schema ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services