jerrypeng commented on a change in pull request #1956: Add function-package-url
support in function cli add url support to function cli
URL: https://github.com/apache/incubator-pulsar/pull/1956#discussion_r194958982
##########
File path:
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSinks.java
##########
@@ -170,11 +182,11 @@ void runCmd() throws Exception {
protected FunctionConfig.ProcessingGuarantees processingGuarantees;
@Parameter(names = "--parallelism", description = "The sink's
parallelism factor (i.e. the number of sink instances to run)")
protected Integer parallelism;
- @Parameter(
- names = "--jar",
- description = "Path to the jar file for the sink",
- listConverter = StringConverter.class)
+ @Parameter(names = "--jar", description = "Path to the jar file for
the sink. It also supports url-path (http/https/file) from which worker can
download the package.", listConverter = StringConverter.class)
protected String jarFile;
+
+ @Parameter(names = "--classNameArgType", description = "Sink impl
class's argument type if jar-file path is url")
Review comment:
please see comment in CmdSource
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
