srkukarni commented on a change in pull request #1956: Add function-package-url
support in function cli add url support to function cli
URL: https://github.com/apache/incubator-pulsar/pull/1956#discussion_r196628122
##########
File path:
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
##########
@@ -209,10 +218,7 @@ void processArguments() throws Exception {
protected String functionName;
@Parameter(names = "--className", description = "The function's class
name")
protected String className;
- @Parameter(
- names = "--jar",
- description = "Path to the jar file for the function (if the
function is written in Java)",
- listConverter = StringConverter.class)
+ @Parameter(names = "--jar", description = "Path to the jar file for
the function (if the function is written in Java). It also supports url-path
(http/https/file) from which worker can download the package.", listConverter =
StringConverter.class)
Review comment:
While http/https is clear, what does a --jar=file:<value> signifiy? Is it
the same as --jar=<filename> or something else?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
