sijie commented on a change in pull request #2253: Add Test Specific Examples URL: https://github.com/apache/incubator-pulsar/pull/2253#discussion_r205888563
########## File path: pulsar-functions/java-examples/src/main/java/org/apache/pulsar/functions/api/examples/test/ByteBufferSerDe.java ########## @@ -0,0 +1,33 @@ +/** + * Copyright (c) 2018 Streamlio Inc. All Rights Reserved. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.pulsar.functions.api.examples.test; Review comment: I can see only one function is for negative test. It can be under `test` package. However all the other classes are examples: - examples for customizing serde - examples for using custom objects - examples for using context.publish - examples for windowing - examples for config ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
