rdhabalia commented on a change in pull request #2261: Avoid creating output topic on tenant namespace if output-topic not provided URL: https://github.com/apache/incubator-pulsar/pull/2261#discussion_r207673544
########## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java ########## @@ -468,9 +468,6 @@ private void inferMissingArguments(FunctionConfig functionConfig) { if (StringUtils.isEmpty(functionConfig.getNamespace())) { inferMissingNamespace(functionConfig); } - if (StringUtils.isEmpty(functionConfig.getOutput())) { Review comment: > I don't think we should implicitly create a topic for the output. can we merge this PR then. as I have mentioned into motivation: replication-namespace and security are the main concerns so, function should not create output topic implicitly. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services