sijie commented on a change in pull request #2342: Issue 1067: Problems with Partitioned Topics which name contains -partition-N URL: https://github.com/apache/incubator-pulsar/pull/2342#discussion_r209404477
########## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java ########## @@ -254,6 +254,15 @@ protected void validateTopicName(String property, String namespace, String encod this.topicName = TopicName.get(domain(), namespaceName, topic); } + protected void validatePartitionedTopicName(String tenant, String namespace, String encodedTopic) { + // first, it has to be a validate topic name + validateTopicName(tenant, namespace, encodedTopic); + // second, "-partition-" is not allowed + if (encodedTopic.contains("-partition-")) { Review comment: changed it to use the constant ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services