srkukarni commented on a change in pull request #2397: Integrate Functions with
Schema
URL: https://github.com/apache/incubator-pulsar/pull/2397#discussion_r211390843
##########
File path:
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSinks.java
##########
@@ -469,20 +477,56 @@ protected FunctionDetails createSinkConfig(SinkConfig
sinkConfig) throws IOExcep
// set source spec
// source spec classname should be empty so that the default
pulsar source will be used
SourceSpec.Builder sourceSpecBuilder = SourceSpec.newBuilder();
+
sourceSpecBuilder.setSubscriptionType(Function.SubscriptionType.SHARED);
Review comment:
The pr makes it backwards compatible to whats existing out there. Just like
in functions, the idea is that
1) --inputs is a comma separated list of topics that uses default
schema/serde
2) --topics-pattern is topic pattern that uses default schema/serde
3) customSerdeInputs is a map from topicname -> custom serde classname
These above are whats available today already. The newly available one is
4) customSchemaInputs is very similar to 3) but with schemas
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
