jerrypeng commented on a change in pull request #2502: Fix Handling of user
defined nar sources/sinks
URL: https://github.com/apache/incubator-pulsar/pull/2502#discussion_r214500859
##########
File path:
pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java
##########
@@ -246,12 +246,12 @@ public void run() {
private void loadJars() throws Exception {
- if (jarFile.endsWith(".nar")) {
- // The functions code is contained in a NAR archive
+ try {
+ // Let's first try to treat it as a nar archive
fnCache.registerFunctionInstanceWithArchive(instanceConfig.getFunctionId(),
instanceConfig.getInstanceId(),
jarFile);
- } else {
- log.info("Loading JAR files for function {} from archive {}",
instanceConfig, jarFile);
+ } catch (Exception e) {
Review comment:
we should probably just catch the exception that we expect
registerFunctionInstanceWithArchive to throw if its a jar and not a blanket
catch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
