Author: ritchiem
Date: Wed Apr  8 19:43:33 2009
New Revision: 763360

URL: http://svn.apache.org/viewvc?rev=763360&view=rev
Log:
QPID-1793 : Increase logging on requeue to help diagnose what is being 
requeued. Not on critical path so logging should not impact performance.

Modified:
    
qpid/trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/AMQChannel.java

Modified: 
qpid/trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/AMQChannel.java
URL: 
http://svn.apache.org/viewvc/qpid/trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/AMQChannel.java?rev=763360&r1=763359&r2=763360&view=diff
==============================================================================
--- 
qpid/trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/AMQChannel.java
 (original)
+++ 
qpid/trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/AMQChannel.java
 Wed Apr  8 19:43:33 2009
@@ -467,7 +467,15 @@
         {
             if (_log.isInfoEnabled())
             {
-                _log.info("Requeuing " + messagesToBeDelivered.size() + " 
unacked messages. for " + toString());
+                // Requeue only occurs on connection close so this extra 
processing should not be a bottleneck
+                List ids=new LinkedList();
+                for (QueueEntry entry: messagesToBeDelivered)
+                {
+                    ids.add(entry.getMessageId());
+                }
+
+                _log.info("Requeuing " + messagesToBeDelivered.size() + " 
unacked messages(" + ids + "). " +
+                          "for " + toString());               
             }
 
             if (!(_txnContext instanceof NonTransactionalContext))



---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:commits-subscr...@qpid.apache.org

Reply via email to