Author: ritchiem
Date: Mon Aug  3 13:25:40 2009
New Revision: 800365

URL: http://svn.apache.org/viewvc?rev=800365&view=rev
Log:
Removed stale constructor, updated two test cases to use other constructor, 
there is no impact as the tests were passing in null for the removed parameter

Modified:
    
qpid/trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/protocol/AMQMinaProtocolSession.java
    
qpid/trunk/qpid/java/broker/src/test/java/org/apache/qpid/server/protocol/AMQProtocolSessionMBeanTest.java
    
qpid/trunk/qpid/java/broker/src/test/java/org/apache/qpid/server/protocol/MaxChannelsTest.java

Modified: 
qpid/trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/protocol/AMQMinaProtocolSession.java
URL: 
http://svn.apache.org/viewvc/qpid/trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/protocol/AMQMinaProtocolSession.java?rev=800365&r1=800364&r2=800365&view=diff
==============================================================================
--- 
qpid/trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/protocol/AMQMinaProtocolSession.java
 (original)
+++ 
qpid/trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/protocol/AMQMinaProtocolSession.java
 Mon Aug  3 13:25:40 2009
@@ -177,20 +177,6 @@
         }
     }
 
-    // This is only used by two tests that do provide null values for 
stateManager
-    // so we can safely remove this and refactor.
-    public AMQMinaProtocolSession(IoSession session, VirtualHostRegistry 
virtualHostRegistry, AMQCodecFactory codecFactory,
-                                  AMQStateManager stateManager) throws 
AMQException
-    {
-        _stateManager = stateManager;
-        _minaProtocolSession = session;
-        session.setAttachment(this);
-
-        _codecFactory = codecFactory;
-
-        _actor = new AMQPConnectionActor(this, 
virtualHostRegistry.getApplicationRegistry().getRootMessageLogger());
-    }
-
     private AMQProtocolSessionMBean createMBean() throws AMQException
     {
         try

Modified: 
qpid/trunk/qpid/java/broker/src/test/java/org/apache/qpid/server/protocol/AMQProtocolSessionMBeanTest.java
URL: 
http://svn.apache.org/viewvc/qpid/trunk/qpid/java/broker/src/test/java/org/apache/qpid/server/protocol/AMQProtocolSessionMBeanTest.java?rev=800365&r1=800364&r2=800365&view=diff
==============================================================================
--- 
qpid/trunk/qpid/java/broker/src/test/java/org/apache/qpid/server/protocol/AMQProtocolSessionMBeanTest.java
 (original)
+++ 
qpid/trunk/qpid/java/broker/src/test/java/org/apache/qpid/server/protocol/AMQProtocolSessionMBeanTest.java
 Mon Aug  3 13:25:40 2009
@@ -111,8 +111,7 @@
 
         IApplicationRegistry appRegistry = ApplicationRegistry.getInstance();
         _protocolSession =
-                new AMQMinaProtocolSession(new TestIoSession(), 
appRegistry.getVirtualHostRegistry(), new AMQCodecFactory(true),
-                                           null);
+                new AMQMinaProtocolSession(new TestIoSession(), 
appRegistry.getVirtualHostRegistry(), new AMQCodecFactory(true));
         // Need to authenticate session for it to work, (well for logging to 
work)
         _protocolSession.setAuthorizedID(new Principal()
         {

Modified: 
qpid/trunk/qpid/java/broker/src/test/java/org/apache/qpid/server/protocol/MaxChannelsTest.java
URL: 
http://svn.apache.org/viewvc/qpid/trunk/qpid/java/broker/src/test/java/org/apache/qpid/server/protocol/MaxChannelsTest.java?rev=800365&r1=800364&r2=800365&view=diff
==============================================================================
--- 
qpid/trunk/qpid/java/broker/src/test/java/org/apache/qpid/server/protocol/MaxChannelsTest.java
 (original)
+++ 
qpid/trunk/qpid/java/broker/src/test/java/org/apache/qpid/server/protocol/MaxChannelsTest.java
 Mon Aug  3 13:25:40 2009
@@ -41,7 +41,7 @@
     public void testChannels() throws Exception
     {
         _session = new AMQMinaProtocolSession(new TestIoSession(), _appRegistry
-                               .getVirtualHostRegistry(), new 
AMQCodecFactory(true), null);
+                               .getVirtualHostRegistry(), new 
AMQCodecFactory(true));
 
         // Need to authenticate session for it to work, (well for logging to 
work)
         _session.setAuthorizedID(new Principal()



---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:commits-subscr...@qpid.apache.org

Reply via email to