svn commit: r1205183 - in /qpid/trunk/qpid/cpp/src: qmf/engine/ResilientConnection.cpp qpid/broker/Daemon.cpp qpid/sys/posix/LockFile.cpp tests/BrokerMgmtAgent.cpp tests/ForkedBroker.cpp

[tross]

Author: tross
Date: Tue Nov 22 21:32:48 2011
New Revision: 1205183

URL: http://svn.apache.org/viewvc?rev=1205183&view=rev
Log:
NO-JIRA - Fixed the handling of functions with ignored return values.

Modified:
    qpid/trunk/qpid/cpp/src/qmf/engine/ResilientConnection.cpp
    qpid/trunk/qpid/cpp/src/qpid/broker/Daemon.cpp
    qpid/trunk/qpid/cpp/src/qpid/sys/posix/LockFile.cpp
    qpid/trunk/qpid/cpp/src/tests/BrokerMgmtAgent.cpp
    qpid/trunk/qpid/cpp/src/tests/ForkedBroker.cpp

Modified: qpid/trunk/qpid/cpp/src/qmf/engine/ResilientConnection.cpp
URL: 
http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/qmf/engine/ResilientConnection.cpp?rev=1205183&r1=1205182&r2=1205183&view=diff
==============================================================================
--- qpid/trunk/qpid/cpp/src/qmf/engine/ResilientConnection.cpp (original)
+++ qpid/trunk/qpid/cpp/src/qmf/engine/ResilientConnection.cpp Tue Nov 22 
21:32:48 2011
@@ -334,7 +334,7 @@ void ResilientConnectionImpl::notify()
 {
     if (notifyFd != -1)
     {
-        (void) ::write(notifyFd, ".", 1);
+        if (::write(notifyFd, ".", 1)) {}
     }
 }
 
@@ -431,7 +431,7 @@ void ResilientConnectionImpl::EnqueueEve
 
     if (notifyFd != -1)
     {
-        (void) ::write(notifyFd, ".", 1);
+        if (::write(notifyFd, ".", 1)) {}
     }
 }
 

Modified: qpid/trunk/qpid/cpp/src/qpid/broker/Daemon.cpp
URL: 
http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/qpid/broker/Daemon.cpp?rev=1205183&r1=1205182&r2=1205183&view=diff
==============================================================================
--- qpid/trunk/qpid/cpp/src/qpid/broker/Daemon.cpp (original)
+++ qpid/trunk/qpid/cpp/src/qpid/broker/Daemon.cpp Tue Nov 22 21:32:48 2011
@@ -93,13 +93,13 @@ void Daemon::fork()
         catch (const exception& e) {
             QPID_LOG(critical, "Unexpected error: " << e.what());
             uint16_t port = 0;
-            (void) write(pipeFds[1], &port, sizeof(uint16_t));
+            if (write(pipeFds[1], &port, sizeof(uint16_t))) {};
 
             std::string pipeFailureMessage = e.what();
-            (void) write ( pipeFds[1], 
-                    pipeFailureMessage.c_str(), 
-                    strlen(pipeFailureMessage.c_str())
-                  );
+            if (write(pipeFds[1], 
+                      pipeFailureMessage.c_str(), 
+                      strlen(pipeFailureMessage.c_str())
+                      )) {};
         }
     }
     else {                      // Parent

Modified: qpid/trunk/qpid/cpp/src/qpid/sys/posix/LockFile.cpp
URL: 
http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/qpid/sys/posix/LockFile.cpp?rev=1205183&r1=1205182&r2=1205183&view=diff
==============================================================================
--- qpid/trunk/qpid/cpp/src/qpid/sys/posix/LockFile.cpp (original)
+++ qpid/trunk/qpid/cpp/src/qpid/sys/posix/LockFile.cpp Tue Nov 22 21:32:48 2011
@@ -58,7 +58,7 @@ LockFile::~LockFile() {
     if (impl) {
         int f = impl->fd;
         if (f >= 0) {
-            (void) ::lockf(f, F_ULOCK, 0); // Suppress warnings about ignoring 
return value.
+            if(::lockf(f, F_ULOCK, 0)) {} // Suppress warnings about ignoring 
return value.
             ::close(f);
             impl->fd = -1;
         }

Modified: qpid/trunk/qpid/cpp/src/tests/BrokerMgmtAgent.cpp
URL: 
http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/tests/BrokerMgmtAgent.cpp?rev=1205183&r1=1205182&r2=1205183&view=diff
==============================================================================
--- qpid/trunk/qpid/cpp/src/tests/BrokerMgmtAgent.cpp (original)
+++ qpid/trunk/qpid/cpp/src/tests/BrokerMgmtAgent.cpp Tue Nov 22 21:32:48 2011
@@ -604,7 +604,7 @@ namespace qpid {
                 std::stringstream key;
                 key << "testobj-" << i;
                 TestManageable *tm = new TestManageable(agent, key.str());
-                (void) tm->GetManagementObject()->writePropertiesSize();
+                if (tm->GetManagementObject()->writePropertiesSize()) {}
                 agent->addObject(tm->GetManagementObject(), key.str());
                 tmv.push_back(tm);
             }

Modified: qpid/trunk/qpid/cpp/src/tests/ForkedBroker.cpp
URL: 
http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/tests/ForkedBroker.cpp?rev=1205183&r1=1205182&r2=1205183&view=diff
==============================================================================
--- qpid/trunk/qpid/cpp/src/tests/ForkedBroker.cpp (original)
+++ qpid/trunk/qpid/cpp/src/tests/ForkedBroker.cpp Tue Nov 22 21:32:48 2011
@@ -68,7 +68,7 @@ ForkedBroker::~ForkedBroker() {
     }
     if (!dataDir.empty())
     {
-        (void) ::system(("rm -rf "+dataDir).c_str());
+        if(::system(("rm -rf "+dataDir).c_str())) {}
     }
 }
 



---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:commits-subscr...@qpid.apache.org