Author: astitcher Date: Wed May 16 22:28:22 2012 New Revision: 1339403 URL: http://svn.apache.org/viewvc?rev=1339403&view=rev Log: QPID-4005: Eliminate "using" especially "using namespace" from header file
Modified: qpid/trunk/qpid/cpp/include/qpid/framing/ProtocolVersion.h qpid/trunk/qpid/cpp/include/qpid/framing/amqp_types.h qpid/trunk/qpid/cpp/src/qpid/broker/Connection.cpp qpid/trunk/qpid/cpp/src/qpid/broker/ConnectionHandler.cpp qpid/trunk/qpid/cpp/src/qpid/broker/DirectExchange.cpp qpid/trunk/qpid/cpp/src/qpid/broker/Exchange.cpp qpid/trunk/qpid/cpp/src/qpid/broker/FanOutExchange.cpp qpid/trunk/qpid/cpp/src/qpid/broker/HeadersExchange.cpp qpid/trunk/qpid/cpp/src/qpid/broker/Queue.cpp qpid/trunk/qpid/cpp/src/qpid/broker/QueueFlowLimit.cpp qpid/trunk/qpid/cpp/src/qpid/broker/QueuePolicy.cpp qpid/trunk/qpid/cpp/src/qpid/broker/SaslAuthenticator.cpp qpid/trunk/qpid/cpp/src/qpid/broker/SessionAdapter.cpp qpid/trunk/qpid/cpp/src/qpid/broker/SessionState.cpp qpid/trunk/qpid/cpp/src/qpid/client/ConnectionHandler.cpp qpid/trunk/qpid/cpp/src/qpid/client/SessionImpl.cpp qpid/trunk/qpid/cpp/src/qpid/cluster/Connection.cpp qpid/trunk/qpid/cpp/src/qpid/cluster/UpdateClient.cpp qpid/trunk/qpid/cpp/src/qpid/framing/AMQContentBody.cpp qpid/trunk/qpid/cpp/src/qpid/framing/AMQContentBody.h qpid/trunk/qpid/cpp/src/qpid/management/ManagementDirectExchange.cpp qpid/trunk/qpid/cpp/src/qpid/management/ManagementTopicExchange.cpp qpid/trunk/qpid/cpp/src/qpid/replication/ReplicationExchange.cpp qpid/trunk/qpid/cpp/src/tests/ExchangeTest.cpp qpid/trunk/qpid/cpp/src/tests/FieldTable.cpp qpid/trunk/qpid/cpp/src/tests/MessageBuilderTest.cpp qpid/trunk/qpid/cpp/src/tests/MessageTest.cpp qpid/trunk/qpid/cpp/src/tests/MessageUtils.h qpid/trunk/qpid/cpp/src/tests/QueueTest.cpp qpid/trunk/qpid/cpp/src/tests/TestMessageStore.h qpid/trunk/qpid/cpp/src/tests/TxPublishTest.cpp Modified: qpid/trunk/qpid/cpp/include/qpid/framing/ProtocolVersion.h URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/include/qpid/framing/ProtocolVersion.h?rev=1339403&r1=1339402&r2=1339403&view=diff ============================================================================== --- qpid/trunk/qpid/cpp/include/qpid/framing/ProtocolVersion.h (original) +++ qpid/trunk/qpid/cpp/include/qpid/framing/ProtocolVersion.h Wed May 16 22:28:22 2012 @@ -24,6 +24,8 @@ #include "qpid/framing/amqp_types.h" #include "qpid/CommonImportExport.h" +#include <string> + namespace qpid { namespace framing Modified: qpid/trunk/qpid/cpp/include/qpid/framing/amqp_types.h URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/include/qpid/framing/amqp_types.h?rev=1339403&r1=1339402&r2=1339403&view=diff ============================================================================== --- qpid/trunk/qpid/cpp/include/qpid/framing/amqp_types.h (original) +++ qpid/trunk/qpid/cpp/include/qpid/framing/amqp_types.h Wed May 16 22:28:22 2012 @@ -27,12 +27,10 @@ */ #include "qpid/sys/IntegerTypes.h" -#include <string> namespace qpid { namespace framing { -using std::string; typedef uint8_t FrameType; typedef uint16_t ChannelId; typedef uint32_t BatchOffset; Modified: qpid/trunk/qpid/cpp/src/qpid/broker/Connection.cpp URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/qpid/broker/Connection.cpp?rev=1339403&r1=1339402&r2=1339403&view=diff ============================================================================== --- qpid/trunk/qpid/cpp/src/qpid/broker/Connection.cpp (original) +++ qpid/trunk/qpid/cpp/src/qpid/broker/Connection.cpp Wed May 16 22:28:22 2012 @@ -43,7 +43,7 @@ #include <iostream> #include <assert.h> - +using std::string; using namespace qpid::sys; using namespace qpid::framing; Modified: qpid/trunk/qpid/cpp/src/qpid/broker/ConnectionHandler.cpp URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/qpid/broker/ConnectionHandler.cpp?rev=1339403&r1=1339402&r2=1339403&view=diff ============================================================================== --- qpid/trunk/qpid/cpp/src/qpid/broker/ConnectionHandler.cpp (original) +++ qpid/trunk/qpid/cpp/src/qpid/broker/ConnectionHandler.cpp Wed May 16 22:28:22 2012 @@ -36,6 +36,9 @@ using namespace qpid; using namespace qpid::broker; + +using std::string; + using namespace qpid::framing; using qpid::sys::SecurityLayer; namespace _qmf = qmf::org::apache::qpid::broker; Modified: qpid/trunk/qpid/cpp/src/qpid/broker/DirectExchange.cpp URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/qpid/broker/DirectExchange.cpp?rev=1339403&r1=1339402&r2=1339403&view=diff ============================================================================== --- qpid/trunk/qpid/cpp/src/qpid/broker/DirectExchange.cpp (original) +++ qpid/trunk/qpid/cpp/src/qpid/broker/DirectExchange.cpp Wed May 16 22:28:22 2012 @@ -26,6 +26,9 @@ #include <iostream> using namespace qpid::broker; + +using std::string; + using namespace qpid::framing; using namespace qpid::sys; using qpid::management::Manageable; Modified: qpid/trunk/qpid/cpp/src/qpid/broker/Exchange.cpp URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/qpid/broker/Exchange.cpp?rev=1339403&r1=1339402&r2=1339403&view=diff ============================================================================== --- qpid/trunk/qpid/cpp/src/qpid/broker/Exchange.cpp (original) +++ qpid/trunk/qpid/cpp/src/qpid/broker/Exchange.cpp Wed May 16 22:28:22 2012 @@ -35,6 +35,8 @@ namespace qpid { namespace broker { +using std::string; + using namespace qpid::framing; using qpid::framing::Buffer; using qpid::framing::FieldTable; Modified: qpid/trunk/qpid/cpp/src/qpid/broker/FanOutExchange.cpp URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/qpid/broker/FanOutExchange.cpp?rev=1339403&r1=1339402&r2=1339403&view=diff ============================================================================== --- qpid/trunk/qpid/cpp/src/qpid/broker/FanOutExchange.cpp (original) +++ qpid/trunk/qpid/cpp/src/qpid/broker/FanOutExchange.cpp Wed May 16 22:28:22 2012 @@ -24,6 +24,9 @@ #include <algorithm> using namespace qpid::broker; + +using std::string; + using namespace qpid::framing; using namespace qpid::sys; namespace _qmf = qmf::org::apache::qpid::broker; Modified: qpid/trunk/qpid/cpp/src/qpid/broker/HeadersExchange.cpp URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/qpid/broker/HeadersExchange.cpp?rev=1339403&r1=1339402&r2=1339403&view=diff ============================================================================== --- qpid/trunk/qpid/cpp/src/qpid/broker/HeadersExchange.cpp (original) +++ qpid/trunk/qpid/cpp/src/qpid/broker/HeadersExchange.cpp Wed May 16 22:28:22 2012 @@ -26,6 +26,9 @@ using namespace qpid::broker; + +using std::string; + using namespace qpid::framing; using namespace qpid::sys; namespace _qmf = qmf::org::apache::qpid::broker; Modified: qpid/trunk/qpid/cpp/src/qpid/broker/Queue.cpp URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/qpid/broker/Queue.cpp?rev=1339403&r1=1339402&r2=1339403&view=diff ============================================================================== --- qpid/trunk/qpid/cpp/src/qpid/broker/Queue.cpp (original) +++ qpid/trunk/qpid/cpp/src/qpid/broker/Queue.cpp Wed May 16 22:28:22 2012 @@ -67,6 +67,7 @@ using qpid::management::ManagementAgent; using qpid::management::ManagementObject; using qpid::management::Manageable; using qpid::management::Args; +using std::string; using std::for_each; using std::mem_fun; namespace _qmf = qmf::org::apache::qpid::broker; Modified: qpid/trunk/qpid/cpp/src/qpid/broker/QueueFlowLimit.cpp URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/qpid/broker/QueueFlowLimit.cpp?rev=1339403&r1=1339402&r2=1339403&view=diff ============================================================================== --- qpid/trunk/qpid/cpp/src/qpid/broker/QueueFlowLimit.cpp (original) +++ qpid/trunk/qpid/cpp/src/qpid/broker/QueueFlowLimit.cpp Wed May 16 22:28:22 2012 @@ -75,8 +75,8 @@ namespace { result = v->get<int64_t>(); QPID_LOG(debug, "Got integer value for " << key << ": " << result); if (result >= 0) return result; - } else if (v->convertsTo<string>()) { - string s(v->get<string>()); + } else if (v->convertsTo<std::string>()) { + std::string s(v->get<std::string>()); QPID_LOG(debug, "Got string value for " << key << ": " << s); std::istringstream convert(s); if (convert >> result && result >= 0) return result; Modified: qpid/trunk/qpid/cpp/src/qpid/broker/QueuePolicy.cpp URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/qpid/broker/QueuePolicy.cpp?rev=1339403&r1=1339402&r2=1339403&view=diff ============================================================================== --- qpid/trunk/qpid/cpp/src/qpid/broker/QueuePolicy.cpp (original) +++ qpid/trunk/qpid/cpp/src/qpid/broker/QueuePolicy.cpp Wed May 16 22:28:22 2012 @@ -133,8 +133,8 @@ T getCapacity(const FieldTable& settings result = v->get<T>(); QPID_LOG(debug, "Got integer value for " << key << ": " << result); if (result >= 0) return result; - } else if (v->convertsTo<string>()) { - string s(v->get<string>()); + } else if (v->convertsTo<std::string>()) { + std::string s(v->get<std::string>()); QPID_LOG(debug, "Got string value for " << key << ": " << s); std::istringstream convert(s); if (convert >> result && result >= 0 && convert.eof()) return result; Modified: qpid/trunk/qpid/cpp/src/qpid/broker/SaslAuthenticator.cpp URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/qpid/broker/SaslAuthenticator.cpp?rev=1339403&r1=1339402&r2=1339403&view=diff ============================================================================== --- qpid/trunk/qpid/cpp/src/qpid/broker/SaslAuthenticator.cpp (original) +++ qpid/trunk/qpid/cpp/src/qpid/broker/SaslAuthenticator.cpp Wed May 16 22:28:22 2012 @@ -37,6 +37,7 @@ using qpid::sys::cyrus::CyrusSecurityLayer; #endif +using std::string; using namespace qpid::framing; using qpid::sys::SecurityLayer; using qpid::sys::SecuritySettings; Modified: qpid/trunk/qpid/cpp/src/qpid/broker/SessionAdapter.cpp URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/qpid/broker/SessionAdapter.cpp?rev=1339403&r1=1339402&r2=1339403&view=diff ============================================================================== --- qpid/trunk/qpid/cpp/src/qpid/broker/SessionAdapter.cpp (original) +++ qpid/trunk/qpid/cpp/src/qpid/broker/SessionAdapter.cpp Wed May 16 22:28:22 2012 @@ -41,6 +41,8 @@ namespace qpid { namespace broker { +using std::string; + using namespace qpid; using namespace qpid::framing; using namespace qpid::framing::dtx; Modified: qpid/trunk/qpid/cpp/src/qpid/broker/SessionState.cpp URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/qpid/broker/SessionState.cpp?rev=1339403&r1=1339402&r2=1339403&view=diff ============================================================================== --- qpid/trunk/qpid/cpp/src/qpid/broker/SessionState.cpp (original) +++ qpid/trunk/qpid/cpp/src/qpid/broker/SessionState.cpp Wed May 16 22:28:22 2012 @@ -156,7 +156,7 @@ ManagementObject* SessionState::GetManag Manageable::status_t SessionState::ManagementMethod (uint32_t methodId, Args& /*args*/, - string& /*text*/) + std::string& /*text*/) { Manageable::status_t status = Manageable::STATUS_UNKNOWN_METHOD; Modified: qpid/trunk/qpid/cpp/src/qpid/client/ConnectionHandler.cpp URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/qpid/client/ConnectionHandler.cpp?rev=1339403&r1=1339402&r2=1339403&view=diff ============================================================================== --- qpid/trunk/qpid/cpp/src/qpid/client/ConnectionHandler.cpp (original) +++ qpid/trunk/qpid/cpp/src/qpid/client/ConnectionHandler.cpp Wed May 16 22:28:22 2012 @@ -258,7 +258,7 @@ void ConnectionHandler::start(const Fiel } if (sasl.get()) { - string response; + std::string response; if (sasl->start(join(mechlist), response, getSecuritySettings ? getSecuritySettings() : 0)) { proxy.startOk(properties, sasl->getMechanism(), response, locale); } else { @@ -272,7 +272,7 @@ void ConnectionHandler::start(const Fiel } } else { //TODO: verify that desired mechanism and locale are supported - string response = ((char)0) + username + ((char)0) + password; + std::string response = ((char)0) + username + ((char)0) + password; proxy.startOk(properties, mechanism, response, locale); } } @@ -280,7 +280,7 @@ void ConnectionHandler::start(const Fiel void ConnectionHandler::secure(const std::string& challenge) { if (sasl.get()) { - string response = sasl->step(challenge); + std::string response = sasl->step(challenge); proxy.secureOk(response); } else { throw NotImplementedException("Challenge-response cycle not yet implemented in client"); Modified: qpid/trunk/qpid/cpp/src/qpid/client/SessionImpl.cpp URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/qpid/client/SessionImpl.cpp?rev=1339403&r1=1339402&r2=1339403&view=diff ============================================================================== --- qpid/trunk/qpid/cpp/src/qpid/client/SessionImpl.cpp (original) +++ qpid/trunk/qpid/cpp/src/qpid/client/SessionImpl.cpp Wed May 16 22:28:22 2012 @@ -426,7 +426,7 @@ void SessionImpl::sendContent(const Meth uint32_t remaining = data_length - offset; while (remaining > 0) { uint32_t length = remaining > frag_size ? frag_size : remaining; - string frag(content.getData().substr(offset, length)); + std::string frag(content.getData().substr(offset, length)); AMQFrame frame((AMQContentBody(frag))); frame.setFirstSegment(false); frame.setLastSegment(true); Modified: qpid/trunk/qpid/cpp/src/qpid/cluster/Connection.cpp URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/qpid/cluster/Connection.cpp?rev=1339403&r1=1339402&r2=1339403&view=diff ============================================================================== --- qpid/trunk/qpid/cpp/src/qpid/cluster/Connection.cpp (original) +++ qpid/trunk/qpid/cpp/src/qpid/cluster/Connection.cpp Wed May 16 22:28:22 2012 @@ -58,6 +58,8 @@ namespace qpid { namespace cluster { +using std::string; + using namespace framing; using namespace framing::cluster; using amqp_0_10::ListCodec; Modified: qpid/trunk/qpid/cpp/src/qpid/cluster/UpdateClient.cpp URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/qpid/cluster/UpdateClient.cpp?rev=1339403&r1=1339402&r2=1339403&view=diff ============================================================================== --- qpid/trunk/qpid/cpp/src/qpid/cluster/UpdateClient.cpp (original) +++ qpid/trunk/qpid/cpp/src/qpid/cluster/UpdateClient.cpp Wed May 16 22:28:22 2012 @@ -74,6 +74,8 @@ namespace qpid { namespace cluster { +using std::string; + using amqp_0_10::ListCodec; using broker::Broker; using broker::Exchange; Modified: qpid/trunk/qpid/cpp/src/qpid/framing/AMQContentBody.cpp URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/qpid/framing/AMQContentBody.cpp?rev=1339403&r1=1339402&r2=1339403&view=diff ============================================================================== --- qpid/trunk/qpid/cpp/src/qpid/framing/AMQContentBody.cpp (original) +++ qpid/trunk/qpid/cpp/src/qpid/framing/AMQContentBody.cpp Wed May 16 22:28:22 2012 @@ -24,7 +24,7 @@ qpid::framing::AMQContentBody::AMQContentBody(){ } -qpid::framing::AMQContentBody::AMQContentBody(const string& _data) : data(_data){ +qpid::framing::AMQContentBody::AMQContentBody(const std::string& _data) : data(_data){ } uint32_t qpid::framing::AMQContentBody::encodedSize() const{ Modified: qpid/trunk/qpid/cpp/src/qpid/framing/AMQContentBody.h URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/qpid/framing/AMQContentBody.h?rev=1339403&r1=1339402&r2=1339403&view=diff ============================================================================== --- qpid/trunk/qpid/cpp/src/qpid/framing/AMQContentBody.h (original) +++ qpid/trunk/qpid/cpp/src/qpid/framing/AMQContentBody.h Wed May 16 22:28:22 2012 @@ -31,15 +31,15 @@ namespace framing { class QPID_COMMON_CLASS_EXTERN AMQContentBody : public AMQBody { - string data; + std::string data; public: QPID_COMMON_EXTERN AMQContentBody(); - QPID_COMMON_EXTERN AMQContentBody(const string& data); + QPID_COMMON_EXTERN AMQContentBody(const std::string& data); inline virtual ~AMQContentBody(){} inline uint8_t type() const { return CONTENT_BODY; }; - inline const string& getData() const { return data; } - inline string& getData() { return data; } + inline const std::string& getData() const { return data; } + inline std::string& getData() { return data; } QPID_COMMON_EXTERN uint32_t encodedSize() const; QPID_COMMON_EXTERN void encode(Buffer& buffer) const; QPID_COMMON_EXTERN void decode(Buffer& buffer, uint32_t size); Modified: qpid/trunk/qpid/cpp/src/qpid/management/ManagementDirectExchange.cpp URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/qpid/management/ManagementDirectExchange.cpp?rev=1339403&r1=1339402&r2=1339403&view=diff ============================================================================== --- qpid/trunk/qpid/cpp/src/qpid/management/ManagementDirectExchange.cpp (original) +++ qpid/trunk/qpid/cpp/src/qpid/management/ManagementDirectExchange.cpp Wed May 16 22:28:22 2012 @@ -28,7 +28,7 @@ using namespace qpid::broker; using namespace qpid::framing; using namespace qpid::sys; -ManagementDirectExchange::ManagementDirectExchange(const string& _name, Manageable* _parent, Broker* b) : +ManagementDirectExchange::ManagementDirectExchange(const std::string& _name, Manageable* _parent, Broker* b) : Exchange (_name, _parent, b), DirectExchange(_name, _parent, b), managementAgent(0) {} @@ -43,7 +43,7 @@ ManagementDirectExchange::ManagementDire void ManagementDirectExchange::route(Deliverable& msg) { bool routeIt = true; - const string& routingKey = msg.getMessage().getRoutingKey(); + const std::string& routingKey = msg.getMessage().getRoutingKey(); const FieldTable* args = msg.getMessage().getApplicationHeaders(); if (managementAgent) Modified: qpid/trunk/qpid/cpp/src/qpid/management/ManagementTopicExchange.cpp URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/qpid/management/ManagementTopicExchange.cpp?rev=1339403&r1=1339402&r2=1339403&view=diff ============================================================================== --- qpid/trunk/qpid/cpp/src/qpid/management/ManagementTopicExchange.cpp (original) +++ qpid/trunk/qpid/cpp/src/qpid/management/ManagementTopicExchange.cpp Wed May 16 22:28:22 2012 @@ -27,7 +27,7 @@ using namespace qpid::broker; using namespace qpid::framing; using namespace qpid::sys; -ManagementTopicExchange::ManagementTopicExchange(const string& _name, Manageable* _parent, Broker* b) : +ManagementTopicExchange::ManagementTopicExchange(const std::string& _name, Manageable* _parent, Broker* b) : Exchange (_name, _parent, b), TopicExchange(_name, _parent, b), managementAgent(0) {} @@ -42,7 +42,7 @@ ManagementTopicExchange::ManagementTopic void ManagementTopicExchange::route(Deliverable& msg) { bool routeIt = true; - const string& routingKey = msg.getMessage().getRoutingKey(); + const std::string& routingKey = msg.getMessage().getRoutingKey(); const FieldTable* args = msg.getMessage().getApplicationHeaders(); // Intercept management agent commands @@ -54,7 +54,7 @@ void ManagementTopicExchange::route(Deli } bool ManagementTopicExchange::bind(Queue::shared_ptr queue, - const string& routingKey, + const std::string& routingKey, const qpid::framing::FieldTable* args) { if (qmfVersion == 1) Modified: qpid/trunk/qpid/cpp/src/qpid/replication/ReplicationExchange.cpp URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/qpid/replication/ReplicationExchange.cpp?rev=1339403&r1=1339402&r2=1339403&view=diff ============================================================================== --- qpid/trunk/qpid/cpp/src/qpid/replication/ReplicationExchange.cpp (original) +++ qpid/trunk/qpid/cpp/src/qpid/replication/ReplicationExchange.cpp Wed May 16 22:28:22 2012 @@ -184,7 +184,7 @@ bool ReplicationExchange::unbind(Queue:: throw NotImplementedException("Replication exchange does not support unbind operation"); } -bool ReplicationExchange::isBound(Queue::shared_ptr /*queue*/, const string* const /*routingKey*/, const FieldTable* const /*args*/) +bool ReplicationExchange::isBound(Queue::shared_ptr /*queue*/, const std::string* const /*routingKey*/, const FieldTable* const /*args*/) { return false; } Modified: qpid/trunk/qpid/cpp/src/tests/ExchangeTest.cpp URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/tests/ExchangeTest.cpp?rev=1339403&r1=1339402&r2=1339403&view=diff ============================================================================== --- qpid/trunk/qpid/cpp/src/tests/ExchangeTest.cpp (original) +++ qpid/trunk/qpid/cpp/src/tests/ExchangeTest.cpp Wed May 16 22:28:22 2012 @@ -33,6 +33,8 @@ #include <iostream> #include "MessageUtils.h" +using std::string; + using boost::intrusive_ptr; using namespace qpid::broker; using namespace qpid::framing; Modified: qpid/trunk/qpid/cpp/src/tests/FieldTable.cpp URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/tests/FieldTable.cpp?rev=1339403&r1=1339402&r2=1339403&view=diff ============================================================================== --- qpid/trunk/qpid/cpp/src/tests/FieldTable.cpp (original) +++ qpid/trunk/qpid/cpp/src/tests/FieldTable.cpp Wed May 16 22:28:22 2012 @@ -29,6 +29,8 @@ using namespace qpid::framing; +using std::string; + namespace qpid { namespace tests { Modified: qpid/trunk/qpid/cpp/src/tests/MessageBuilderTest.cpp URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/tests/MessageBuilderTest.cpp?rev=1339403&r1=1339402&r2=1339403&view=diff ============================================================================== --- qpid/trunk/qpid/cpp/src/tests/MessageBuilderTest.cpp (original) +++ qpid/trunk/qpid/cpp/src/tests/MessageBuilderTest.cpp Wed May 16 22:28:22 2012 @@ -40,7 +40,7 @@ class MockMessageStore : public NullMess uint64_t id; boost::intrusive_ptr<PersistableMessage> expectedMsg; - string expectedData; + std::string expectedData; std::list<Op> ops; void checkExpectation(Op actual) @@ -58,7 +58,7 @@ class MockMessageStore : public NullMess ops.push_back(STAGE); } - void expectAppendContent(PersistableMessage& msg, const string& data) + void expectAppendContent(PersistableMessage& msg, const std::string& data) { expectedMsg = &msg; expectedData = data; @@ -73,7 +73,7 @@ class MockMessageStore : public NullMess } void appendContent(const boost::intrusive_ptr<const PersistableMessage>& msg, - const string& data) + const std::string& data) { checkExpectation(APPEND); BOOST_CHECK_EQUAL(boost::static_pointer_cast<const PersistableMessage>(expectedMsg), msg); Modified: qpid/trunk/qpid/cpp/src/tests/MessageTest.cpp URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/tests/MessageTest.cpp?rev=1339403&r1=1339402&r2=1339403&view=diff ============================================================================== --- qpid/trunk/qpid/cpp/src/tests/MessageTest.cpp (original) +++ qpid/trunk/qpid/cpp/src/tests/MessageTest.cpp Wed May 16 22:28:22 2012 @@ -33,6 +33,8 @@ using namespace qpid::broker; using namespace qpid::framing; +using std::string; + namespace qpid { namespace tests { Modified: qpid/trunk/qpid/cpp/src/tests/MessageUtils.h URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/tests/MessageUtils.h?rev=1339403&r1=1339402&r2=1339403&view=diff ============================================================================== --- qpid/trunk/qpid/cpp/src/tests/MessageUtils.h (original) +++ qpid/trunk/qpid/cpp/src/tests/MessageUtils.h Wed May 16 22:28:22 2012 @@ -33,7 +33,7 @@ namespace tests { struct MessageUtils { - static boost::intrusive_ptr<Message> createMessage(const string& exchange="", const string& routingKey="", + static boost::intrusive_ptr<Message> createMessage(const std::string& exchange="", const std::string& routingKey="", const bool durable = false, const Uuid& messageId=Uuid(true), uint64_t contentSize = 0) { @@ -53,7 +53,7 @@ struct MessageUtils return msg; } - static void addContent(boost::intrusive_ptr<Message> msg, const string& data) + static void addContent(boost::intrusive_ptr<Message> msg, const std::string& data) { AMQFrame content((AMQContentBody(data))); msg->getFrames().append(content); Modified: qpid/trunk/qpid/cpp/src/tests/QueueTest.cpp URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/tests/QueueTest.cpp?rev=1339403&r1=1339402&r2=1339403&view=diff ============================================================================== --- qpid/trunk/qpid/cpp/src/tests/QueueTest.cpp (original) +++ qpid/trunk/qpid/cpp/src/tests/QueueTest.cpp Wed May 16 22:28:22 2012 @@ -42,6 +42,8 @@ #include <iostream> #include "boost/format.hpp" +using std::string; + using boost::intrusive_ptr; using namespace qpid; using namespace qpid::broker; Modified: qpid/trunk/qpid/cpp/src/tests/TestMessageStore.h URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/tests/TestMessageStore.h?rev=1339403&r1=1339402&r2=1339403&view=diff ============================================================================== --- qpid/trunk/qpid/cpp/src/tests/TestMessageStore.h (original) +++ qpid/trunk/qpid/cpp/src/tests/TestMessageStore.h Wed May 16 22:28:22 2012 @@ -31,7 +31,7 @@ using namespace qpid::framing; namespace qpid { namespace tests { -typedef std::pair<string, boost::intrusive_ptr<PersistableMessage> > msg_queue_pair; +typedef std::pair<std::string, boost::intrusive_ptr<PersistableMessage> > msg_queue_pair; class TestMessageStore : public NullMessageStore { Modified: qpid/trunk/qpid/cpp/src/tests/TxPublishTest.cpp URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/tests/TxPublishTest.cpp?rev=1339403&r1=1339402&r2=1339403&view=diff ============================================================================== --- qpid/trunk/qpid/cpp/src/tests/TxPublishTest.cpp (original) +++ qpid/trunk/qpid/cpp/src/tests/TxPublishTest.cpp Wed May 16 22:28:22 2012 @@ -69,9 +69,9 @@ QPID_AUTO_TEST_CASE(testPrepare) //ensure messages are enqueued in store t.op.prepare(0); BOOST_CHECK_EQUAL((size_t) 2, t.store.enqueued.size()); - BOOST_CHECK_EQUAL(string("queue1"), t.store.enqueued[0].first); + BOOST_CHECK_EQUAL(std::string("queue1"), t.store.enqueued[0].first); BOOST_CHECK_EQUAL(pmsg, t.store.enqueued[0].second); - BOOST_CHECK_EQUAL(string("queue2"), t.store.enqueued[1].first); + BOOST_CHECK_EQUAL(std::string("queue2"), t.store.enqueued[1].first); BOOST_CHECK_EQUAL(pmsg, t.store.enqueued[1].second); BOOST_CHECK_EQUAL( true, ( boost::static_pointer_cast<PersistableMessage>(t.msg))->isIngressComplete()); } --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@qpid.apache.org For additional commands, e-mail: commits-h...@qpid.apache.org