Author: cliffjansen
Date: Sat Feb 9 07:43:33 2013
New Revision: 1444336
URL: http://svn.apache.org/r1444336
Log:
PROTON-221: test gcc version before setting compat flags
Modified:
qpid/proton/trunk/proton-c/CMakeLists.txt
Modified: qpid/proton/trunk/proton-c/CMakeLists.txt
URL:
http://svn.apache.org/viewvc/qpid/proton/trunk/proton-c/CMakeLists.txt?rev=1444336&r1=1444335&r2=1444336&view=diff
==============================================================================
--- qpid/proton/trunk/proton-c/CMakeLists.txt (original)
+++ qpid/proton/trunk/proton-c/CMakeLists.txt Sat Feb 9 07:43:33 2013
@@ -208,11 +208,20 @@ if (CMAKE_COMPILER_IS_GNUCC)
if (NOT BUILD_WITH_CXX)
set (COMPILE_LANGUAGE_FLAGS "-std=c99")
set (COMPILE_PLATFORM_FLAGS "-std=gnu99")
- set (COMPILE_WARNING_FLAGS "${COMPILE_WARNING_FLAGS} -Wc++-compat -Wvla
-Wsign-compare -Wwrite-strings")
+
+ execute_process(COMMAND ${CMAKE_C_COMPILER} -dumpversion OUTPUT_VARIABLE
GCC_VERSION
+ OUTPUT_STRIP_TRAILING_WHITESPACE)
+ if (${GCC_VERSION} VERSION_LESS "4.3.0")
+ # Only a concern if contibuting code back.
+ message (STATUS "Old gcc version detected. C++ compatibility checks
disabled")
+ else (${GCC_VERSION} VERSION_LESS "4.3.0")
+ set (COMPILE_WARNING_FLAGS "${COMPILE_WARNING_FLAGS} -Wc++-compat -Wvla
-Wsign-compare -Wwrite-strings")
+ endif (${GCC_VERSION} VERSION_LESS "4.3.0")
else (NOT BUILD_WITH_CXX)
# allow "%z" format specifier
set (COMPILE_WARNING_FLAGS "${COMPILE_WARNING_FLAGS} -Wno-format")
endif (NOT BUILD_WITH_CXX)
+
if (ENABLE_UNDEFINED_ERROR)
set (CATCH_UNDEFINED "-Wl,--no-undefined")
set (ALLOW_UNDEFINED "-Wl,--allow-shlib-undefined")
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@qpid.apache.org
For additional commands, e-mail: commits-h...@qpid.apache.org
