Make the object immutable and read the encoding type for new Object
mesage types from the parent connection.

Project: http://git-wip-us.apache.org/repos/asf/qpid-jms/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-jms/commit/3a85addd
Tree: http://git-wip-us.apache.org/repos/asf/qpid-jms/tree/3a85addd
Diff: http://git-wip-us.apache.org/repos/asf/qpid-jms/diff/3a85addd

Branch: refs/heads/master
Commit: 3a85adddb4c44f63b520203ab81e906171c9db07
Parents: 1cfb756
Author: Timothy Bish <tabish...@gmail.com>
Authored: Wed Oct 8 17:00:01 2014 -0400
Committer: Timothy Bish <tabish...@gmail.com>
Committed: Wed Oct 8 17:00:01 2014 -0400

----------------------------------------------------------------------
 .../provider/amqp/message/AmqpJmsMessageFactory.java    | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/qpid-jms/blob/3a85addd/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/message/AmqpJmsMessageFactory.java
----------------------------------------------------------------------
diff --git 
a/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/message/AmqpJmsMessageFactory.java
 
b/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/message/AmqpJmsMessageFactory.java
index 214d8e4..02d6f3b 100644
--- 
a/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/message/AmqpJmsMessageFactory.java
+++ 
b/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/message/AmqpJmsMessageFactory.java
@@ -41,10 +41,7 @@ import org.apache.qpid.jms.provider.amqp.AmqpConnection;
  */
 public class AmqpJmsMessageFactory implements JmsMessageFactory {
 
-    private AmqpConnection connection;
-
-    public AmqpJmsMessageFactory() {
-    }
+    private final AmqpConnection connection;
 
     public AmqpJmsMessageFactory(AmqpConnection connection) {
         this.connection = connection;
@@ -54,10 +51,6 @@ public class AmqpJmsMessageFactory implements 
JmsMessageFactory {
         return this.connection;
     }
 
-    public void setAmqpConnection(AmqpConnection connection) {
-        this.connection = connection;
-    }
-
     @Override
     public JmsMessage createMessage() throws JMSException {
         return new JmsMessage(new AmqpJmsMessageFacade(connection));
@@ -102,8 +95,7 @@ public class AmqpJmsMessageFactory implements 
JmsMessageFactory {
 
     @Override
     public JmsObjectMessage createObjectMessage(Serializable payload) throws 
JMSException {
-        // TODO Implement [Connection?] configuration to control default 
delegate type?
-        JmsObjectMessageFacade facade = new 
AmqpJmsObjectMessageFacade(connection, false);
+        JmsObjectMessageFacade facade = new 
AmqpJmsObjectMessageFacade(connection, 
connection.isObjectMessageUsesAmqpTypes());
 
         if (payload != null) {
             try {


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@qpid.apache.org
For additional commands, e-mail: commits-h...@qpid.apache.org

Reply via email to