NO-JIRA: [Java Client, AMQP 0-x] Remove MessageConverterTest#testMessageConversion which does not test anything of value.
The test setup sets properties on a message. The test then calls the same method to set the same properties on a Dummy implementation of Message. The test then asserts that the two messages have the same properties. Project: http://git-wip-us.apache.org/repos/asf/qpid-jms-amqp-0-x/repo Commit: http://git-wip-us.apache.org/repos/asf/qpid-jms-amqp-0-x/commit/ffa282d5 Tree: http://git-wip-us.apache.org/repos/asf/qpid-jms-amqp-0-x/tree/ffa282d5 Diff: http://git-wip-us.apache.org/repos/asf/qpid-jms-amqp-0-x/diff/ffa282d5 Branch: refs/heads/master Commit: ffa282d5e582363a103f5337c490d9f2ec602f91 Parents: 8774a1c Author: Lorenz Quack <lqu...@apache.org> Authored: Wed Nov 8 14:38:23 2017 +0000 Committer: Lorenz Quack <lqu...@apache.org> Committed: Wed Nov 8 14:49:18 2017 +0000 ---------------------------------------------------------------------- .../apache/qpid/test/unit/message/MessageConverterTest.java | 7 ------- 1 file changed, 7 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/qpid-jms-amqp-0-x/blob/ffa282d5/client/src/test/java/org/apache/qpid/test/unit/message/MessageConverterTest.java ---------------------------------------------------------------------- diff --git a/client/src/test/java/org/apache/qpid/test/unit/message/MessageConverterTest.java b/client/src/test/java/org/apache/qpid/test/unit/message/MessageConverterTest.java index 6fc975c..298dcae 100644 --- a/client/src/test/java/org/apache/qpid/test/unit/message/MessageConverterTest.java +++ b/client/src/test/java/org/apache/qpid/test/unit/message/MessageConverterTest.java @@ -97,13 +97,6 @@ public class MessageConverterTest extends QpidTestCase } - public void testMessageConversion() throws Exception - { - Message newMessage = new NonQpidMessage(); - setMessageProperties(newMessage); - mesagePropertiesTest(testTextMessage, newMessage); - } - private void setMessageProperties(Message message) throws JMSException { message.setJMSCorrelationID(JMS_CORR_ID); --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@qpid.apache.org For additional commands, e-mail: commits-h...@qpid.apache.org
