This is an automated email from the ASF dual-hosted git repository.
chug pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/qpid-dispatch.git
The following commit(s) were added to refs/heads/master by this push:
new fd0d8dd DISPATCH-1786: Fallback dest random failures: defer starting
sender
fd0d8dd is described below
commit fd0d8dd77b5101193fc35d9c459e1bd1b9754034
Author: Chuck Rolke <c...@apache.org>
AuthorDate: Fri Nov 13 15:18:57 2020 -0500
DISPATCH-1786: Fallback dest random failures: defer starting sender
Don't create sender before the fallback receiver has opened.
This fix is not proven to fix intermittent failures.
However, it removes a case where fallback would not work.
---
tests/system_tests_fallback_dest.py | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/tests/system_tests_fallback_dest.py
b/tests/system_tests_fallback_dest.py
index c70c226..d55d2ef 100644
--- a/tests/system_tests_fallback_dest.py
+++ b/tests/system_tests_fallback_dest.py
@@ -583,6 +583,8 @@ class SwitchoverTest(MessagingHandler):
self.sender_conn = None
self.primary_conn = None
self.fallback_conn = None
+ self.primary_open = False
+ self.fallback_open = False
self.error = None
self.n_tx = 0
self.n_rx = 0
@@ -615,7 +617,14 @@ class SwitchoverTest(MessagingHandler):
self.fallback_receiver.source.capabilities.put_object(symbol("qd.fallback"))
def on_link_opened(self, event):
+ receiver_event = False
if event.receiver == self.primary_receiver:
+ self.primary_open = True
+ receiver_event = True
+ if event.receiver == self.fallback_receiver:
+ self.fallback_open = True
+ receiver_event = True
+ if receiver_event and self.primary_open and self.fallback_open:
self.sender = event.container.create_sender(self.sender_conn,
self.addr, name=(self.addr + "_sender"))
def on_link_closed(self, event):
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@qpid.apache.org
For additional commands, e-mail: commits-h...@qpid.apache.org
