This is an automated email from the ASF dual-hosted git repository.

cliffjansen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/qpid-proton.git


The following commit(s) were added to refs/heads/master by this push:
     new 7735f1b  PROTON-2172: proactor fdlimit test. Should work after 
PROTON-1496.
7735f1b is described below

commit 7735f1b7b39b36f5fd292410385e6a5a9c4fb68a
Author: Cliff Jansen <cliffjan...@apache.org>
AuthorDate: Mon Nov 23 10:27:47 2020 -0800

    PROTON-2172: proactor fdlimit test. Should work after PROTON-1496.
---
 c/tests/fdlimit.py | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/c/tests/fdlimit.py b/c/tests/fdlimit.py
index 6848c68..2fe2e71 100644
--- a/c/tests/fdlimit.py
+++ b/c/tests/fdlimit.py
@@ -51,8 +51,7 @@ class FdLimitTest(unittest.TestCase):
         if cls.devnull:
             cls.devnull.close()
 
-    # @unittest.skipUnless(prlimit_available, "prlimit not available")
-    @unittest.skip("temporarily disabled (epoll fix pending)")
+    @unittest.skipUnless(prlimit_available, "prlimit not available")
     def test_fd_limit_broker(self):
         """Check behaviour when running out of file descriptors on accept"""
         # Not too many FDs but not too few either, some are used for system 
purposes.
@@ -64,9 +63,11 @@ class FdLimitTest(unittest.TestCase):
             # NOTE: broker does not log a file descriptor related error at any 
point in the test, only
             #  PN_TRANSPORT_CLOSED: amqp:connection:framing-error: connection 
aborted
             #  PN_TRANSPORT_CLOSED: proton:io: Connection reset by peer - 
disconnected :5672 (connection aborted)
-            for i in range(fdlimit + 1):
+            for i in range(fdlimit):
                 receiver = test_subprocess.Popen(["receive", "", b.port, 
str(i)], stdout=self.devnull)
                 receivers.append(receiver)
+            # Allow these subprocesses time to establish ahead of the upcoming 
test sender.
+            time.sleep(1)
 
             # All FDs are now in use, send attempt will (with present 
implementation) hang
             with test_subprocess.Popen(["send", "", b.port, "x"],


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@qpid.apache.org
For additional commands, e-mail: commits-h...@qpid.apache.org

Reply via email to