[qpid-dispatch] branch main updated: DISPATCH-2204 Fix "dictionary changed size during iteration" errors (#1305)

[jdanek]

This is an automated email from the ASF dual-hosted git repository.

jdanek pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/qpid-dispatch.git


The following commit(s) were added to refs/heads/main by this push:
     new e730673  DISPATCH-2204 Fix "dictionary changed size during iteration" 
errors (#1305)
e730673 is described below

commit e730673d4ab3f71720a9e4295b06239950bc9456
Author: Jiri Daněk <jda...@redhat.com>
AuthorDate: Tue Jul 20 16:27:10 2021 +0200

    DISPATCH-2204 Fix "dictionary changed size during iteration" errors (#1305)
---
 python/qpid_dispatch_internal/router/hello.py | 2 +-
 python/qpid_dispatch_internal/router/node.py  | 2 +-
 src/adaptors/tcp_adaptor.c                    | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/python/qpid_dispatch_internal/router/hello.py 
b/python/qpid_dispatch_internal/router/hello.py
index 484cedd..51d7a24 100644
--- a/python/qpid_dispatch_internal/router/hello.py
+++ b/python/qpid_dispatch_internal/router/hello.py
@@ -61,7 +61,7 @@ class HelloProtocol(object):
         Expire local records of received hellos.  This is not involved in the
         expiration of neighbor status for routers.
         """
-        for key, last_seen in self.hellos.items():
+        for key, last_seen in list(self.hellos.items()):
             if now - last_seen > self.hello_max_age:
                 self.hellos.pop(key)
                 self.container.log_hello(LOG_TRACE, "HELLO peer expired: %s" % 
key)
diff --git a/python/qpid_dispatch_internal/router/node.py 
b/python/qpid_dispatch_internal/router/node.py
index f87a6ea..30d5f8e 100644
--- a/python/qpid_dispatch_internal/router/node.py
+++ b/python/qpid_dispatch_internal/router/node.py
@@ -70,7 +70,7 @@ class NodeTracker(object):
         """
         Run through the list of routers and check for expired conditions
         """
-        for node_id, node in self.nodes.items():
+        for node_id, node in list(self.nodes.items()):
             ##
             # If the node is a neighbor, check the neighbor refresh time to see
             # if we've waited too long for a refresh.  If so, disconnect the 
link
diff --git a/src/adaptors/tcp_adaptor.c b/src/adaptors/tcp_adaptor.c
index 1de86aa..3e71611 100644
--- a/src/adaptors/tcp_adaptor.c
+++ b/src/adaptors/tcp_adaptor.c
@@ -1340,7 +1340,7 @@ void qd_dispatch_delete_tcp_connector(qd_dispatch_t *qd, 
void *impl)
     qd_tcp_connector_t *ct = (qd_tcp_connector_t*) impl;
     if (ct) {
         //need to close the pseudo-connection used for dispatching
-        //deliveries out to live connnections:
+        //deliveries out to live connections:
         qd_log(tcp_adaptor->log_source, QD_LOG_INFO,
                "Deleted TcpConnector for %s, %s:%s",
                ct->config->address, ct->config->host, ct->config->port);

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@qpid.apache.org
For additional commands, e-mail: commits-h...@qpid.apache.org