This is an automated email from the ASF dual-hosted git repository.

astitcher pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/qpid-proton.git

commit 0f93611a52dbd4774abd0c686859281980dd5676
Author: Andrew Stitcher <astitc...@apache.org>
AuthorDate: Tue Apr 4 16:15:14 2023 -0400

    PROTON-2704: Make sure example tester terminates server
    
    Previously if the client didn't produce the expected result an exception
    was thrown which bypassed terminsting the server which would make the
    test hang.
---
 python/examples/test_examples.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/python/examples/test_examples.py b/python/examples/test_examples.py
index 5c566b100..1fdfd67c0 100644
--- a/python/examples/test_examples.py
+++ b/python/examples/test_examples.py
@@ -83,6 +83,7 @@ class ExamplesTest(unittest.TestCase):
             if sleep:
                 time.sleep(sleep)
             with run(client) as c:
+                s.terminate()
                 actual = [l.strip() for l in c.stdout]
                 inputs = ["Twas brillig, and the slithy toves",
                           "Did gire and gymble in the wabe.",
@@ -90,7 +91,6 @@ class ExamplesTest(unittest.TestCase):
                           "And the mome raths outgrabe."]
                 expected = ["%s => %s" % (l, l.upper()) for l in inputs]
                 self.assertEqual(actual, expected)
-            s.terminate()
 
     def test_sync_client_server(self):
         self.test_client_server(client=['sync_client.py'])


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@qpid.apache.org
For additional commands, e-mail: commits-h...@qpid.apache.org

Reply via email to