[qpid-python] 03/04: QPID-8170: fix exception string from qpid_tests.broker_1_0 tests running against amqp0-10 broker

[jdanek]

This is an automated email from the ASF dual-hosted git repository.

jdanek pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/qpid-python.git

commit 4123547a7514ffd6d650280d5ae8831613e635d4
Author: Jiri Daněk <jda...@redhat.com>
AuthorDate: Sun Apr 9 22:28:50 2023 +0200

    QPID-8170: fix exception string from qpid_tests.broker_1_0 tests running 
against amqp0-10 broker
    
    Issue was originally introduced in QPID-5836.
    
    ```
    qpid_tests.broker_1_0.general.GeneralTests.test_anonymous_relay ... fail
    Error during setup:  Traceback (most recent call last):
        File "qpid-python-test", line 347, in run
          phase()
        File 
"/home/jdanek/repos/qpid/qpid-python/qpid/tests/messaging/__init__.py", line 
49, in setup
          self.conn = self.setup_connection()
        File 
"/home/jdanek/repos/qpid/qpid-python/qpid/tests/messaging/__init__.py", line 
207, in setup_connection
          return self.create_connection()
        File 
"/home/jdanek/repos/qpid/qpid-python/qpid/tests/messaging/__init__.py", line 
204, in create_connection
          return Connection.establish(self.broker, **opts)
        File "/home/jdanek/repos/qpid/qpid-python/qpid/messaging/endpoints.py", 
line 111, in establish
          conn = Connection(url, **options)
        File "/home/jdanek/repos/qpid/qpid-python/qpid/messaging/endpoints.py", 
line 209, in __init__
          raise ConnectionError("Connection option 'protocol' value '" + value 
+ "' unsupported (must be amqp0-10)")
      TypeError: cannot concatenate 'str' and 'bool' objects
    ```
---
 qpid/messaging/endpoints.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qpid/messaging/endpoints.py b/qpid/messaging/endpoints.py
index 885b95a..3ac9d8f 100644
--- a/qpid/messaging/endpoints.py
+++ b/qpid/messaging/endpoints.py
@@ -206,7 +206,7 @@ class Connection(Endpoint):
       self.port = default(url.port, default(self.port, AMQP_PORT))
 
     if self.protocol and self.protocol != "amqp0-10":
-        raise ConnectionError("Connection option 'protocol' value '" + value + 
"' unsupported (must be amqp0-10)")
+        raise ConnectionError("Connection option 'protocol' value '" + 
self.protocol + "' unsupported (must be amqp0-10)")
       
     self.username = default(url.user, self.username)
     self.password = default(url.password, self.password)


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@qpid.apache.org
For additional commands, e-mail: commits-h...@qpid.apache.org