This is an automated email from the ASF dual-hosted git repository. asf-gitbox-commits pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/qpid-proton.git
commit 092232d2ac127751f343761b6695225adeb94c84 Author: Andrew Stitcher <[email protected]> AuthorDate: Mon Oct 5 20:10:11 2026 -0400 PROTON-2981: Really change Windows minimum to Win7+ We document the minimum version of Visual Studio is 2019: This implies a minimum Windows version of 7, API version 6.1. --- CMakeLists.txt | 5 +++++ c/src/proactor/netaddr-internal.c | 6 ------ c/src/reactor/io/windows/io.c | 6 ------ c/src/reactor/io/windows/iocp.c | 6 ------ c/src/reactor/io/windows/selector.c | 6 ------ c/src/reactor/io/windows/write_pipeline.c | 6 ------ c/src/ssl/openssl.c | 6 ------ c/src/tls/openssl.c | 6 ------ 8 files changed, 5 insertions(+), 42 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 64cdfa089..1932bdeb6 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -150,6 +150,11 @@ if (CMAKE_SYSTEM_NAME STREQUAL "Darwin") set (NOENABLE_WARNING_ERROR ON) endif () +if (WIN32 AND NOT CYGWIN) + # Minimum supported Windows version is Windows 7 (0x0601) per Visual Studio 2019 requirement + add_compile_definitions(_WIN32_WINNT=0x0601) +endif () + # Benchmarks should be disabled by default set (NOENABLE_BENCHMARKS ON) diff --git a/c/src/proactor/netaddr-internal.c b/c/src/proactor/netaddr-internal.c index 8abdab24e..83fb4ba3c 100644 --- a/c/src/proactor/netaddr-internal.c +++ b/c/src/proactor/netaddr-internal.c @@ -18,12 +18,6 @@ */ #ifdef _WIN32 -#ifndef _WIN32_WINNT -#define _WIN32_WINNT 0x0501 -#endif -#if _WIN32_WINNT < 0x0501 -#error "Proton requires Windows API support for XP or later." -#endif #include <winsock2.h> #include <Ws2tcpip.h> #else diff --git a/c/src/reactor/io/windows/io.c b/c/src/reactor/io/windows/io.c index 79b4ed749..344dbac20 100644 --- a/c/src/reactor/io/windows/io.c +++ b/c/src/reactor/io/windows/io.c @@ -20,12 +20,6 @@ */ #define FD_SETSIZE 2048 -#ifndef _WIN32_WINNT -#define _WIN32_WINNT 0x0501 -#endif -#if _WIN32_WINNT < 0x0501 -#error "Proton requires Windows API support for XP or later." -#endif #include <winsock2.h> #include <mswsock.h> #include <Ws2tcpip.h> diff --git a/c/src/reactor/io/windows/iocp.c b/c/src/reactor/io/windows/iocp.c index 95e1b9847..69d853c01 100644 --- a/c/src/reactor/io/windows/iocp.c +++ b/c/src/reactor/io/windows/iocp.c @@ -19,12 +19,6 @@ * */ -#ifndef _WIN32_WINNT -#define _WIN32_WINNT 0x0501 -#endif -#if _WIN32_WINNT < 0x0501 -#error "Proton requires Windows API support for XP or later." -#endif #include <winsock2.h> #include <mswsock.h> #include <Ws2tcpip.h> diff --git a/c/src/reactor/io/windows/selector.c b/c/src/reactor/io/windows/selector.c index b1a1cc337..969deff45 100644 --- a/c/src/reactor/io/windows/selector.c +++ b/c/src/reactor/io/windows/selector.c @@ -19,12 +19,6 @@ * */ -#ifndef _WIN32_WINNT -#define _WIN32_WINNT 0x0501 -#endif -#if _WIN32_WINNT < 0x0501 -#error "Proton requires Windows API support for XP or later." -#endif #include <winsock2.h> #include <Ws2tcpip.h> diff --git a/c/src/reactor/io/windows/write_pipeline.c b/c/src/reactor/io/windows/write_pipeline.c index 2a7ecf88c..12fa8acf6 100644 --- a/c/src/reactor/io/windows/write_pipeline.c +++ b/c/src/reactor/io/windows/write_pipeline.c @@ -27,12 +27,6 @@ * number of connections, etc. */ -#ifndef _WIN32_WINNT -#define _WIN32_WINNT 0x0501 -#endif -#if _WIN32_WINNT < 0x0501 -#error "Proton requires Windows API support for XP or later." -#endif #include <winsock2.h> #include <Ws2tcpip.h> diff --git a/c/src/ssl/openssl.c b/c/src/ssl/openssl.c index baabec0f1..e4f80e2f4 100644 --- a/c/src/ssl/openssl.c +++ b/c/src/ssl/openssl.c @@ -34,12 +34,6 @@ // winsock.h #ifdef _MSC_VER -#ifndef _WIN32_WINNT -#define _WIN32_WINNT 0x0501 -#endif -#if _WIN32_WINNT < 0x0501 -#error "Proton requires Windows API support for XP or later." -#endif #include <winsock2.h> #include <mswsock.h> #include <Ws2tcpip.h> diff --git a/c/src/tls/openssl.c b/c/src/tls/openssl.c index 8a3d07c21..f26a5f3e0 100644 --- a/c/src/tls/openssl.c +++ b/c/src/tls/openssl.c @@ -38,12 +38,6 @@ // winsock.h #ifdef _MSC_VER -#ifndef _WIN32_WINNT -#define _WIN32_WINNT 0x0501 -#endif -#if _WIN32_WINNT < 0x0501 -#error "Proton requires Windows API support for XP or later." -#endif #include <winsock2.h> #include <mswsock.h> #include <Ws2tcpip.h> --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
