RANGER-2177: Handle validations for duplicate configuration item during service create/edit
Signed-off-by: zhangqiang2 <zhangqia...@zte.com.cn> Project: http://git-wip-us.apache.org/repos/asf/ranger/repo Commit: http://git-wip-us.apache.org/repos/asf/ranger/commit/77c6e047 Tree: http://git-wip-us.apache.org/repos/asf/ranger/tree/77c6e047 Diff: http://git-wip-us.apache.org/repos/asf/ranger/diff/77c6e047 Branch: refs/heads/ranger-1.1 Commit: 77c6e0476170efea73ea086bf04978b0e4b99334 Parents: 4f7e4cb Author: xingpeng1 <xing.pe...@zte.com.cn> Authored: Fri Aug 10 11:08:19 2018 +0800 Committer: Mehul Parikh <me...@apache.org> Committed: Tue Sep 4 11:40:30 2018 +0530 ---------------------------------------------------------------------- .../src/main/webapp/scripts/views/service/ServiceForm.js | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/ranger/blob/77c6e047/security-admin/src/main/webapp/scripts/views/service/ServiceForm.js ---------------------------------------------------------------------- diff --git a/security-admin/src/main/webapp/scripts/views/service/ServiceForm.js b/security-admin/src/main/webapp/scripts/views/service/ServiceForm.js index 726fb5f..b7215f2 100644 --- a/security-admin/src/main/webapp/scripts/views/service/ServiceForm.js +++ b/security-admin/src/main/webapp/scripts/views/service/ServiceForm.js @@ -145,19 +145,22 @@ define(function(require){ formValidation : function(){ var valid = true; var config = {}; - this.extraConfigColl.each(function(obj){ + + for (var i = 0; i < this.extraConfigColl.length; i++) { + var obj = this.extraConfigColl.at(i); if(!_.isEmpty(obj.attributes)) { if (!_.isUndefined(config[obj.get('name')])) { XAUtil.alertPopup({ msg : localization.tt('msg.duplicateNewConfigValidationMsg') }); valid = false; - return; + break; } else { config[obj.get('name')] = obj.get('value'); } } - }); + } + return valid; },
