Repository: incubator-ratis Updated Branches: refs/heads/master 091d2fcb9 -> 6d0d114ff
RATIS-129. Compile protobuf and shade if the shaded source directory is missing. Project: http://git-wip-us.apache.org/repos/asf/incubator-ratis/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-ratis/commit/6d0d114f Tree: http://git-wip-us.apache.org/repos/asf/incubator-ratis/tree/6d0d114f Diff: http://git-wip-us.apache.org/repos/asf/incubator-ratis/diff/6d0d114f Branch: refs/heads/master Commit: 6d0d114ff4a8709dd568b5227dbc6c78cbcd8d1f Parents: 091d2fc Author: Tsz-Wo Nicholas Sze <[email protected]> Authored: Fri Nov 3 16:54:28 2017 -0700 Committer: Tsz-Wo Nicholas Sze <[email protected]> Committed: Fri Nov 3 16:54:28 2017 -0700 ---------------------------------------------------------------------- BUILDING.md | 7 ++----- ratis-hadoop-shaded/pom.xml | 6 +++--- ratis-proto-shaded/pom.xml | 6 +++--- 3 files changed, 8 insertions(+), 11 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-ratis/blob/6d0d114f/BUILDING.md ---------------------------------------------------------------------- diff --git a/BUILDING.md b/BUILDING.md index 0f3e682..d1569bc 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -42,11 +42,8 @@ ratis-hadoop-shaded/src/main/java/ ``` They are not checked-in to git though. -By default protobuf compilation and shading are triggered at every build. To make more faster the -additional builds, you can turn them off: -``` -$ mvn package -DskipTests -DskipShade -``` +Protobuf compilation and shading are triggered +when the corresponding shaded source directory is missing. During the clean lifecycle all the shaded classes are also deleted. You can clean the compiled files but keep the shaded classes with the following command: http://git-wip-us.apache.org/repos/asf/incubator-ratis/blob/6d0d114f/ratis-hadoop-shaded/pom.xml ---------------------------------------------------------------------- diff --git a/ratis-hadoop-shaded/pom.xml b/ratis-hadoop-shaded/pom.xml index dd0ad2a..1145942 100644 --- a/ratis-hadoop-shaded/pom.xml +++ b/ratis-hadoop-shaded/pom.xml @@ -167,9 +167,9 @@ Shade and drop the generated java files under src/main/java. --> <activation> - <property> - <name>!skipShade</name> - </property> + <file> + <missing>${shaded.sources.dir}</missing> + </file> </activation> <properties> <profile.id>compile-protobuf</profile.id> http://git-wip-us.apache.org/repos/asf/incubator-ratis/blob/6d0d114f/ratis-proto-shaded/pom.xml ---------------------------------------------------------------------- diff --git a/ratis-proto-shaded/pom.xml b/ratis-proto-shaded/pom.xml index ef22f33..4ec4713 100644 --- a/ratis-proto-shaded/pom.xml +++ b/ratis-proto-shaded/pom.xml @@ -466,9 +466,9 @@ files or update the protobuf version. --> <activation> - <property> - <name>!skipShade</name> - </property> + <file> + <missing>${shaded.sources.dir}</missing> + </file> </activation> <properties> <profile.id>compile-protobuf</profile.id>
