This is an automated email from the ASF dual-hosted git repository.

szetszwo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-ratis-thirdparty.git


The following commit(s) were added to refs/heads/master by this push:
     new 9dae436  RATIS-340. org.apache.hadoop.ipc.protobuf is shaded to 
org.apache.ratis.shaded.*.
9dae436 is described below

commit 9dae436d0e49cf074badc5613aa7d849b92561ca
Author: Tsz Wo Nicholas Sze <[email protected]>
AuthorDate: Sat Oct 6 07:59:00 2018 +0800

    RATIS-340. org.apache.hadoop.ipc.protobuf is shaded to 
org.apache.ratis.shaded.*.
---
 README.md          | 25 +++++++++++++++++++++++++
 hadoop/pom.xml     |  5 ++---
 thirdparty/pom.xml |  1 -
 3 files changed, 27 insertions(+), 4 deletions(-)

diff --git a/README.md b/README.md
new file mode 100644
index 0000000..3f1bcf5
--- /dev/null
+++ b/README.md
@@ -0,0 +1,25 @@
+<!--
+  Licensed under the Apache License, Version 2.0 (the "License");
+  you may not use this file except in compliance with the License.
+  You may obtain a copy of the License at
+
+   http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License. See accompanying LICENSE file.
+-->
+
+# Apache Ratis Thirdparty
+
+All bundled thirdparty dependencies are centralized in the *ratis-thirdparty* 
module
+and the *ratis-thirdparty-hadoop* module.
+These modules are located in a separated repository 
(https://github.com/apache/incubator-ratis-thirdparty)
+but not attached to the core Apache Ratis repository 
(https://git-wip-us.apache.org/repos/asf?p=incubator-ratis.git)
+as they only need to change when one of these dependencies are changed.
+All dependencies included in ratis-thirdparty/ratis-thirdparty-hadoop
+must be relocated to a different package to ensure no downstream classpath 
pollution.
+
+See also: https://github.com/apache/incubator-ratis/blob/master/BUILDING.md
\ No newline at end of file
diff --git a/hadoop/pom.xml b/hadoop/pom.xml
index bfc5fcd..4b30f62 100644
--- a/hadoop/pom.xml
+++ b/hadoop/pom.xml
@@ -20,7 +20,6 @@
     <version>0.1.0-SNAPSHOT</version>
   </parent>
   <artifactId>ratis-thirdparty-hadoop</artifactId>
-  <groupId>org.apache.ratis</groupId>
   <name>Apache Ratis Thirdparty Hadoop</name>
   <packaging>jar</packaging>
   <description>Hadoop dependencies for Apache Ratis</description>
@@ -80,11 +79,11 @@
               <relocations>
                 <relocation>
                   <pattern>com.google.protobuf</pattern>
-                  
<shadedPattern>org.apache.ratis.thirdparty.com.google.protobuf</shadedPattern>
+                  
<shadedPattern>${ratis.thirdparty.shaded.prefix}.com.google.protobuf</shadedPattern>
                 </relocation>
                 <relocation>
                   <pattern>org.apache.hadoop.ipc.protobuf</pattern>
-                  
<shadedPattern>org.apache.ratis.shaded.org.apache.hadoop.ipc.protobuf</shadedPattern>
+                  
<shadedPattern>${ratis.thirdparty.shaded.prefix}.org.apache.hadoop.ipc.protobuf</shadedPattern>
                 </relocation>
               </relocations>
 
diff --git a/thirdparty/pom.xml b/thirdparty/pom.xml
index ef0acb4..da792c0 100644
--- a/thirdparty/pom.xml
+++ b/thirdparty/pom.xml
@@ -20,7 +20,6 @@
     <version>0.1.0-SNAPSHOT</version>
   </parent>
   <artifactId>ratis-thirdparty</artifactId>
-  <groupId>org.apache.ratis</groupId>
   <name>Apache Ratis Thirdparty</name>
   <packaging>jar</packaging>
   <description>Thirdparty dependencies for Apache Ratis</description>

Reply via email to