Repository: incubator-reef Updated Branches: refs/heads/master a72a40f8d -> 7396f314e
[REEF-270] Missing @Inject annotation in NetworkService, GroupCommDriverImpl The @Inject annotations in deprecated constructors in NetworkService and GroupCommDriverImpl were removed, and which caused a Tang exception when executing BroadcastREEF example. This pull request simply brings back @Inject annotations to address the issue. JIRA: [REEF-270] https://issues.apache.org/jira/browse/REEF-270 Pull Request: This closes #156 Project: http://git-wip-us.apache.org/repos/asf/incubator-reef/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-reef/commit/7396f314 Tree: http://git-wip-us.apache.org/repos/asf/incubator-reef/tree/7396f314 Diff: http://git-wip-us.apache.org/repos/asf/incubator-reef/diff/7396f314 Branch: refs/heads/master Commit: 7396f314e72a10d88502797afd66295cba913bec Parents: a72a40f Author: Kim_Geon_Woo <[email protected]> Authored: Tue Apr 21 18:28:02 2015 +0900 Committer: taegeonum <[email protected]> Committed: Tue Apr 21 22:10:20 2015 +0900 ---------------------------------------------------------------------- .../reef/io/network/group/impl/driver/GroupCommDriverImpl.java | 1 + .../main/java/org/apache/reef/io/network/impl/NetworkService.java | 1 + 2 files changed, 2 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/7396f314/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/driver/GroupCommDriverImpl.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/driver/GroupCommDriverImpl.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/driver/GroupCommDriverImpl.java index 8965553..adcb1e5 100644 --- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/driver/GroupCommDriverImpl.java +++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/driver/GroupCommDriverImpl.java @@ -108,6 +108,7 @@ public class GroupCommDriverImpl implements GroupCommServiceDriver { * @deprecated Have an instance injected instead. */ @Deprecated + @Inject public GroupCommDriverImpl(final ConfigurationSerializer confSerializer, @Parameter(DriverIdentifier.class) final String driverId, @Parameter(TreeTopologyFanOut.class) final int fanOut) { http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/7396f314/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkService.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkService.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkService.java index 6deb7cb..269fbf3 100644 --- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkService.java +++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkService.java @@ -125,6 +125,7 @@ public final class NetworkService<T> implements Stage, ConnectionFactory<T> { * @deprecated have an instance injected instead. */ @Deprecated + @Inject public NetworkService( final @Parameter(NetworkServiceParameters.NetworkServiceIdentifierFactory.class) IdentifierFactory factory, final @Parameter(NetworkServiceParameters.NetworkServicePort.class) int nsPort,
