Repository: incubator-reef
Updated Branches:
  refs/heads/master 75c235823 -> b63324137


[REEF-343] Remove `More than 7 parameters` Checkstyle check for constructors

This addressed the issue by
  * Configuring ParameterNumber module to check only methods

JIRA: [REEF-343](https://issues.apache.org/jira/browse/REEF-343)

This Closes #208

Author:    Mariia Mykhailova <[email protected]>


Project: http://git-wip-us.apache.org/repos/asf/incubator-reef/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-reef/commit/b6332413
Tree: http://git-wip-us.apache.org/repos/asf/incubator-reef/tree/b6332413
Diff: http://git-wip-us.apache.org/repos/asf/incubator-reef/diff/b6332413

Branch: refs/heads/master
Commit: b633241373b1d4de5ed51a81034eee52dfc820ba
Parents: 75c2358
Author: Mariia Mykhailova <[email protected]>
Authored: Mon Jun 8 10:52:54 2015 -0700
Committer: Julia Wang <[email protected]>
Committed: Mon Jun 8 11:22:47 2015 -0700

----------------------------------------------------------------------
 lang/java/reef-common/src/main/resources/checkstyle.xml | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b6332413/lang/java/reef-common/src/main/resources/checkstyle.xml
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/resources/checkstyle.xml 
b/lang/java/reef-common/src/main/resources/checkstyle.xml
index 7129517..b1af586 100644
--- a/lang/java/reef-common/src/main/resources/checkstyle.xml
+++ b/lang/java/reef-common/src/main/resources/checkstyle.xml
@@ -121,8 +121,10 @@
             <property name="max" value="120"/>
         </module>
         <module name="MethodLength"/>
-        <module name="ParameterNumber"/>
-
+        <module name="ParameterNumber">
+            <property name="max" value="7"/>
+            <property name="tokens" value="METHOD_DEF"/>
+        </module>
 
         <!-- Checks for whitespace                               -->
         <!-- See http://checkstyle.sf.net/config_whitespace.html -->

Reply via email to