[REEF-388]: Fix violations of RedundantModifier checkstyle This addressed the issue by * removing redundant modifiers as detected by the check
JIRA: [REEF-388](https://issues.apache.org/jira/browse/REEF-388) Pull Request: This closes #229 Project: http://git-wip-us.apache.org/repos/asf/incubator-reef/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-reef/commit/660ee805 Tree: http://git-wip-us.apache.org/repos/asf/incubator-reef/tree/660ee805 Diff: http://git-wip-us.apache.org/repos/asf/incubator-reef/diff/660ee805 Branch: refs/heads/master Commit: 660ee805dae12dcc88fac82851243e2c8d81da52 Parents: 9964d5d Author: Mariia Mykhailova <[email protected]> Authored: Wed Jun 17 17:20:39 2015 -0700 Committer: Markus Weimer <[email protected]> Committed: Thu Jun 18 13:21:53 2015 -0700 ---------------------------------------------------------------------- .../reef/javabridge/HttpServerEventBridge.java | 20 ++++++------ .../reef/javabridge/RunningTaskBridge.java | 4 +-- .../reef/javabridge/generic/JobDriver.java | 2 +- .../io/checkpoint/CheckpointNamingService.java | 2 +- .../org/apache/reef/client/CompletedJob.java | 2 +- .../java/org/apache/reef/client/JobMessage.java | 4 +-- .../org/apache/reef/client/LauncherStatus.java | 10 +++--- .../main/java/org/apache/reef/client/REEF.java | 4 +-- .../java/org/apache/reef/client/RunningJob.java | 8 ++--- .../reef/driver/ContextAndTaskSubmittable.java | 10 +++--- .../apache/reef/driver/ContextSubmittable.java | 4 +-- .../reef/driver/FlexiblePreemptionEvent.java | 2 +- .../org/apache/reef/driver/TaskSubmittable.java | 2 +- .../reef/driver/catalog/NodeDescriptor.java | 4 +-- .../reef/driver/catalog/RackDescriptor.java | 2 +- .../reef/driver/catalog/ResourceCatalog.java | 8 ++--- .../reef/driver/client/JobMessageObserver.java | 2 +- .../reef/driver/context/ActiveContext.java | 10 +++--- .../reef/driver/context/ClosedContext.java | 2 +- .../reef/driver/context/ContextMessage.java | 6 ++-- .../reef/driver/evaluator/EvaluatorRequest.java | 2 +- .../driver/evaluator/EvaluatorRequestor.java | 2 +- .../reef/driver/evaluator/FailedEvaluator.java | 6 ++-- .../apache/reef/driver/task/CompletedTask.java | 4 +-- .../apache/reef/driver/task/RunningTask.java | 12 ++++---- .../apache/reef/driver/task/SuspendedTask.java | 2 +- .../context/ContextMessageHandler.java | 2 +- .../evaluator/context/ContextMessageSource.java | 2 +- .../evaluator/context/events/ContextStart.java | 2 +- .../evaluator/context/events/ContextStop.java | 2 +- .../java/org/apache/reef/io/Accumulable.java | 2 +- .../java/org/apache/reef/io/ExternalMap.java | 12 ++++---- .../main/java/org/apache/reef/io/Message.java | 2 +- .../src/main/java/org/apache/reef/io/Spool.java | 4 +-- .../org/apache/reef/io/TempFileCreator.java | 6 ++-- .../org/apache/reef/io/naming/Identifiable.java | 2 +- .../apache/reef/io/naming/NameAssignment.java | 4 +-- .../org/apache/reef/io/naming/NamingLookup.java | 2 +- .../apache/reef/io/naming/NamingRegistry.java | 4 +-- .../org/apache/reef/io/serialization/Codec.java | 4 +-- .../reef/io/serialization/Deserializer.java | 2 +- .../reef/io/serialization/Serializer.java | 2 +- .../common/client/JobSubmissionHelper.java | 2 +- .../common/client/REEFImplementation.java | 2 +- .../reef/runtime/common/client/RunningJobs.java | 6 ++-- .../common/client/api/JobSubmissionHandler.java | 2 +- .../driver/catalog/RackDescriptorImpl.java | 6 ++-- .../driver/catalog/ResourceCatalogImpl.java | 4 +-- .../common/driver/context/ContextFactory.java | 2 +- .../driver/context/ContextMessageImpl.java | 2 +- .../common/driver/context/EvaluatorContext.java | 2 +- .../evaluator/AllocatedEvaluatorImpl.java | 6 ++-- .../EvaluatorHeartBeatSanityChecker.java | 2 +- .../evaluator/EvaluatorManagerFactory.java | 6 ++-- .../common/driver/task/TaskMessageImpl.java | 2 +- .../common/evaluator/EvaluatorRuntime.java | 8 ++--- .../common/evaluator/HeartBeatManager.java | 2 +- .../evaluator/context/ContextLifeCycle.java | 10 +++--- .../evaluator/context/ContextRuntime.java | 4 +-- .../evaluator/context/RootContextLauncher.java | 4 +-- .../common/evaluator/task/TaskRuntime.java | 2 +- .../common/evaluator/task/TaskStatus.java | 4 +-- .../common/launch/LaunchCommandBuilder.java | 14 ++++----- .../launch/REEFUncaughtExceptionHandler.java | 2 +- .../runtime/common/utils/ExceptionCodec.java | 6 ++-- .../main/java/org/apache/reef/task/Task.java | 2 +- .../org/apache/reef/task/TaskMessageSource.java | 2 +- .../org/apache/reef/task/events/CloseEvent.java | 2 +- .../apache/reef/task/events/DriverMessage.java | 2 +- .../apache/reef/task/events/SuspendEvent.java | 2 +- .../org/apache/reef/task/events/TaskStop.java | 2 +- .../main/java/org/apache/reef/util/Builder.java | 2 +- .../java/org/apache/reef/util/CommandUtils.java | 2 +- .../apache/reef/util/logging/LoggingScope.java | 2 +- .../reef/examples/helloCLR/HelloDriver.java | 6 ++-- .../reef/examples/group/bgd/BGDClient.java | 2 +- .../examples/group/bgd/data/parser/Parser.java | 2 +- .../reef/examples/group/utils/math/Vector.java | 12 ++++---- .../apache/reef/examples/hello/HelloTask.java | 2 +- .../reef/examples/scheduler/SchedulerREEF.java | 6 ++-- .../examples/scheduler/SchedulerREEFYarn.java | 2 +- .../reef/examples/suspend/SuspendDriver.java | 6 ++-- .../utils/wake/BlockingEventHandler.java | 2 +- .../reef/io/network/ConnectionFactory.java | 2 +- .../api/driver/CommunicationGroupDriver.java | 10 +++--- .../group/api/driver/TaskNodeStatus.java | 2 +- .../network/group/api/operators/Broadcast.java | 4 +-- .../io/network/group/api/operators/Gather.java | 4 +-- .../io/network/group/api/operators/Reduce.java | 6 ++-- .../io/network/group/api/operators/Scatter.java | 4 +-- .../reef/io/network/naming/NameServer.java | 10 +++--- .../network/naming/serialization/AvroUtils.java | 2 +- .../reef/runtime/hdinsight/cli/HDICLI.java | 2 +- .../runtime/hdinsight/cli/LogFileEntry.java | 2 +- .../client/HDInsightJobSubmissionHandler.java | 2 +- .../client/yarnrest/HDInsightInstance.java | 2 +- .../reef/runtime/local/client/FileSet.java | 12 ++++---- .../local/client/LocalJobSubmissionHandler.java | 4 +-- .../reef/runtime/local/driver/Container.java | 20 ++++++------ .../runtime/local/driver/ContainerManager.java | 10 +++--- .../reef/runtime/local/driver/IDMaker.java | 2 +- .../runtime/local/driver/ProcessContainer.java | 6 ++-- .../runtime/local/driver/ResourceManager.java | 8 ++--- .../runtime/local/driver/ResourceRequest.java | 6 ++-- .../local/driver/ResourceRequestQueue.java | 8 ++--- .../local/process/RunnableProcessObserver.java | 4 +-- .../runtime/mesos/evaluator/REEFExecutor.java | 20 ++++++------ .../yarn/client/YarnJobSubmissionHandler.java | 4 +-- .../yarn/driver/TrackingURLProvider.java | 2 +- .../yarn/driver/YarnContainerManager.java | 20 ++++++------ .../reef/runtime/yarn/util/YarnTypes.java | 2 +- .../java/org/apache/reef/tang/BindLocation.java | 2 +- .../org/apache/reef/tang/ClassHierarchy.java | 6 ++-- .../org/apache/reef/tang/Configuration.java | 16 +++++----- .../apache/reef/tang/ConfigurationBuilder.java | 28 ++++++++--------- .../apache/reef/tang/ExternalConstructor.java | 2 +- .../org/apache/reef/tang/InjectionFuture.java | 6 ++-- .../java/org/apache/reef/tang/Injector.java | 14 ++++----- .../apache/reef/tang/JavaClassHierarchy.java | 8 ++--- .../reef/tang/JavaConfigurationBuilder.java | 20 ++++++------ .../main/java/org/apache/reef/tang/Tang.java | 24 +++++++-------- .../apache/reef/tang/examples/timer/Timer.java | 2 +- .../apache/reef/tang/formats/CommandLine.java | 3 +- .../reef/tang/formats/ConfigurationModule.java | 2 +- .../formats/ConfigurationModuleBuilder.java | 2 +- .../tang/formats/ConfigurationSerializer.java | 24 +++++++-------- .../org/apache/reef/tang/types/ClassNode.java | 20 ++++++------ .../apache/reef/tang/types/ConstructorArg.java | 8 ++--- .../apache/reef/tang/types/ConstructorDef.java | 8 ++--- .../reef/tang/types/NamedParameterNode.java | 14 ++++----- .../java/org/apache/reef/tang/util/Tint.java | 2 +- .../apache/reef/util/logging/DFSHandler.java | 2 +- .../java/org/apache/reef/util/cache/Cache.java | 4 +-- .../java/org/apache/reef/wake/EventHandler.java | 2 +- .../java/org/apache/reef/wake/Identifiable.java | 2 +- .../java/org/apache/reef/wake/Identifier.java | 6 ++-- .../org/apache/reef/wake/IdentifierFactory.java | 2 +- .../reef/wake/examples/p2p/EventSource.java | 2 +- .../reef/wake/examples/p2p/Pull2Push.java | 2 +- .../reef/wake/impl/BlockingEventHandler.java | 2 +- .../wake/impl/BlockingSignalEventHandler.java | 2 +- .../org/apache/reef/wake/metrics/Histogram.java | 8 ++--- .../org/apache/reef/wake/remote/Decoder.java | 2 +- .../wake/remote/RemoteIdentifierFactory.java | 2 +- .../apache/reef/wake/remote/RemoteManager.java | 10 +++--- .../apache/reef/wake/remote/RemoteMessage.java | 4 +-- .../wake/remote/transport/LinkListener.java | 4 +-- .../reef/wake/remote/transport/Transport.java | 10 +++--- .../wake/remote/transport/TransportFactory.java | 32 ++++++++++---------- .../java/org/apache/reef/wake/rx/Observer.java | 6 ++-- .../java/org/apache/reef/wake/time/Clock.java | 8 ++--- .../reef/wake/time/runtime/RuntimeClock.java | 18 +++++------ .../reef/webserver/DriverInfoSerializer.java | 4 +-- .../reef/webserver/EvaluatorListSerializer.java | 4 +-- .../org/apache/reef/webserver/HttpHandler.java | 4 +-- .../org/apache/reef/webserver/HttpServer.java | 8 ++--- .../reef/webserver/HttpTrackingURLProvider.java | 2 +- 157 files changed, 446 insertions(+), 445 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/HttpServerEventBridge.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/HttpServerEventBridge.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/HttpServerEventBridge.java index 045984b..707ebe5 100644 --- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/HttpServerEventBridge.java +++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/HttpServerEventBridge.java @@ -33,43 +33,43 @@ public final class HttpServerEventBridge extends NativeBridge { this.queryRequestData = queryRequestData; } - public final String getQueryString() { + public String getQueryString() { return queryString; } - public final void setQueryString(final String queryStr) { + public void setQueryString(final String queryStr) { this.queryString = queryStr; } - public final String getQueryResult() { + public String getQueryResult() { return queryResult; } - public final void setQueryResult(final String queryResult) { + public void setQueryResult(final String queryResult) { this.queryResult = queryResult; } - public final String getUriSpecification() { + public String getUriSpecification() { return uriSpecification; } - public final void setUriSpecification(final String uriSpecification) { + public void setUriSpecification(final String uriSpecification) { this.uriSpecification = uriSpecification; } - public final byte[] getQueryRequestData() { + public byte[] getQueryRequestData() { return queryRequestData; } - public final void setQueryRequestData(final byte[] queryRequestData) { + public void setQueryRequestData(final byte[] queryRequestData) { this.queryRequestData = queryRequestData; } - public final byte[] getQueryResponseData() { + public byte[] getQueryResponseData() { return queryResponseData; } - public final void setQueryResponseData(final byte[] responseData) { + public void setQueryResponseData(final byte[] responseData) { queryResponseData = responseData; } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/RunningTaskBridge.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/RunningTaskBridge.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/RunningTaskBridge.java index 25b2a78..bff9b08 100644 --- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/RunningTaskBridge.java +++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/RunningTaskBridge.java @@ -33,11 +33,11 @@ public final class RunningTaskBridge extends NativeBridge { this.jactiveContext = factory.getActiveContextBridge(runningTask.getActiveContext()); } - public final String getId() { + public String getId() { return jrunningTask.getId(); } - public final void send(final byte[] message) { + public void send(final byte[] message) { jrunningTask.send(message); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/JobDriver.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/JobDriver.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/JobDriver.java index 4bcc629..315c195 100644 --- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/JobDriver.java +++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/JobDriver.java @@ -628,7 +628,7 @@ public final class JobDriver { */ public final class SuspendedTaskHandler implements EventHandler<SuspendedTask> { @Override - public final void onNext(final SuspendedTask task) { + public void onNext(final SuspendedTask task) { final String message = "Received notification that task [" + task.getId() + "] has been suspended."; LOG.log(Level.INFO, message); try (final LoggingScope ls = loggingScopeFactory.taskSuspended(task.getId())) { http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-checkpoint/src/main/java/org/apache/reef/io/checkpoint/CheckpointNamingService.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-checkpoint/src/main/java/org/apache/reef/io/checkpoint/CheckpointNamingService.java b/lang/java/reef-checkpoint/src/main/java/org/apache/reef/io/checkpoint/CheckpointNamingService.java index 4ce5819..369a8dc 100644 --- a/lang/java/reef-checkpoint/src/main/java/org/apache/reef/io/checkpoint/CheckpointNamingService.java +++ b/lang/java/reef-checkpoint/src/main/java/org/apache/reef/io/checkpoint/CheckpointNamingService.java @@ -28,6 +28,6 @@ public interface CheckpointNamingService { * * @return the checkpoint name */ - public String getNewName(); + String getNewName(); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/client/CompletedJob.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/client/CompletedJob.java b/lang/java/reef-common/src/main/java/org/apache/reef/client/CompletedJob.java index 46af11d..ae13f9b 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/client/CompletedJob.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/client/CompletedJob.java @@ -35,5 +35,5 @@ public interface CompletedJob extends Identifiable { * @return the ID of the completed job. */ @Override - public String getId(); + String getId(); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/client/JobMessage.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/client/JobMessage.java b/lang/java/reef-common/src/main/java/org/apache/reef/client/JobMessage.java index 04f69f6..d31f7d0 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/client/JobMessage.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/client/JobMessage.java @@ -50,7 +50,7 @@ public final class JobMessage implements Message, Identifiable { * @return the message sent by the Job. */ @Override - public final byte[] get() { + public byte[] get() { return this.value; } @@ -60,7 +60,7 @@ public final class JobMessage implements Message, Identifiable { * @return the Identifier of the sending Job. */ @Override - public final String getId() { + public String getId() { return this.id; } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/client/LauncherStatus.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/client/LauncherStatus.java b/lang/java/reef-common/src/main/java/org/apache/reef/client/LauncherStatus.java index 378055b..d983579 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/client/LauncherStatus.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/client/LauncherStatus.java @@ -43,11 +43,11 @@ public final class LauncherStatus { this.error = Optional.ofNullable(ex); } - public static final LauncherStatus FAILED(final Throwable ex) { + public static LauncherStatus FAILED(final Throwable ex) { return new LauncherStatus(State.FAILED, ex); } - public static final LauncherStatus FAILED(final Optional<Throwable> ex) { + public static LauncherStatus FAILED(final Optional<Throwable> ex) { return new LauncherStatus(State.FAILED, ex.orElse(null)); } @@ -72,7 +72,7 @@ public final class LauncherStatus { * * @return True if the job has been completed, false otherwise. */ - public final boolean isDone() { + public boolean isDone() { switch (this.state) { case FAILED: case COMPLETED: @@ -88,7 +88,7 @@ public final class LauncherStatus { * * @return True if the job has been completed successfully, false otherwise. */ - public final boolean isSuccess() { + public boolean isSuccess() { return this.state == State.COMPLETED; } @@ -97,7 +97,7 @@ public final class LauncherStatus { * * @return True if the job is still running, false otherwise. */ - public final boolean isRunning() { + public boolean isRunning() { return this.state == State.RUNNING; } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/client/REEF.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/client/REEF.java b/lang/java/reef-common/src/main/java/org/apache/reef/client/REEF.java index 9e5b03e..c1e891c 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/client/REEF.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/client/REEF.java @@ -41,7 +41,7 @@ public interface REEF extends AutoCloseable { * Close the resourcemanager connection. */ @Override - public void close(); + void close(); /** * Submits the Driver set up in the given Configuration for execution. @@ -51,5 +51,5 @@ public interface REEF extends AutoCloseable { * * @param driverConf The driver configuration: including everything it needs to execute. @see DriverConfiguration */ - public void submit(final Configuration driverConf); + void submit(final Configuration driverConf); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/client/RunningJob.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/client/RunningJob.java b/lang/java/reef-common/src/main/java/org/apache/reef/client/RunningJob.java index 8de6423..a3fe5ba 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/client/RunningJob.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/client/RunningJob.java @@ -38,25 +38,25 @@ public interface RunningJob extends Identifiable, AutoCloseable { * Cancels the running Job. */ @Override - public void close(); + void close(); /** * Cancels the running Job. * * @param message delivered along with cancel request. */ - public void close(final byte[] message); + void close(final byte[] message); /** * @return the ID of the running job. */ @Override - public String getId(); + String getId(); /** * Send a message to the Driver. * * @param message to send to the running driver */ - public void send(final byte[] message); + void send(final byte[] message); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/driver/ContextAndTaskSubmittable.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/driver/ContextAndTaskSubmittable.java b/lang/java/reef-common/src/main/java/org/apache/reef/driver/ContextAndTaskSubmittable.java index 92f0420..d5d816a 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/driver/ContextAndTaskSubmittable.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/driver/ContextAndTaskSubmittable.java @@ -42,10 +42,10 @@ public interface ContextAndTaskSubmittable { * @param contextConfiguration the Configuration of the EvaluatorContext. See ContextConfiguration for details. * @param taskConfiguration the Configuration of the Task. See TaskConfiguration for details. */ - public void submitContextAndTask(final Configuration contextConfiguration, final Configuration taskConfiguration); + void submitContextAndTask(final Configuration contextConfiguration, final Configuration taskConfiguration); /** - * Subkit a Context with Services and a Task. + * Submit a Context with Services and a Task. * <p/> * The semantics of this call are the same as first submitting the context and services and then, on the fired * ActiveContext event to submit the Task. The performance of this will be better, though as it potentially saves @@ -57,8 +57,8 @@ public interface ContextAndTaskSubmittable { * @param serviceConfiguration * @param taskConfiguration */ - public void submitContextAndServiceAndTask(final Configuration contextConfiguration, - final Configuration serviceConfiguration, - final Configuration taskConfiguration); + void submitContextAndServiceAndTask(final Configuration contextConfiguration, + final Configuration serviceConfiguration, + final Configuration taskConfiguration); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/driver/ContextSubmittable.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/driver/ContextSubmittable.java b/lang/java/reef-common/src/main/java/org/apache/reef/driver/ContextSubmittable.java index 80aa82d..dd730e4 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/driver/ContextSubmittable.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/driver/ContextSubmittable.java @@ -36,7 +36,7 @@ public interface ContextSubmittable { * * @param contextConfiguration the Configuration of the EvaluatorContext. See ContextConfiguration for details. */ - public void submitContext(final Configuration contextConfiguration); + void submitContext(final Configuration contextConfiguration); /** * Submit a Context and a Service Configuration. @@ -44,6 +44,6 @@ public interface ContextSubmittable { * @param contextConfiguration the Configuration of the EvaluatorContext. See ContextConfiguration for details. * @param serviceConfiguration the Configuration for the Services. See ServiceConfiguration for details. */ - public void submitContextAndService(final Configuration contextConfiguration, final Configuration serviceConfiguration); + void submitContextAndService(final Configuration contextConfiguration, final Configuration serviceConfiguration); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/driver/FlexiblePreemptionEvent.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/driver/FlexiblePreemptionEvent.java b/lang/java/reef-common/src/main/java/org/apache/reef/driver/FlexiblePreemptionEvent.java index 3ba4f61..b94c852 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/driver/FlexiblePreemptionEvent.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/driver/FlexiblePreemptionEvent.java @@ -43,5 +43,5 @@ public interface FlexiblePreemptionEvent extends PreemptionEvent { /** * @return the set of EvaluatorRequests that the underlying resource manager seeks to satisfy. */ - public Set<EvaluatorRequest> getEvaluatorRequest(); + Set<EvaluatorRequest> getEvaluatorRequest(); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/driver/TaskSubmittable.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/driver/TaskSubmittable.java b/lang/java/reef-common/src/main/java/org/apache/reef/driver/TaskSubmittable.java index 0f91de6..0f826df 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/driver/TaskSubmittable.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/driver/TaskSubmittable.java @@ -36,5 +36,5 @@ public interface TaskSubmittable { * * @param taskConf the Configuration. See TaskConfiguration for details */ - public void submitTask(final Configuration taskConf); + void submitTask(final Configuration taskConf); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/driver/catalog/NodeDescriptor.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/driver/catalog/NodeDescriptor.java b/lang/java/reef-common/src/main/java/org/apache/reef/driver/catalog/NodeDescriptor.java index 7eac713..6edc72a 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/driver/catalog/NodeDescriptor.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/driver/catalog/NodeDescriptor.java @@ -33,10 +33,10 @@ public interface NodeDescriptor extends ResourceCatalog.Descriptor, Identifiable * * @return the inet address of the Evaluator. */ - public InetSocketAddress getInetSocketAddress(); + InetSocketAddress getInetSocketAddress(); /** * @return the rack descriptor that contains this node */ - public RackDescriptor getRackDescriptor(); + RackDescriptor getRackDescriptor(); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/driver/catalog/RackDescriptor.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/driver/catalog/RackDescriptor.java b/lang/java/reef-common/src/main/java/org/apache/reef/driver/catalog/RackDescriptor.java index 03c5558..54ea455 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/driver/catalog/RackDescriptor.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/driver/catalog/RackDescriptor.java @@ -31,5 +31,5 @@ public interface RackDescriptor extends ResourceCatalog.Descriptor { /** * @return the list of nodes in this rack. */ - public List<NodeDescriptor> getNodes(); + List<NodeDescriptor> getNodes(); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/driver/catalog/ResourceCatalog.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/driver/catalog/ResourceCatalog.java b/lang/java/reef-common/src/main/java/org/apache/reef/driver/catalog/ResourceCatalog.java index d02c457..1f0efd7 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/driver/catalog/ResourceCatalog.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/driver/catalog/ResourceCatalog.java @@ -39,14 +39,14 @@ public interface ResourceCatalog { * @return a list of all the static resources available. This is an upper * bound. */ - public Collection<NodeDescriptor> getNodes(); + Collection<NodeDescriptor> getNodes(); /** * The global list of racks. * * @return list of all rack descriptors */ - public Collection<RackDescriptor> getRacks(); + Collection<RackDescriptor> getRacks(); /** * Get the node descriptor with the given identifier. @@ -54,11 +54,11 @@ public interface ResourceCatalog { * @param id of the node. * @return the node descriptor assigned to the identifier. */ - public NodeDescriptor getNode(String nodeId); + NodeDescriptor getNode(String nodeId); public interface Descriptor { - public String getName(); + String getName(); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/driver/client/JobMessageObserver.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/driver/client/JobMessageObserver.java b/lang/java/reef-common/src/main/java/org/apache/reef/driver/client/JobMessageObserver.java index 8ff75a8..66712a3 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/driver/client/JobMessageObserver.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/driver/client/JobMessageObserver.java @@ -39,6 +39,6 @@ public interface JobMessageObserver { * * @param message a message to be sent to the client */ - public void sendMessageToClient(final byte[] message); + void sendMessageToClient(final byte[] message); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/driver/context/ActiveContext.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/driver/context/ActiveContext.java b/lang/java/reef-common/src/main/java/org/apache/reef/driver/context/ActiveContext.java index feaf6e4..1279c23 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/driver/context/ActiveContext.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/driver/context/ActiveContext.java @@ -49,16 +49,16 @@ import org.apache.reef.tang.Configuration; public interface ActiveContext extends Identifiable, AutoCloseable, ContextBase, TaskSubmittable, ContextSubmittable { @Override - public void close(); + void close(); @Override - public void submitTask(final Configuration taskConf); + void submitTask(final Configuration taskConf); @Override - public void submitContext(final Configuration contextConfiguration); + void submitContext(final Configuration contextConfiguration); @Override - public void submitContextAndService(final Configuration contextConfiguration, final Configuration serviceConfiguration); + void submitContextAndService(final Configuration contextConfiguration, final Configuration serviceConfiguration); /** * Send the active context the message, which will be delivered to all registered @@ -66,6 +66,6 @@ public interface ActiveContext extends Identifiable, AutoCloseable, ContextBase, * * @param message */ - public void sendMessage(final byte[] message); + void sendMessage(final byte[] message); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/driver/context/ClosedContext.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/driver/context/ClosedContext.java b/lang/java/reef-common/src/main/java/org/apache/reef/driver/context/ClosedContext.java index ef3e8cf..ee8be9f 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/driver/context/ClosedContext.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/driver/context/ClosedContext.java @@ -33,5 +33,5 @@ public interface ClosedContext extends ContextBase { /** * @return the new top of the stack of context. */ - public ActiveContext getParentContext(); + ActiveContext getParentContext(); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/driver/context/ContextMessage.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/driver/context/ContextMessage.java b/lang/java/reef-common/src/main/java/org/apache/reef/driver/context/ContextMessage.java index 64e8116..b3be7c3 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/driver/context/ContextMessage.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/driver/context/ContextMessage.java @@ -36,17 +36,17 @@ public interface ContextMessage extends Message, Identifiable { * @return the message sent by the Context. */ @Override - public byte[] get(); + byte[] get(); /** * @return the ID of the sending Context. */ @Override - public String getId(); + String getId(); /** * @return the ID of the ContextMessageSource that sent the message on the Context. */ - public String getMessageSourceID(); + String getMessageSourceID(); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/EvaluatorRequest.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/EvaluatorRequest.java b/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/EvaluatorRequest.java index 72b6e64..5f1db52 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/EvaluatorRequest.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/EvaluatorRequest.java @@ -86,7 +86,7 @@ public final class EvaluatorRequest { * @return the {@link org.apache.reef.driver.catalog.NodeDescriptor} used as the template for this * {@link EvaluatorRequest}. */ - public final ResourceCatalog.Descriptor getDescriptor() { + public ResourceCatalog.Descriptor getDescriptor() { return this.descriptor; } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/EvaluatorRequestor.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/EvaluatorRequestor.java b/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/EvaluatorRequestor.java index 0b7cb30..36aec03 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/EvaluatorRequestor.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/EvaluatorRequestor.java @@ -34,5 +34,5 @@ public interface EvaluatorRequestor { * Submit the request for new evaluator. * The response will surface in the AllocatedEvaluator message handler. */ - public void submit(final EvaluatorRequest req); + void submit(final EvaluatorRequest req); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/FailedEvaluator.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/FailedEvaluator.java b/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/FailedEvaluator.java index e7ed791..4d7d29b 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/FailedEvaluator.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/FailedEvaluator.java @@ -40,16 +40,16 @@ public interface FailedEvaluator extends Identifiable { /** * @return the reason for the failure. */ - public EvaluatorException getEvaluatorException(); + EvaluatorException getEvaluatorException(); /** * @return the list of all context that failed due to the evaluator failure. */ - public List<FailedContext> getFailedContextList(); + List<FailedContext> getFailedContextList(); /** * @return the failed task, if there was one running at the time of the evaluator failure. */ - public Optional<FailedTask> getFailedTask(); + Optional<FailedTask> getFailedTask(); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/driver/task/CompletedTask.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/driver/task/CompletedTask.java b/lang/java/reef-common/src/main/java/org/apache/reef/driver/task/CompletedTask.java index 9ed9b68..3ee3949 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/driver/task/CompletedTask.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/driver/task/CompletedTask.java @@ -36,11 +36,11 @@ public interface CompletedTask extends Message, Identifiable { /** * @return the context the Task ran on. */ - public ActiveContext getActiveContext(); + ActiveContext getActiveContext(); /** * @return the id of the completed task. */ @Override - public String getId(); + String getId(); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/driver/task/RunningTask.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/driver/task/RunningTask.java b/lang/java/reef-common/src/main/java/org/apache/reef/driver/task/RunningTask.java index 593f5e4..d406d80 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/driver/task/RunningTask.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/driver/task/RunningTask.java @@ -36,7 +36,7 @@ public interface RunningTask extends Identifiable, AutoCloseable { /** * @return the context the task is running on. */ - public ActiveContext getActiveContext(); + ActiveContext getActiveContext(); /** @@ -44,30 +44,30 @@ public interface RunningTask extends Identifiable, AutoCloseable { * * @param message to be sent to the running task */ - public void send(final byte[] message); + void send(final byte[] message); /** * Signal the task to suspend. * * @param message a message that is sent to the Task. */ - public void suspend(final byte[] message); + void suspend(final byte[] message); /** * Signal the task to suspend. */ - public void suspend(); + void suspend(); /** * Signal the task to shut down. * * @param message a message that is sent to the Task. */ - public void close(final byte[] message); + void close(final byte[] message); /** * Signal the task to shut down. */ @Override - public void close(); + void close(); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/driver/task/SuspendedTask.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/driver/task/SuspendedTask.java b/lang/java/reef-common/src/main/java/org/apache/reef/driver/task/SuspendedTask.java index 361aab9..e07931f 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/driver/task/SuspendedTask.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/driver/task/SuspendedTask.java @@ -36,6 +36,6 @@ public interface SuspendedTask extends Message, Identifiable { * @return the context the task ran on. This context is now available to run another task or to spwan new * child context */ - public ActiveContext getActiveContext(); + ActiveContext getActiveContext(); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/evaluator/context/ContextMessageHandler.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/evaluator/context/ContextMessageHandler.java b/lang/java/reef-common/src/main/java/org/apache/reef/evaluator/context/ContextMessageHandler.java index e216fba..8d4b460 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/evaluator/context/ContextMessageHandler.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/evaluator/context/ContextMessageHandler.java @@ -35,5 +35,5 @@ public interface ContextMessageHandler extends EventHandler<byte[]> { * @param message sent by the driver to this context */ @Override - public void onNext(final byte[] message); + void onNext(final byte[] message); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/evaluator/context/ContextMessageSource.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/evaluator/context/ContextMessageSource.java b/lang/java/reef-common/src/main/java/org/apache/reef/evaluator/context/ContextMessageSource.java index 0bc8261..f792748 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/evaluator/context/ContextMessageSource.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/evaluator/context/ContextMessageSource.java @@ -33,7 +33,7 @@ public interface ContextMessageSource { /** * @return a message to be sent back to the Driver. */ - public Optional<ContextMessage> getMessage(); + Optional<ContextMessage> getMessage(); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/evaluator/context/events/ContextStart.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/evaluator/context/events/ContextStart.java b/lang/java/reef-common/src/main/java/org/apache/reef/evaluator/context/events/ContextStart.java index 99c36ce..c1a4b42 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/evaluator/context/events/ContextStart.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/evaluator/context/events/ContextStart.java @@ -34,6 +34,6 @@ public interface ContextStart extends Identifiable { /** * @return the ID of the EvaluatorContext that was just launched. */ - public String getId(); + String getId(); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/evaluator/context/events/ContextStop.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/evaluator/context/events/ContextStop.java b/lang/java/reef-common/src/main/java/org/apache/reef/evaluator/context/events/ContextStop.java index 1b4f803..507b920 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/evaluator/context/events/ContextStop.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/evaluator/context/events/ContextStop.java @@ -34,6 +34,6 @@ public interface ContextStop extends Identifiable { /** * @return the ID of the EvaluatorContext. */ - public String getId(); + String getId(); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/io/Accumulable.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/io/Accumulable.java b/lang/java/reef-common/src/main/java/org/apache/reef/io/Accumulable.java index 9a83caf..05126ee 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/io/Accumulable.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/io/Accumulable.java @@ -35,5 +35,5 @@ public interface Accumulable<T> { * @return the new {@link Accumulator} * @throws ServiceException */ - public Accumulator<T> accumulator() throws ServiceException; + Accumulator<T> accumulator() throws ServiceException; } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/io/ExternalMap.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/io/ExternalMap.java b/lang/java/reef-common/src/main/java/org/apache/reef/io/ExternalMap.java index df74aed..6c55780 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/io/ExternalMap.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/io/ExternalMap.java @@ -36,7 +36,7 @@ public interface ExternalMap<T> { * @param key * @return true, if an entry with the given key exists */ - public boolean containsKey(final CharSequence key); + boolean containsKey(final CharSequence key); /** * Element access. @@ -44,7 +44,7 @@ public interface ExternalMap<T> { * @param key * @return the object stored under key nor null if no such object exists */ - public T get(final CharSequence key); + T get(final CharSequence key); /** * Put a record into the map. @@ -55,7 +55,7 @@ public interface ExternalMap<T> { * mapping for key. (A null return can also indicate that the map previously * associated null with key, if the implementation supports null values.) */ - public T put(final CharSequence key, final T value); + T put(final CharSequence key, final T value); /** * Removes the mapping for a key from this map if it is present (optional @@ -76,7 +76,7 @@ public interface ExternalMap<T> { * @return the previous value associated with key, or null if there was no * mapping for key. */ - public T remove(final CharSequence key); + T remove(final CharSequence key); /** * Copies all of the mappings from the specified map to this map (optional @@ -87,7 +87,7 @@ public interface ExternalMap<T> { * * @param m */ - public void putAll(final Map<? extends CharSequence, ? extends T> m); + void putAll(final Map<? extends CharSequence, ? extends T> m); - public Iterable<Map.Entry<CharSequence, T>> getAll(Set<? extends CharSequence> keys); + Iterable<Map.Entry<CharSequence, T>> getAll(Set<? extends CharSequence> keys); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/io/Message.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/io/Message.java b/lang/java/reef-common/src/main/java/org/apache/reef/io/Message.java index 846c996..16ae5e2 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/io/Message.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/io/Message.java @@ -31,6 +31,6 @@ public interface Message { * * @return message payload */ - public byte[] get(); + byte[] get(); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/io/Spool.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/io/Spool.java b/lang/java/reef-common/src/main/java/org/apache/reef/io/Spool.java index 18d2b4b..3dd3f11 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/io/Spool.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/io/Spool.java @@ -43,7 +43,7 @@ public interface Spool<T> extends Iterable<T>, Accumulable<T> { * @throws Exception */ @Override - public Iterator<T> iterator(); + Iterator<T> iterator(); /** * Returns an Accumulator for the spool file. @@ -56,5 +56,5 @@ public interface Spool<T> extends Iterable<T>, Accumulable<T> { * @throws ServiceException */ @Override - public Accumulator<T> accumulator() throws ServiceException; + Accumulator<T> accumulator() throws ServiceException; } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/io/TempFileCreator.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/io/TempFileCreator.java b/lang/java/reef-common/src/main/java/org/apache/reef/io/TempFileCreator.java index 25dcb59..6027518 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/io/TempFileCreator.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/io/TempFileCreator.java @@ -39,7 +39,7 @@ public interface TempFileCreator { * @return * @throws IOException */ - public File createTempFile(final String prefix, final String suffix) throws IOException; + File createTempFile(final String prefix, final String suffix) throws IOException; /** * Creates a temporary folder. @@ -49,7 +49,7 @@ public interface TempFileCreator { * @return * @throws IOException */ - public File createTempDirectory(final String prefix, final FileAttribute<?> attrs) throws IOException; + File createTempDirectory(final String prefix, final FileAttribute<?> attrs) throws IOException; /** @@ -59,7 +59,7 @@ public interface TempFileCreator { * @return * @throws IOException */ - public File createTempDirectory(final String prefix) throws IOException; + File createTempDirectory(final String prefix) throws IOException; } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/Identifiable.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/Identifiable.java b/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/Identifiable.java index 89bfc60..236796a 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/Identifiable.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/Identifiable.java @@ -29,5 +29,5 @@ public interface Identifiable { * * @return an identifier of this object */ - public String getId(); + String getId(); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/NameAssignment.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/NameAssignment.java b/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/NameAssignment.java index 2499ecb..95584ff 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/NameAssignment.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/NameAssignment.java @@ -32,13 +32,13 @@ public interface NameAssignment { * * @return an identifier */ - public Identifier getIdentifier(); + Identifier getIdentifier(); /** * Returns an address of this object. * * @return a socket address */ - public InetSocketAddress getAddress(); + InetSocketAddress getAddress(); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/NamingLookup.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/NamingLookup.java b/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/NamingLookup.java index d6a05a8..13c912c 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/NamingLookup.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/NamingLookup.java @@ -37,6 +37,6 @@ public interface NamingLookup { * @return * @throws java.io.IOException */ - public InetSocketAddress lookup(final Identifier id) throws Exception; + InetSocketAddress lookup(final Identifier id) throws Exception; } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/NamingRegistry.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/NamingRegistry.java b/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/NamingRegistry.java index 035a348..5600b21 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/NamingRegistry.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/NamingRegistry.java @@ -34,7 +34,7 @@ public interface NamingRegistry { * @param addr * @throws Exception */ - public void register(final Identifier id, final InetSocketAddress addr) throws Exception; + void register(final Identifier id, final InetSocketAddress addr) throws Exception; /** * Unregister the given Identifier from the registry. @@ -42,5 +42,5 @@ public interface NamingRegistry { * @param id * @throws Exception */ - public void unregister(final Identifier id) throws Exception; + void unregister(final Identifier id) throws Exception; } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/io/serialization/Codec.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/io/serialization/Codec.java b/lang/java/reef-common/src/main/java/org/apache/reef/io/serialization/Codec.java index 7f00919..1f3c540 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/io/serialization/Codec.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/io/serialization/Codec.java @@ -33,7 +33,7 @@ public interface Codec<T> { * @param obj * @return a byte[] representation of the object */ - public byte[] encode(T obj); + byte[] encode(T obj); /** * Decodes the given byte array into an object. @@ -41,5 +41,5 @@ public interface Codec<T> { * @param buf * @return the decoded object */ - public T decode(byte[] buf); + T decode(byte[] buf); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/io/serialization/Deserializer.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/io/serialization/Deserializer.java b/lang/java/reef-common/src/main/java/org/apache/reef/io/serialization/Deserializer.java index 1e98b81..16b59be 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/io/serialization/Deserializer.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/io/serialization/Deserializer.java @@ -33,5 +33,5 @@ public interface Deserializer<ObjectType, InType> { * @param arg * @return */ - public Iterable<ObjectType> create(InType arg); + Iterable<ObjectType> create(InType arg); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/io/serialization/Serializer.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/io/serialization/Serializer.java b/lang/java/reef-common/src/main/java/org/apache/reef/io/serialization/Serializer.java index f373031..a2df4d0 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/io/serialization/Serializer.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/io/serialization/Serializer.java @@ -34,5 +34,5 @@ public interface Serializer<ObjectType, OutType> { * @param arg * @return */ - public Accumulable<ObjectType> create(OutType arg); + Accumulable<ObjectType> create(OutType arg); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/JobSubmissionHelper.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/JobSubmissionHelper.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/JobSubmissionHelper.java index dd4436a..67c96eb 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/JobSubmissionHelper.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/JobSubmissionHelper.java @@ -73,7 +73,7 @@ final class JobSubmissionHelper { * @throws InjectionException * @throws IOException */ - final JobSubmissionEventImpl.Builder getJobSubmissionBuilder(final Configuration driverConfiguration) throws InjectionException, IOException { + JobSubmissionEventImpl.Builder getJobSubmissionBuilder(final Configuration driverConfiguration) throws InjectionException, IOException { final Injector injector = Tang.Factory.getTang().newInjector(driverConfiguration); final JobSubmissionEventImpl.Builder jbuilder = JobSubmissionEventImpl.newBuilder() http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/REEFImplementation.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/REEFImplementation.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/REEFImplementation.java index baaa7ef..c20d46f 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/REEFImplementation.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/REEFImplementation.java @@ -84,7 +84,7 @@ public final class REEFImplementation implements REEF { } @Override - public final void close() { + public void close() { this.runningJobs.closeAllJobs(); this.clientWireUp.close(); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/RunningJobs.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/RunningJobs.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/RunningJobs.java index 03c81f8..e640528 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/RunningJobs.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/RunningJobs.java @@ -35,7 +35,7 @@ interface RunningJobs { /** * Closes all registered jobs forcefully. */ - public void closeAllJobs(); + void closeAllJobs(); /** * Processes a status message from a Job. If the Job is already known, the message will be passed on. If it is a @@ -43,13 +43,13 @@ interface RunningJobs { * * @param message */ - public void onJobStatusMessage(final RemoteMessage<ReefServiceProtos.JobStatusProto> message); + void onJobStatusMessage(final RemoteMessage<ReefServiceProtos.JobStatusProto> message); /** * Processes a error message from the resource manager. * * @param runtimeFailure */ - public void onRuntimeErrorMessage(final RemoteMessage<ReefServiceProtos.RuntimeErrorProto> runtimeFailure); + void onRuntimeErrorMessage(final RemoteMessage<ReefServiceProtos.RuntimeErrorProto> runtimeFailure); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/api/JobSubmissionHandler.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/api/JobSubmissionHandler.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/api/JobSubmissionHandler.java index d150f8a..3cdae31 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/api/JobSubmissionHandler.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/api/JobSubmissionHandler.java @@ -25,5 +25,5 @@ import org.apache.reef.wake.EventHandler; public interface JobSubmissionHandler extends EventHandler<JobSubmissionEvent>, AutoCloseable { @Override - public void close(); + void close(); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/catalog/RackDescriptorImpl.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/catalog/RackDescriptorImpl.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/catalog/RackDescriptorImpl.java index 6724ca7..f195986 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/catalog/RackDescriptorImpl.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/catalog/RackDescriptorImpl.java @@ -37,7 +37,7 @@ public final class RackDescriptorImpl implements RackDescriptor { this.nodes = new ArrayList<>(); } - public final String toString() { + public String toString() { final StringBuilder sb = new StringBuilder(); sb.append("Rack " + this.name); for (final NodeDescriptorImpl node : nodes) { @@ -46,11 +46,11 @@ public final class RackDescriptorImpl implements RackDescriptor { return sb.toString(); } - public final int hashCode() { + public int hashCode() { return this.name.hashCode(); } - public final boolean equals(final Object obj) { + public boolean equals(final Object obj) { if (obj instanceof RackDescriptorImpl) { return obj.toString().equals(this.name); } else { http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/catalog/ResourceCatalogImpl.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/catalog/ResourceCatalogImpl.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/catalog/ResourceCatalogImpl.java index b03ef1d..59f9c7b 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/catalog/ResourceCatalogImpl.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/catalog/ResourceCatalogImpl.java @@ -64,11 +64,11 @@ public final class ResourceCatalogImpl implements ResourceCatalog { return Collections.unmodifiableCollection(new ArrayList<RackDescriptor>(this.racks.values())); } - public synchronized final NodeDescriptor getNode(final String id) { + public synchronized NodeDescriptor getNode(final String id) { return this.nodes.get(id); } - public synchronized final void handle(final NodeDescriptorEvent node) { + public synchronized void handle(final NodeDescriptorEvent node) { final String rack_name = node.getRackName().orElse(DEFAULT_RACK); LOG.log(Level.FINEST, "Catalog new node: id[{0}], rack[{1}], host[{2}], port[{3}], memory[{4}]", http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/context/ContextFactory.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/context/ContextFactory.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/context/ContextFactory.java index cda8d4f..f5a41e2 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/context/ContextFactory.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/context/ContextFactory.java @@ -76,7 +76,7 @@ final class ContextFactory { * @param parentID * @return a new Context representer with the given id and parent id. */ - public final EvaluatorContext newContext(final String contextId, final Optional<String> parentID) { + public EvaluatorContext newContext(final String contextId, final Optional<String> parentID) { synchronized (this.priorIds) { if (this.priorIds.contains(contextId)) { throw new IllegalStateException("Creating second EvaluatorContext instance for id " + contextId); http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/context/ContextMessageImpl.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/context/ContextMessageImpl.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/context/ContextMessageImpl.java index 26d2263..4c79972 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/context/ContextMessageImpl.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/context/ContextMessageImpl.java @@ -49,7 +49,7 @@ public final class ContextMessageImpl implements ContextMessage { } @Override - public final String getMessageSourceID() { + public String getMessageSourceID() { return this.theMessageSourceId; } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/context/EvaluatorContext.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/context/EvaluatorContext.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/context/EvaluatorContext.java index d5c6d5a..3cefc12 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/context/EvaluatorContext.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/context/EvaluatorContext.java @@ -218,7 +218,7 @@ public final class EvaluatorContext implements ActiveContext { ", parentID=" + this.parentID + '}'; } - public synchronized final ClosedContext getClosedContext(final ActiveContext parentContext) { + public synchronized ClosedContext getClosedContext(final ActiveContext parentContext) { return new ClosedContextImpl( parentContext, this.getId(), this.getEvaluatorId(), this.getEvaluatorDescriptor()); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/AllocatedEvaluatorImpl.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/AllocatedEvaluatorImpl.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/AllocatedEvaluatorImpl.java index e59b11c..0bdf420 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/AllocatedEvaluatorImpl.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/AllocatedEvaluatorImpl.java @@ -169,9 +169,9 @@ final class AllocatedEvaluatorImpl implements AllocatedEvaluator { this.libraries.add(file); } - private final void launch(final Configuration contextConfiguration, - final Optional<Configuration> serviceConfiguration, - final Optional<Configuration> taskConfiguration) { + private void launch(final Configuration contextConfiguration, + final Optional<Configuration> serviceConfiguration, + final Optional<Configuration> taskConfiguration) { try (final LoggingScope lb = loggingScopeFactory.evaluatorLaunch(this.getId())) { final Configuration evaluatorConfiguration = makeEvaluatorConfiguration(contextConfiguration, serviceConfiguration, taskConfiguration); http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/EvaluatorHeartBeatSanityChecker.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/EvaluatorHeartBeatSanityChecker.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/EvaluatorHeartBeatSanityChecker.java index 20aa620..655d4e4 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/EvaluatorHeartBeatSanityChecker.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/EvaluatorHeartBeatSanityChecker.java @@ -40,7 +40,7 @@ final class EvaluatorHeartBeatSanityChecker { EvaluatorHeartBeatSanityChecker() { } - final synchronized void check(final String id, final long timeStamp) { + synchronized void check(final String id, final long timeStamp) { if (knownTimeStamps.containsKey(id)) { final long oldTimeStamp = this.knownTimeStamps.get(id); LOG.log(Level.FINEST, "TIMESTAMP CHECKER: id [ " + id + " ], old timestamp [ " + oldTimeStamp + " ], new timestamp [ " + timeStamp + " ]"); http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/EvaluatorManagerFactory.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/EvaluatorManagerFactory.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/EvaluatorManagerFactory.java index f0680af..050a44a 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/EvaluatorManagerFactory.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/EvaluatorManagerFactory.java @@ -59,7 +59,7 @@ public final class EvaluatorManagerFactory { * @param desc NodeDescriptor on which the Evaluator executes. * @return a new EvaluatorManager instance. */ - private final EvaluatorManager getNewEvaluatorManagerInstance(final String id, final EvaluatorDescriptorImpl desc) { + private EvaluatorManager getNewEvaluatorManagerInstance(final String id, final EvaluatorDescriptorImpl desc) { LOG.log(Level.FINEST, "Creating Evaluator Manager for Evaluator ID {0}", id); final Injector child = this.injector.forkInjector(); @@ -85,7 +85,7 @@ public final class EvaluatorManagerFactory { * @param resourceAllocationEvent * @return */ - public final EvaluatorManager getNewEvaluatorManager(final ResourceAllocationEvent resourceAllocationEvent) { + public EvaluatorManager getNewEvaluatorManager(final ResourceAllocationEvent resourceAllocationEvent) { final NodeDescriptor nodeDescriptor = this.resourceCatalog.getNode(resourceAllocationEvent.getNodeId()); if (nodeDescriptor == null) { @@ -98,7 +98,7 @@ public final class EvaluatorManagerFactory { return this.getNewEvaluatorManagerInstance(resourceAllocationEvent.getIdentifier(), evaluatorDescriptor); } - public final EvaluatorManager createForEvaluatorFailedDuringDriverRestart(final ResourceStatusEvent resourceStatusEvent) { + public EvaluatorManager createForEvaluatorFailedDuringDriverRestart(final ResourceStatusEvent resourceStatusEvent) { if (!resourceStatusEvent.getIsFromPreviousDriver().get()) { throw new RuntimeException("Invalid resourceStatusEvent, must be status for resource from previous Driver."); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/task/TaskMessageImpl.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/task/TaskMessageImpl.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/task/TaskMessageImpl.java index 17824e2..d9485ff 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/task/TaskMessageImpl.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/task/TaskMessageImpl.java @@ -55,7 +55,7 @@ public final class TaskMessageImpl implements TaskMessage { } @Override - public final String getMessageSourceID() { + public String getMessageSourceID() { return this.theMessageSourceId; } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/EvaluatorRuntime.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/EvaluatorRuntime.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/EvaluatorRuntime.java index 8b8d5d3..baea749 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/EvaluatorRuntime.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/EvaluatorRuntime.java @@ -125,7 +125,7 @@ final class EvaluatorRuntime implements EventHandler<EvaluatorControlProto> { } } - private final void onException(final Throwable exception) { + private void onException(final Throwable exception) { synchronized (this.heartBeatManager) { this.state = ReefServiceProtos.State.FAILED; @@ -150,7 +150,7 @@ final class EvaluatorRuntime implements EventHandler<EvaluatorControlProto> { } } - final ReefServiceProtos.State getState() { + ReefServiceProtos.State getState() { return this.state; } @@ -166,7 +166,7 @@ final class EvaluatorRuntime implements EventHandler<EvaluatorControlProto> { final class RuntimeStartHandler implements EventHandler<RuntimeStart> { @Override - public final void onNext(final RuntimeStart runtimeStart) { + public void onNext(final RuntimeStart runtimeStart) { synchronized (EvaluatorRuntime.this.heartBeatManager) { try { LOG.log(Level.FINEST, "runtime start"); @@ -184,7 +184,7 @@ final class EvaluatorRuntime implements EventHandler<EvaluatorControlProto> { final class RuntimeStopHandler implements EventHandler<RuntimeStop> { @Override - public final void onNext(final RuntimeStop runtimeStop) { + public void onNext(final RuntimeStop runtimeStop) { synchronized (EvaluatorRuntime.this.heartBeatManager) { LOG.log(Level.FINEST, "EvaluatorRuntime shutdown invoked for Evaluator {0} in state {1}", new Object[]{evaluatorIdentifier, state}); http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/HeartBeatManager.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/HeartBeatManager.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/HeartBeatManager.java index afb5480..d85e8aa 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/HeartBeatManager.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/HeartBeatManager.java @@ -134,7 +134,7 @@ public class HeartBeatManager { this.contextManager.get().getTaskStatus()); } - private final EvaluatorRuntimeProtocol.EvaluatorHeartbeatProto getEvaluatorHeartbeatProto( + private EvaluatorRuntimeProtocol.EvaluatorHeartbeatProto getEvaluatorHeartbeatProto( final ReefServiceProtos.EvaluatorStatusProto evaluatorStatusProto, final Iterable<ReefServiceProtos.ContextStatusProto> contextStatusProtos, final Optional<ReefServiceProtos.TaskStatusProto> taskStatusProto) { http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/context/ContextLifeCycle.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/context/ContextLifeCycle.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/context/ContextLifeCycle.java index 934549c..dbb090b 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/context/ContextLifeCycle.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/context/ContextLifeCycle.java @@ -58,7 +58,7 @@ final class ContextLifeCycle { /** * Fires ContextStart to all registered event handlers. */ - final void start() { + void start() { final ContextStart contextStart = new ContextStartImpl(this.identifier); for (final EventHandler<ContextStart> startHandler : this.contextStartHandlers) { startHandler.onNext(contextStart); @@ -68,7 +68,7 @@ final class ContextLifeCycle { /** * Fires ContextStop to all registered event handlers. */ - final void close() { + void close() { final ContextStop contextStop = new ContextStopImpl(this.identifier); for (final EventHandler<ContextStop> stopHandler : this.contextStopHandlers) { stopHandler.onNext(contextStop); @@ -80,18 +80,18 @@ final class ContextLifeCycle { * * @param message sent by the driver */ - final void handleContextMessage(final byte[] message) { + void handleContextMessage(final byte[] message) { this.contextMessageHandler.onNext(message); } /** * @return (a shallow copy of) the set of ContextMessageSources configured. */ - final Set<ContextMessageSource> getContextMessageSources() { + Set<ContextMessageSource> getContextMessageSources() { return Collections.unmodifiableSet(new LinkedHashSet<>(this.contextMessageSources)); } - final String getIdentifier() { + String getIdentifier() { return this.identifier; } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/context/ContextRuntime.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/context/ContextRuntime.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/context/ContextRuntime.java index 756aed2..3aca309 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/context/ContextRuntime.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/context/ContextRuntime.java @@ -272,7 +272,7 @@ public final class ContextRuntime { * Close this context. If there is a child context, this recursively closes it before closing this context. If * there is a Task currently running, that will be closed. */ - final void close() { + void close() { synchronized (this.contextLifeCycle) { @@ -369,7 +369,7 @@ public final class ContextRuntime { * * @param message sent by the driver */ - final void handleContextMessage(final byte[] message) { + void handleContextMessage(final byte[] message) { this.contextLifeCycle.handleContextMessage(message); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/context/RootContextLauncher.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/context/RootContextLauncher.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/context/RootContextLauncher.java index 49310dc..0802507 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/context/RootContextLauncher.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/context/RootContextLauncher.java @@ -121,14 +121,14 @@ final class RootContextLauncher { /** * @return the root context for this evaluator. */ - final ContextRuntime getRootContext() throws ContextClientCodeException { + ContextRuntime getRootContext() throws ContextClientCodeException { if (null == this.rootContext) { this.rootContext = getRootContext(this.injector, this.rootContextConfiguration, this.rootServiceConfiguration); } return this.rootContext; } - final Optional<Configuration> getInitialTaskConfiguration() { + Optional<Configuration> getInitialTaskConfiguration() { return this.initialTaskConfiguration; } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/task/TaskRuntime.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/task/TaskRuntime.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/task/TaskRuntime.java index dad7f45..6be5875 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/task/TaskRuntime.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/task/TaskRuntime.java @@ -181,7 +181,7 @@ public final class TaskRuntime implements Runnable { * * @param message the optional message for the close handler or null if there none. */ - public final void close(final byte[] message) { + public void close(final byte[] message) { LOG.log(Level.FINEST, "Triggering Task close."); synchronized (this.heartBeatManager) { if (this.currentStatus.isNotRunning()) { http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/task/TaskStatus.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/task/TaskStatus.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/task/TaskStatus.java index ba1d475..b2c3781 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/task/TaskStatus.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/task/TaskStatus.java @@ -132,7 +132,7 @@ public final class TaskStatus { } } - public final String getTaskId() { + public String getTaskId() { return this.taskId; } @@ -285,7 +285,7 @@ public final class TaskStatus { /** * @return the messages to be sent on the Task's behalf in the next heartbeat. */ - private final Collection<TaskMessage> getMessages() { + private Collection<TaskMessage> getMessages() { final List<TaskMessage> result = new ArrayList<>(this.evaluatorMessageSources.size()); for (final TaskMessageSource messageSource : this.evaluatorMessageSources) { final Optional<TaskMessage> taskMessageOptional = messageSource.getMessage(); http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/LaunchCommandBuilder.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/LaunchCommandBuilder.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/LaunchCommandBuilder.java index a2069be..2cfbfe6 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/LaunchCommandBuilder.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/LaunchCommandBuilder.java @@ -29,13 +29,13 @@ public interface LaunchCommandBuilder { /** * @return the launch command line */ - public List<String> build(); + List<String> build(); - public LaunchCommandBuilder setErrorHandlerRID(final String errorHandlerRID); + LaunchCommandBuilder setErrorHandlerRID(final String errorHandlerRID); - public LaunchCommandBuilder setLaunchID(final String launchID); + LaunchCommandBuilder setLaunchID(final String launchID); - public LaunchCommandBuilder setMemory(final int megaBytes); + LaunchCommandBuilder setMemory(final int megaBytes); /** * Set the name of the configuration file for the Launcher. This file is assumed to exist in the working directory of @@ -44,7 +44,7 @@ public interface LaunchCommandBuilder { * @param configurationFileName * @return this */ - public LaunchCommandBuilder setConfigurationFileName(final String configurationFileName); + LaunchCommandBuilder setConfigurationFileName(final String configurationFileName); /** * Names a file to which stdout will be redirected. @@ -52,7 +52,7 @@ public interface LaunchCommandBuilder { * @param standardOut * @return this */ - public LaunchCommandBuilder setStandardOut(final String standardOut); + LaunchCommandBuilder setStandardOut(final String standardOut); /** * Names a file to which stderr will be redirected. @@ -60,7 +60,7 @@ public interface LaunchCommandBuilder { * @param standardErr * @return this */ - public LaunchCommandBuilder setStandardErr(final String standardErr); + LaunchCommandBuilder setStandardErr(final String standardErr); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/660ee805/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/REEFUncaughtExceptionHandler.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/REEFUncaughtExceptionHandler.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/REEFUncaughtExceptionHandler.java index 5159a4d..ef25689 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/REEFUncaughtExceptionHandler.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/REEFUncaughtExceptionHandler.java @@ -44,7 +44,7 @@ final class REEFUncaughtExceptionHandler implements Thread.UncaughtExceptionHand } @Override - public final synchronized void uncaughtException(final Thread thread, final Throwable throwable) { + public synchronized void uncaughtException(final Thread thread, final Throwable throwable) { final String msg = "Thread " + thread.getName() + " threw an uncaught exception."; LOG.log(Level.SEVERE, msg, throwable); this.errorHandler.onNext(new Exception(msg, throwable));
