http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/REEFErrorHandler.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/REEFErrorHandler.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/REEFErrorHandler.java index c95d435..6124d85 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/REEFErrorHandler.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/REEFErrorHandler.java @@ -48,8 +48,8 @@ public final class REEFErrorHandler implements EventHandler<Throwable> { @Inject REEFErrorHandler(final InjectionFuture<RemoteManager> remoteManager, - final @Parameter(ErrorHandlerRID.class) String errorHandlerRID, - final @Parameter(LaunchID.class) String launchID, + @Parameter(ErrorHandlerRID.class) final String errorHandlerRID, + @Parameter(LaunchID.class) final String launchID, final ExceptionCodec exceptionCodec) { this.errorHandlerRID = errorHandlerRID; this.remoteManager = remoteManager;
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-common/src/main/java/org/apache/reef/util/CommandUtils.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/util/CommandUtils.java b/lang/java/reef-common/src/main/java/org/apache/reef/util/CommandUtils.java index 55d7eed..c8b6144 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/util/CommandUtils.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/util/CommandUtils.java @@ -27,7 +27,7 @@ import java.util.logging.Logger; /** * run given command and return the result as string. */ -final public class CommandUtils { +public final class CommandUtils { /** * Standard java logger. */ http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-common/src/main/java/org/apache/reef/util/REEFVersion.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/util/REEFVersion.java b/lang/java/reef-common/src/main/java/org/apache/reef/util/REEFVersion.java index 2e44c5a..817eda8 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/util/REEFVersion.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/util/REEFVersion.java @@ -30,11 +30,11 @@ import java.util.logging.Logger; */ public final class REEFVersion { - private final static Logger LOG = Logger.getLogger(REEFVersion.class.getName()); + private static final Logger LOG = Logger.getLogger(REEFVersion.class.getName()); - private final static String FILENAME = "version.properties"; - private final static String VERSION_KEY = "version"; - private final static String VERSION_DEFAULT = "unknown"; + private static final String FILENAME = "version.properties"; + private static final String VERSION_KEY = "version"; + private static final String VERSION_DEFAULT = "unknown"; private final String version; http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/BGDClient.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/BGDClient.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/BGDClient.java index bf75239..57a4798 100644 --- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/BGDClient.java +++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/BGDClient.java @@ -50,10 +50,10 @@ public class BGDClient { private final int fanOut; @Inject - public BGDClient(final @Parameter(InputDir.class) String input, - final @Parameter(NumSplits.class) int numSplits, - final @Parameter(EvaluatorMemory.class) int memory, - final @Parameter(TreeTopologyFanOut.class) int fanOut, + public BGDClient(@Parameter(InputDir.class) final String input, + @Parameter(NumSplits.class) final int numSplits, + @Parameter(EvaluatorMemory.class) final int memory, + @Parameter(TreeTopologyFanOut.class) final int fanOut, final BGDControlParameters bgdControlParameters) { this.input = input; this.fanOut = fanOut; http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/parameters/BGDControlParameters.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/parameters/BGDControlParameters.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/parameters/BGDControlParameters.java index 243b7cc..1a6d495 100644 --- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/parameters/BGDControlParameters.java +++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/parameters/BGDControlParameters.java @@ -41,14 +41,14 @@ public final class BGDControlParameters { @Inject public BGDControlParameters( - final @Parameter(ModelDimensions.class) int dimensions, - final @Parameter(Lambda.class) double lambda, - final @Parameter(Eps.class) double eps, - final @Parameter(Eta.class) double eta, - final @Parameter(ProbabilityOfSuccesfulIteration.class) double probOfSuccessfulIteration, - final @Parameter(Iterations.class) int iters, - final @Parameter(EnableRampup.class) boolean rampup, - final @Parameter(MinParts.class) int minParts, + @Parameter(ModelDimensions.class) final int dimensions, + @Parameter(Lambda.class) final double lambda, + @Parameter(Eps.class) final double eps, + @Parameter(Eta.class) final double eta, + @Parameter(ProbabilityOfSuccesfulIteration.class) final double probOfSuccessfulIteration, + @Parameter(Iterations.class) final int iters, + @Parameter(EnableRampup.class) final boolean rampup, + @Parameter(MinParts.class) final int minParts, final BGDLossType lossType) { this.dimensions = dimensions; this.lambda = lambda; http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/broadcast/BroadcastDriver.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/broadcast/BroadcastDriver.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/broadcast/BroadcastDriver.java index 78485e8..4908baf 100644 --- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/broadcast/BroadcastDriver.java +++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/broadcast/BroadcastDriver.java @@ -81,8 +81,8 @@ public class BroadcastDriver { final EvaluatorRequestor requestor, final GroupCommDriver groupCommDriver, final ConfigurationSerializer confSerializer, - final @Parameter(ModelDimensions.class) int dimensions, - final @Parameter(NumberOfReceivers.class) int numberOfReceivers) { + @Parameter(ModelDimensions.class) final int dimensions, + @Parameter(NumberOfReceivers.class) final int numberOfReceivers) { this.requestor = requestor; this.groupCommDriver = groupCommDriver; http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/broadcast/MasterTask.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/broadcast/MasterTask.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/broadcast/MasterTask.java index 18245d3..279321a 100644 --- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/broadcast/MasterTask.java +++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/broadcast/MasterTask.java @@ -54,7 +54,7 @@ public class MasterTask implements Task { @Inject public MasterTask( final GroupCommClient groupCommClient, - final @Parameter(ModelDimensions.class) int dimensions) { + @Parameter(ModelDimensions.class) final int dimensions) { this.dimensions = dimensions; http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-examples/src/main/java/org/apache/reef/examples/pool/JobDriver.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/pool/JobDriver.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/pool/JobDriver.java index 150739b..2a0fabb 100644 --- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/pool/JobDriver.java +++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/pool/JobDriver.java @@ -94,10 +94,10 @@ public final class JobDriver { */ @Inject JobDriver(final EvaluatorRequestor evaluatorRequestor, - final @Parameter(Launch.Piggyback.class) Boolean isPiggyback, - final @Parameter(Launch.NumEvaluators.class) Integer numEvaluators, - final @Parameter(Launch.NumTasks.class) Integer numTasks, - final @Parameter(Launch.Delay.class) Integer delay) { + @Parameter(Launch.Piggyback.class) final Boolean isPiggyback, + @Parameter(Launch.NumEvaluators.class) final Integer numEvaluators, + @Parameter(Launch.NumTasks.class) final Integer numTasks, + @Parameter(Launch.Delay.class) final Integer delay) { this.evaluatorRequestor = evaluatorRequestor; this.isPiggyback = isPiggyback; this.numEvaluators = numEvaluators; http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-examples/src/main/java/org/apache/reef/examples/pool/SleepTask.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/pool/SleepTask.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/pool/SleepTask.java index 2816512..98b3c0a 100644 --- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/pool/SleepTask.java +++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/pool/SleepTask.java @@ -46,7 +46,7 @@ public class SleepTask implements Task { * @param delay number of seconds to sleep. */ @Inject - private SleepTask(final @Parameter(Launch.Delay.class) Integer delay) { + private SleepTask(@Parameter(Launch.Delay.class) final Integer delay) { this.delay = delay * 1000; } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/SuspendClient.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/SuspendClient.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/SuspendClient.java index cc14953..75b5b36 100644 --- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/SuspendClient.java +++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/SuspendClient.java @@ -39,7 +39,7 @@ public class SuspendClient { /** * Standard java logger. */ - private final static Logger LOG = Logger.getLogger(SuspendClient.class.getName()); + private static final Logger LOG = Logger.getLogger(SuspendClient.class.getName()); /** * Job Driver configuration. @@ -66,8 +66,8 @@ public class SuspendClient { SuspendClient( final REEF reef, final SuspendClientControl controlListener, - final @Parameter(Launch.NumCycles.class) int numCycles, - final @Parameter(Launch.Delay.class) int delay) throws BindException, IOException { + @Parameter(Launch.NumCycles.class) final int numCycles, + @Parameter(Launch.Delay.class) final int delay) throws BindException, IOException { final JavaConfigurationBuilder cb = Tang.Factory.getTang().newConfigurationBuilder() .bindNamedParameter(Launch.NumCycles.class, Integer.toString(numCycles)) http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/SuspendClientControl.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/SuspendClientControl.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/SuspendClientControl.java index 128e9ec..58d314e 100644 --- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/SuspendClientControl.java +++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/SuspendClientControl.java @@ -48,7 +48,7 @@ public class SuspendClientControl implements AutoCloseable { @Inject public SuspendClientControl( - final @Parameter(SuspendClientControl.Port.class) int port, + @Parameter(SuspendClientControl.Port.class) final int port, final TransportFactory tpFactory) throws IOException { LOG.log(Level.INFO, "Listen to control port {0}", port); http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/SuspendDriver.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/SuspendDriver.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/SuspendDriver.java index a016529..538d527 100644 --- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/SuspendDriver.java +++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/SuspendDriver.java @@ -112,9 +112,9 @@ public class SuspendDriver { SuspendDriver( final JobMessageObserver jobMessageObserver, final EvaluatorRequestor evaluatorRequestor, - final @Parameter(Launch.Local.class) boolean isLocal, - final @Parameter(Launch.NumCycles.class) int numCycles, - final @Parameter(Launch.Delay.class) int delay) { + @Parameter(Launch.Local.class) final boolean isLocal, + @Parameter(Launch.NumCycles.class) final int numCycles, + @Parameter(Launch.Delay.class) final int delay) { this.jobMessageObserver = jobMessageObserver; this.evaluatorRequestor = evaluatorRequestor; http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/api/DataLoader.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/api/DataLoader.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/api/DataLoader.java index 974de65..00a8368 100644 --- a/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/api/DataLoader.java +++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/api/DataLoader.java @@ -83,9 +83,9 @@ public class DataLoader { final Clock clock, final EvaluatorRequestor requestor, final DataLoadingService dataLoadingService, - final @Parameter(DataLoadingRequestBuilder.DataLoadingEvaluatorMemoryMB.class) int dataEvalMemoryMB, - final @Parameter(DataLoadingRequestBuilder.DataLoadingEvaluatorNumberOfCores.class) int dataEvalCore, - final @Parameter(DataLoadingRequestBuilder.DataLoadingComputeRequest.class) String serializedComputeRequest) { + @Parameter(DataLoadingRequestBuilder.DataLoadingEvaluatorMemoryMB.class) final int dataEvalMemoryMB, + @Parameter(DataLoadingRequestBuilder.DataLoadingEvaluatorNumberOfCores.class) final int dataEvalCore, + @Parameter(DataLoadingRequestBuilder.DataLoadingComputeRequest.class) final String serializedComputeRequest) { // FIXME: Issue #855: We need this alarm to look busy for REEF. clock.scheduleAlarm(30000, new EventHandler<Alarm>() { http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/InputFormatLoadingService.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/InputFormatLoadingService.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/InputFormatLoadingService.java index 01bdb92..dcaafb7 100644 --- a/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/InputFormatLoadingService.java +++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/InputFormatLoadingService.java @@ -74,10 +74,10 @@ public class InputFormatLoadingService<K, V> implements DataLoadingService { public InputFormatLoadingService( final InputFormat<K, V> inputFormat, final JobConf jobConf, - final @Parameter(DataLoadingRequestBuilder.NumberOfDesiredSplits.class) int numberOfDesiredSplits, - final @Parameter(DataLoadingRequestBuilder.LoadDataIntoMemory.class) boolean inMemory, - final @Parameter(JobConfExternalConstructor.InputFormatClass.class) String inputFormatClass, - final @Parameter(JobConfExternalConstructor.InputPath.class) String inputPath) { + @Parameter(DataLoadingRequestBuilder.NumberOfDesiredSplits.class) final int numberOfDesiredSplits, + @Parameter(DataLoadingRequestBuilder.LoadDataIntoMemory.class) final boolean inMemory, + @Parameter(JobConfExternalConstructor.InputFormatClass.class) final String inputFormatClass, + @Parameter(JobConfExternalConstructor.InputPath.class) final String inputPath) { this.inMemory = inMemory; this.inputFormatClass = inputFormatClass; http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/JobConfExternalConstructor.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/JobConfExternalConstructor.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/JobConfExternalConstructor.java index 639686a..8f3e0d5 100644 --- a/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/JobConfExternalConstructor.java +++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/JobConfExternalConstructor.java @@ -41,8 +41,8 @@ public class JobConfExternalConstructor implements ExternalConstructor<JobConf> @Inject public JobConfExternalConstructor( - final @Parameter(InputFormatClass.class) String inputFormatClassName, - final @Parameter(InputPath.class) String inputPath) { + @Parameter(InputFormatClass.class) final String inputFormatClassName, + @Parameter(InputPath.class) final String inputPath) { this.inputFormatClassName = inputFormatClassName; this.inputPath = inputPath; } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/operators/ReduceSender.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/operators/ReduceSender.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/operators/ReduceSender.java index f5842c0..e62deb8 100644 --- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/operators/ReduceSender.java +++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/operators/ReduceSender.java @@ -68,13 +68,13 @@ public class ReduceSender<T> implements Reduce.Sender<T>, EventHandler<GroupComm @Inject public ReduceSender( - final @Parameter(CommunicationGroupName.class) String groupName, - final @Parameter(OperatorName.class) String operName, - final @Parameter(TaskConfigurationOptions.Identifier.class) String selfId, - final @Parameter(DataCodec.class) Codec<T> dataCodec, - final @Parameter(ReduceFunctionParam.class) ReduceFunction<T> reduceFunction, - final @Parameter(DriverIdentifier.class) String driverId, - final @Parameter(TaskVersion.class) int version, + @Parameter(CommunicationGroupName.class) final String groupName, + @Parameter(OperatorName.class) final String operName, + @Parameter(TaskConfigurationOptions.Identifier.class) final String selfId, + @Parameter(DataCodec.class) final Codec<T> dataCodec, + @Parameter(ReduceFunctionParam.class) final ReduceFunction<T> reduceFunction, + @Parameter(DriverIdentifier.class) final String driverId, + @Parameter(TaskVersion.class) final int version, final CommGroupNetworkHandler commGroupNetworkHandler, final NetworkService<GroupCommunicationMessage> netService, final CommunicationGroupServiceClient commGroupClient) { http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/task/GroupCommClientImpl.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/task/GroupCommClientImpl.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/task/GroupCommClientImpl.java index e88796d..30165f9 100644 --- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/task/GroupCommClientImpl.java +++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/task/GroupCommClientImpl.java @@ -49,8 +49,8 @@ public class GroupCommClientImpl implements GroupCommClient { @Inject public GroupCommClientImpl( - final @Parameter(SerializedGroupConfigs.class) Set<String> groupConfigs, - final @Parameter(TaskConfigurationOptions.Identifier.class) String taskId, + @Parameter(SerializedGroupConfigs.class) final Set<String> groupConfigs, + @Parameter(TaskConfigurationOptions.Identifier.class) final String taskId, final GroupCommNetworkHandler groupCommNetworkHandler, final NetworkService<ReefNetworkGroupCommProtos.GroupCommMessage> netService, final ConfigurationSerializer configSerializer) { http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/BindNSToTask.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/BindNSToTask.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/BindNSToTask.java index 5248d23..3fbae43 100644 --- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/BindNSToTask.java +++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/BindNSToTask.java @@ -33,7 +33,7 @@ public class BindNSToTask implements EventHandler<TaskStart> { @Inject public BindNSToTask( final NetworkService<?> ns, - final @Parameter(NetworkServiceParameters.NetworkServiceIdentifierFactory.class) IdentifierFactory idFac) { + @Parameter(NetworkServiceParameters.NetworkServiceIdentifierFactory.class) final IdentifierFactory idFac) { this.ns = ns; this.idFac = idFac; } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkService.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkService.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkService.java index d41b538..03d074c 100644 --- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkService.java +++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkService.java @@ -146,16 +146,16 @@ public final class NetworkService<T> implements Stage, ConnectionFactory<T> { @Deprecated @Inject public NetworkService( - final @Parameter(NetworkServiceParameters.NetworkServiceIdentifierFactory.class) IdentifierFactory factory, - final @Parameter(NetworkServiceParameters.NetworkServicePort.class) int nsPort, - final @Parameter(NameServerParameters.NameServerAddr.class) String nameServerAddr, - final @Parameter(NameServerParameters.NameServerPort.class) int nameServerPort, - final @Parameter(NameLookupClient.RetryCount.class) int retryCount, - final @Parameter(NameLookupClient.RetryTimeout.class) int retryTimeout, - final @Parameter(NetworkServiceParameters.NetworkServiceCodec.class) Codec<T> codec, - final @Parameter(NetworkServiceParameters.NetworkServiceTransportFactory.class) TransportFactory tpFactory, - final @Parameter(NetworkServiceParameters.NetworkServiceHandler.class) EventHandler<Message<T>> recvHandler, - final @Parameter(NetworkServiceParameters.NetworkServiceExceptionHandler.class) EventHandler<Exception> exHandler, + @Parameter(NetworkServiceParameters.NetworkServiceIdentifierFactory.class) final IdentifierFactory factory, + @Parameter(NetworkServiceParameters.NetworkServicePort.class) final int nsPort, + @Parameter(NameServerParameters.NameServerAddr.class) final String nameServerAddr, + @Parameter(NameServerParameters.NameServerPort.class) final int nameServerPort, + @Parameter(NameLookupClient.RetryCount.class) final int retryCount, + @Parameter(NameLookupClient.RetryTimeout.class) final int retryTimeout, + @Parameter(NetworkServiceParameters.NetworkServiceCodec.class) final Codec<T> codec, + @Parameter(NetworkServiceParameters.NetworkServiceTransportFactory.class) final TransportFactory tpFactory, + @Parameter(NetworkServiceParameters.NetworkServiceHandler.class) final EventHandler<Message<T>> recvHandler, + @Parameter(NetworkServiceParameters.NetworkServiceExceptionHandler.class) final EventHandler<Exception> exHandler, final LocalAddressProvider localAddressProvider) { this.factory = factory; http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/UnbindNSFromTask.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/UnbindNSFromTask.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/UnbindNSFromTask.java index 17f55a0..0578a22 100644 --- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/UnbindNSFromTask.java +++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/UnbindNSFromTask.java @@ -33,7 +33,7 @@ public class UnbindNSFromTask implements EventHandler<TaskStop> { @Inject public UnbindNSFromTask( final NetworkService<?> ns, - final @Parameter(NetworkServiceParameters.NetworkServiceIdentifierFactory.class) IdentifierFactory idFac) { + @Parameter(NetworkServiceParameters.NetworkServiceIdentifierFactory.class) final IdentifierFactory idFac) { this.ns = ns; this.idFac = idFac; } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameServerImpl.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameServerImpl.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameServerImpl.java index a18bcd8..9149b3c 100644 --- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameServerImpl.java +++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameServerImpl.java @@ -146,8 +146,8 @@ public class NameServerImpl implements NameServer { */ @Inject public NameServerImpl( - final @Parameter(NameServerParameters.NameServerPort.class) int port, - final @Parameter(NameServerParameters.NameServerIdentifierFactory.class) IdentifierFactory factory, + @Parameter(NameServerParameters.NameServerPort.class) final int port, + @Parameter(NameServerParameters.NameServerIdentifierFactory.class) final IdentifierFactory factory, final ReefEventStateManager reefEventStateManager, final LocalAddressProvider localAddressProvider, final TransportFactory tpFactory) { http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/ram/CodecRamMap.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/ram/CodecRamMap.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/ram/CodecRamMap.java index 11417a0..d93750e 100644 --- a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/ram/CodecRamMap.java +++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/ram/CodecRamMap.java @@ -79,6 +79,6 @@ public class CodecRamMap<T> implements ExternalMap<T> { } @NamedParameter - static public class RamMapCodec implements Name<Codec<?>> { + public static class RamMapCodec implements Name<Codec<?>> { } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-poison/src/main/java/org/apache/reef/poison/PoisonedAlarmHandler.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-poison/src/main/java/org/apache/reef/poison/PoisonedAlarmHandler.java b/lang/java/reef-poison/src/main/java/org/apache/reef/poison/PoisonedAlarmHandler.java index 6a48701..e180e4f 100644 --- a/lang/java/reef-poison/src/main/java/org/apache/reef/poison/PoisonedAlarmHandler.java +++ b/lang/java/reef-poison/src/main/java/org/apache/reef/poison/PoisonedAlarmHandler.java @@ -25,7 +25,7 @@ import org.apache.reef.wake.time.event.Alarm; /** * To be registered on the Clock to handle Alarms. */ -final public class PoisonedAlarmHandler implements EventHandler<Alarm> { +public final class PoisonedAlarmHandler implements EventHandler<Alarm> { @Override public void onNext(final Alarm alarm) { throw new PoisonException("Crashed at: " + alarm.toString()); http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-poison/src/main/java/org/apache/reef/poison/context/PoisonedContextStartHandler.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-poison/src/main/java/org/apache/reef/poison/context/PoisonedContextStartHandler.java b/lang/java/reef-poison/src/main/java/org/apache/reef/poison/context/PoisonedContextStartHandler.java index 1d97a07..1037217 100644 --- a/lang/java/reef-poison/src/main/java/org/apache/reef/poison/context/PoisonedContextStartHandler.java +++ b/lang/java/reef-poison/src/main/java/org/apache/reef/poison/context/PoisonedContextStartHandler.java @@ -44,8 +44,8 @@ public final class PoisonedContextStartHandler implements EventHandler<ContextSt @Inject public PoisonedContextStartHandler( - final @Parameter(CrashProbability.class) double crashProbability, - final @Parameter(CrashTimeout.class) int timeOut, + @Parameter(CrashProbability.class) final double crashProbability, + @Parameter(CrashTimeout.class) final int timeOut, final Clock clock) { this.crashProbability = crashProbability; http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-poison/src/main/java/org/apache/reef/poison/context/PoissonPoisonedContextStartHandler.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-poison/src/main/java/org/apache/reef/poison/context/PoissonPoisonedContextStartHandler.java b/lang/java/reef-poison/src/main/java/org/apache/reef/poison/context/PoissonPoisonedContextStartHandler.java index ff4a5b5..7b1138f 100644 --- a/lang/java/reef-poison/src/main/java/org/apache/reef/poison/context/PoissonPoisonedContextStartHandler.java +++ b/lang/java/reef-poison/src/main/java/org/apache/reef/poison/context/PoissonPoisonedContextStartHandler.java @@ -39,7 +39,7 @@ final class PoissonPoisonedContextStartHandler implements EventHandler<ContextSt @Inject public PoissonPoisonedContextStartHandler( - final @Parameter(CrashProbability.class) double lambda, final Clock clock) { + @Parameter(CrashProbability.class) final double lambda, final Clock clock) { this.clock = clock; this.timeToCrash = new PoissonDistribution(lambda * 1000).sample(); http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-poison/src/main/java/org/apache/reef/poison/task/PoisonedTaskStartHandler.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-poison/src/main/java/org/apache/reef/poison/task/PoisonedTaskStartHandler.java b/lang/java/reef-poison/src/main/java/org/apache/reef/poison/task/PoisonedTaskStartHandler.java index 21ac668..7b31ae8 100644 --- a/lang/java/reef-poison/src/main/java/org/apache/reef/poison/task/PoisonedTaskStartHandler.java +++ b/lang/java/reef-poison/src/main/java/org/apache/reef/poison/task/PoisonedTaskStartHandler.java @@ -44,8 +44,8 @@ public final class PoisonedTaskStartHandler implements EventHandler<TaskStart> { @Inject public PoisonedTaskStartHandler( - final @Parameter(CrashProbability.class) double crashProbability, - final @Parameter(CrashTimeout.class) int timeOut, + @Parameter(CrashProbability.class) final double crashProbability, + @Parameter(CrashTimeout.class) final int timeOut, final Clock clock) { this.crashProbability = crashProbability; http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-poison/src/main/java/org/apache/reef/poison/task/PoissonPoisonedTaskStartHandler.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-poison/src/main/java/org/apache/reef/poison/task/PoissonPoisonedTaskStartHandler.java b/lang/java/reef-poison/src/main/java/org/apache/reef/poison/task/PoissonPoisonedTaskStartHandler.java index 70f118b..7a95c26 100644 --- a/lang/java/reef-poison/src/main/java/org/apache/reef/poison/task/PoissonPoisonedTaskStartHandler.java +++ b/lang/java/reef-poison/src/main/java/org/apache/reef/poison/task/PoissonPoisonedTaskStartHandler.java @@ -39,7 +39,7 @@ final class PoissonPoisonedTaskStartHandler implements EventHandler<TaskStart> { @Inject public PoissonPoisonedTaskStartHandler( - final @Parameter(CrashProbability.class) double lambda, final Clock clock) { + @Parameter(CrashProbability.class) final double lambda, final Clock clock) { this.clock = clock; this.timeToCrash = new PoissonDistribution(lambda * 1000).sample(); http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/cli/LogFetcher.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/cli/LogFetcher.java b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/cli/LogFetcher.java index e168513..c269287 100644 --- a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/cli/LogFetcher.java +++ b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/cli/LogFetcher.java @@ -51,9 +51,9 @@ final class LogFetcher { @Inject - LogFetcher(final @Parameter(AzureStorageAccountName.class) String accountName, - final @Parameter(AzureStorageAccountKey.class) String accountKey, - final @Parameter(AzureStorageAccountContainerName.class) String azureStorageContainerName) + LogFetcher(@Parameter(AzureStorageAccountName.class) final String accountName, + @Parameter(AzureStorageAccountKey.class) final String accountKey, + @Parameter(AzureStorageAccountContainerName.class) final String azureStorageContainerName) throws URISyntaxException, InvalidKeyException, StorageException, IOException { this.container = getContainer(accountName, accountKey, azureStorageContainerName); this.hadoopConfiguration = new Configuration(); http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/AzureUploader.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/AzureUploader.java b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/AzureUploader.java index 3c00ce0..7e069ef 100644 --- a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/AzureUploader.java +++ b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/AzureUploader.java @@ -63,10 +63,10 @@ final class AzureUploader { @Inject AzureUploader( - final @Parameter(AzureStorageAccountName.class) String accountName, - final @Parameter(AzureStorageAccountKey.class) String accountKey, - final @Parameter(AzureStorageAccountContainerName.class) String azureStorageContainerName, - final @Parameter(AzureStorageBaseFolder.class) String baseFolder) + @Parameter(AzureStorageAccountName.class) final String accountName, + @Parameter(AzureStorageAccountKey.class) final String accountKey, + @Parameter(AzureStorageAccountContainerName.class) final String azureStorageContainerName, + @Parameter(AzureStorageBaseFolder.class) final String baseFolder) throws URISyntaxException, InvalidKeyException, StorageException { this.storageAccount = CloudStorageAccount.parse(getStorageConnectionString(accountName, accountKey)); http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/HDInsightJobSubmissionHandler.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/HDInsightJobSubmissionHandler.java b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/HDInsightJobSubmissionHandler.java index 151c9a1..a05b93c 100644 --- a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/HDInsightJobSubmissionHandler.java +++ b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/HDInsightJobSubmissionHandler.java @@ -63,7 +63,7 @@ public final class HDInsightJobSubmissionHandler implements JobSubmissionHandler final HDInsightInstance hdInsightInstance, final REEFFileNames filenames, final ClasspathProvider classpath, - final @Parameter(JVMHeapSlack.class) double jvmHeapSlack) { + @Parameter(JVMHeapSlack.class) final double jvmHeapSlack) { this.uploader = uploader; this.jobJarMaker = jobJarMaker; this.hdInsightInstance = hdInsightInstance; http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/HDInsightInstance.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/HDInsightInstance.java b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/HDInsightInstance.java index e4b0bce..cbf2d8b 100644 --- a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/HDInsightInstance.java +++ b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/HDInsightInstance.java @@ -68,9 +68,9 @@ public final class HDInsightInstance { private final CloseableHttpClient httpClient; @Inject - HDInsightInstance(final @Parameter(HDInsightUsername.class) String username, - final @Parameter(HDInsightPassword.class) String password, - final @Parameter(HDInsightInstanceURL.class) String instanceUrl, + HDInsightInstance(@Parameter(HDInsightUsername.class) final String username, + @Parameter(HDInsightPassword.class) final String password, + @Parameter(HDInsightInstanceURL.class) final String instanceUrl, final CloseableHttpClient client) throws URISyntaxException, IOException { this.httpClient = client; this.instanceUrl = instanceUrl.endsWith("/") ? instanceUrl : instanceUrl + "/"; http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/DriverConfigurationProvider.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/DriverConfigurationProvider.java b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/DriverConfigurationProvider.java index 6fea6de..321ff86 100644 --- a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/DriverConfigurationProvider.java +++ b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/DriverConfigurationProvider.java @@ -37,8 +37,8 @@ public final class DriverConfigurationProvider { private final double jvmHeapSlack; @Inject - DriverConfigurationProvider(final @Parameter(MaxNumberOfEvaluators.class) int maxEvaluators, - final @Parameter(JVMHeapSlack.class) double jvmHeapSlack) { + DriverConfigurationProvider(@Parameter(MaxNumberOfEvaluators.class) final int maxEvaluators, + @Parameter(JVMHeapSlack.class) final double jvmHeapSlack) { this.maxEvaluators = maxEvaluators; this.jvmHeapSlack = jvmHeapSlack; } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/LocalJobSubmissionHandler.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/LocalJobSubmissionHandler.java b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/LocalJobSubmissionHandler.java index 03ad267..6138c8a 100644 --- a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/LocalJobSubmissionHandler.java +++ b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/LocalJobSubmissionHandler.java @@ -56,7 +56,7 @@ final class LocalJobSubmissionHandler implements JobSubmissionHandler { @Inject public LocalJobSubmissionHandler( final ExecutorService executor, - final @Parameter(RootFolder.class) String rootFolderName, + @Parameter(RootFolder.class) final String rootFolderName, final ConfigurationSerializer configurationSerializer, final REEFFileNames fileNames, http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ContainerManager.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ContainerManager.java b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ContainerManager.java index 8a98087..cc13327 100644 --- a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ContainerManager.java +++ b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ContainerManager.java @@ -55,7 +55,7 @@ import java.util.logging.Logger; @DriverSide final class ContainerManager implements AutoCloseable { - private final static Logger LOG = Logger.getLogger(ContainerManager.class.getName()); + private static final Logger LOG = Logger.getLogger(ContainerManager.class.getName()); /** * Map from containerID -> Container. @@ -80,9 +80,9 @@ final class ContainerManager implements AutoCloseable { final RemoteManager remoteManager, final RuntimeClock clock, final REEFFileNames fileNames, - final @Parameter(MaxNumberOfEvaluators.class) int capacity, - final @Parameter(RootFolder.class) String rootFolderName, - final @Parameter(RuntimeParameters.NodeDescriptorHandler.class) + @Parameter(MaxNumberOfEvaluators.class) final int capacity, + @Parameter(RootFolder.class) final String rootFolderName, + @Parameter(RuntimeParameters.NodeDescriptorHandler.class) final EventHandler<NodeDescriptorEvent> nodeDescriptorHandler, final ReefRunnableProcessObserver processObserver, final LocalAddressProvider localAddressProvider) { http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ResourceManager.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ResourceManager.java b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ResourceManager.java index 8d9656b..ace6c6a 100644 --- a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ResourceManager.java +++ b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ResourceManager.java @@ -58,7 +58,7 @@ import java.util.logging.Logger; @DriverSide public final class ResourceManager { - private final static Logger LOG = Logger.getLogger(ResourceManager.class.getName()); + private static final Logger LOG = Logger.getLogger(ResourceManager.class.getName()); private final ResourceRequestQueue requestQueue = new ResourceRequestQueue(); @@ -77,11 +77,11 @@ public final class ResourceManager { @Inject ResourceManager( final ContainerManager containerManager, - final @Parameter(RuntimeParameters.ResourceAllocationHandler.class) EventHandler<ResourceAllocationEvent> allocationHandler, - final @Parameter(RuntimeParameters.RuntimeStatusHandler.class) EventHandler<RuntimeStatusEvent> runtimeStatusHandlerEventHandler, - final @Parameter(DefaultMemorySize.class) int defaultMemorySize, - final @Parameter(DefaultNumberOfCores.class) int defaultNumberOfCores, - final @Parameter(JVMHeapSlack.class) double jvmHeapSlack, + @Parameter(RuntimeParameters.ResourceAllocationHandler.class) final EventHandler<ResourceAllocationEvent> allocationHandler, + @Parameter(RuntimeParameters.RuntimeStatusHandler.class) final EventHandler<RuntimeStatusEvent> runtimeStatusHandlerEventHandler, + @Parameter(DefaultMemorySize.class) final int defaultMemorySize, + @Parameter(DefaultNumberOfCores.class) final int defaultNumberOfCores, + @Parameter(JVMHeapSlack.class) final double jvmHeapSlack, final ConfigurationSerializer configurationSerializer, final RemoteManager remoteManager, final REEFFileNames fileNames, http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/process/ReefRunnableProcessObserver.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/process/ReefRunnableProcessObserver.java b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/process/ReefRunnableProcessObserver.java index caa7f87..6e26dc4 100644 --- a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/process/ReefRunnableProcessObserver.java +++ b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/process/ReefRunnableProcessObserver.java @@ -46,7 +46,7 @@ public final class ReefRunnableProcessObserver implements RunnableProcessObserve * @param resourceStatusHandler the event handler to inform of resource changes. */ @Inject - public ReefRunnableProcessObserver(final @Parameter(RuntimeParameters.ResourceStatusHandler.class) + public ReefRunnableProcessObserver(@Parameter(RuntimeParameters.ResourceStatusHandler.class) final EventHandler<ResourceStatusEvent> resourceStatusHandler, final InjectionFuture<ResourceManager> resourceManager) { this.resourceStatusHandler = resourceStatusHandler; http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/client/MesosJobSubmissionHandler.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/client/MesosJobSubmissionHandler.java b/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/client/MesosJobSubmissionHandler.java index 1da1af4..e9a70fa 100644 --- a/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/client/MesosJobSubmissionHandler.java +++ b/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/client/MesosJobSubmissionHandler.java @@ -59,12 +59,12 @@ final class MesosJobSubmissionHandler implements JobSubmissionHandler { private final double jvmSlack; @Inject - MesosJobSubmissionHandler(final @Parameter(RootFolder.class) String rootFolderName, - final @Parameter(MasterIp.class) String masterIp, + MesosJobSubmissionHandler(@Parameter(RootFolder.class) final String rootFolderName, + @Parameter(MasterIp.class) final String masterIp, final ConfigurationSerializer configurationSerializer, final REEFFileNames fileNames, final ClasspathProvider classpath, - final @Parameter(JVMHeapSlack.class) double jvmSlack) { + @Parameter(JVMHeapSlack.class) final double jvmSlack) { this.rootFolderName = new File(rootFolderName).getAbsolutePath(); this.masterIp = masterIp; this.configurationSerializer = configurationSerializer; http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/driver/MesosResourceLaunchHandler.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/driver/MesosResourceLaunchHandler.java b/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/driver/MesosResourceLaunchHandler.java index 01299b8..9952ff2 100644 --- a/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/driver/MesosResourceLaunchHandler.java +++ b/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/driver/MesosResourceLaunchHandler.java @@ -64,7 +64,7 @@ final class MesosResourceLaunchHandler implements ResourceLaunchHandler { final REEFFileNames fileNames, final REEFExecutors executors, final ClasspathProvider classpath, - final @Parameter(JVMHeapSlack.class) double jvmHeapSlack) { + @Parameter(JVMHeapSlack.class) final double jvmHeapSlack) { this.configurationSerializer = configurationSerializer; this.remoteManager = remoteManager; this.fileNames = fileNames; http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/driver/REEFEventHandlers.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/driver/REEFEventHandlers.java b/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/driver/REEFEventHandlers.java index d850d4a..6f3669d 100644 --- a/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/driver/REEFEventHandlers.java +++ b/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/driver/REEFEventHandlers.java @@ -37,10 +37,10 @@ final class REEFEventHandlers { private final EventHandler<ResourceStatusEvent> resourceStatusHandlerEventHandler; @Inject - REEFEventHandlers(final @Parameter(RuntimeParameters.ResourceAllocationHandler.class) EventHandler<ResourceAllocationEvent> resourceAllocationEventHandler, - final @Parameter(RuntimeParameters.RuntimeStatusHandler.class) EventHandler<RuntimeStatusEvent> runtimeStatusEventHandler, - final @Parameter(RuntimeParameters.NodeDescriptorHandler.class) EventHandler<NodeDescriptorEvent> nodeDescriptorEventHandler, - final @Parameter(RuntimeParameters.ResourceStatusHandler.class) EventHandler<ResourceStatusEvent> resourceStatusHandlerEventHandler) { + REEFEventHandlers(@Parameter(RuntimeParameters.ResourceAllocationHandler.class) final EventHandler<ResourceAllocationEvent> resourceAllocationEventHandler, + @Parameter(RuntimeParameters.RuntimeStatusHandler.class) final EventHandler<RuntimeStatusEvent> runtimeStatusEventHandler, + @Parameter(RuntimeParameters.NodeDescriptorHandler.class) final EventHandler<NodeDescriptorEvent> nodeDescriptorEventHandler, + @Parameter(RuntimeParameters.ResourceStatusHandler.class) final EventHandler<ResourceStatusEvent> resourceStatusHandlerEventHandler) { this.resourceAllocationEventHandler = resourceAllocationEventHandler; this.runtimeStatusEventHandler = runtimeStatusEventHandler; this.nodeDescriptorEventHandler = nodeDescriptorEventHandler; http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/driver/REEFScheduler.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/driver/REEFScheduler.java b/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/driver/REEFScheduler.java index 020f388..4a0136a 100644 --- a/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/driver/REEFScheduler.java +++ b/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/driver/REEFScheduler.java @@ -118,8 +118,8 @@ final class REEFScheduler implements Scheduler { final REEFFileNames fileNames, final EStage<SchedulerDriver> schedulerDriverEStage, final ClasspathProvider classpath, - final @Parameter(JobIdentifier.class) String jobIdentifier, - final @Parameter(MesosMasterIp.class) String masterIp) { + @Parameter(JobIdentifier.class) final String jobIdentifier, + @Parameter(MesosMasterIp.class) final String masterIp) { this.mesosRemoteManager = mesosRemoteManager; this.reefEventHandlers = reefEventHandlers; this.executors = executors; http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/evaluator/REEFExecutor.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/evaluator/REEFExecutor.java b/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/evaluator/REEFExecutor.java index 81d52fe..c634fc3 100644 --- a/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/evaluator/REEFExecutor.java +++ b/lang/java/reef-runtime-mesos/src/main/java/org/apache/reef/runtime/mesos/evaluator/REEFExecutor.java @@ -57,7 +57,7 @@ import java.util.logging.Level; import java.util.logging.Logger; public final class REEFExecutor implements Executor { - private final static Logger LOG = Logger.getLogger(REEFExecutor.class.getName()); + private static final Logger LOG = Logger.getLogger(REEFExecutor.class.getName()); private final MesosExecutorDriver mesosExecutorDriver; private final MesosRemoteManager mesosRemoteManager; @@ -72,7 +72,7 @@ public final class REEFExecutor implements Executor { REEFExecutor(final EvaluatorControlHandler evaluatorControlHandler, final MesosRemoteManager mesosRemoteManager, final REEFFileNames fileNames, - final @Parameter(MesosExecutorId.class) String mesosExecutorId) { + @Parameter(MesosExecutorId.class) final String mesosExecutorId) { this.mesosRemoteManager = mesosRemoteManager; this.mesosRemoteManager.registerHandler(EvaluatorControl.class, evaluatorControlHandler); this.mesosExecutorDriver = new MesosExecutorDriver(this); http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/client/YarnJobSubmissionHandler.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/client/YarnJobSubmissionHandler.java b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/client/YarnJobSubmissionHandler.java index d340448..eaa960d 100644 --- a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/client/YarnJobSubmissionHandler.java +++ b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/client/YarnJobSubmissionHandler.java @@ -69,7 +69,7 @@ final class YarnJobSubmissionHandler implements JobSubmissionHandler { final ClasspathProvider classpath, final ConfigurationSerializer configurationSerializer, final JobUploader uploader, - final @Parameter(JVMHeapSlack.class) double jvmSlack) throws IOException { + @Parameter(JVMHeapSlack.class) final double jvmSlack) throws IOException { this.yarnConfiguration = yarnConfiguration; this.jobJarMaker = jobJarMaker; http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/EvaluatorSetupHelper.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/EvaluatorSetupHelper.java b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/EvaluatorSetupHelper.java index 30cd69f..435ee2b 100644 --- a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/EvaluatorSetupHelper.java +++ b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/EvaluatorSetupHelper.java @@ -61,7 +61,7 @@ final class EvaluatorSetupHelper { final REEFFileNames fileNames, final ConfigurationSerializer configurationSerializer, final TempFileCreator tempFileCreator, - final @Parameter(DeleteTempFiles.class) boolean deleteTempFiles, + @Parameter(DeleteTempFiles.class) final boolean deleteTempFiles, final UploaderToJobFolder uploader, final GlobalJarUploader globalJarUploader) throws IOException { this.tempFileCreator = tempFileCreator; http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/REEFEventHandlers.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/REEFEventHandlers.java b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/REEFEventHandlers.java index 195be3f..84757b5 100644 --- a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/REEFEventHandlers.java +++ b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/REEFEventHandlers.java @@ -41,10 +41,10 @@ final class REEFEventHandlers implements AutoCloseable { private final EventHandler<NodeDescriptorEvent> nodeDescriptorEventHandler; @Inject - REEFEventHandlers(final @Parameter(RuntimeParameters.NodeDescriptorHandler.class) EventHandler<NodeDescriptorEvent> nodeDescriptorEventHandler, - final @Parameter(RuntimeParameters.RuntimeStatusHandler.class) EventHandler<RuntimeStatusEvent> runtimeStatusProtoEventHandler, - final @Parameter(RuntimeParameters.ResourceAllocationHandler.class) EventHandler<ResourceAllocationEvent> resourceAllocationHandler, - final @Parameter(RuntimeParameters.ResourceStatusHandler.class) EventHandler<ResourceStatusEvent> resourceStatusHandler) { + REEFEventHandlers(@Parameter(RuntimeParameters.NodeDescriptorHandler.class) final EventHandler<NodeDescriptorEvent> nodeDescriptorEventHandler, + @Parameter(RuntimeParameters.RuntimeStatusHandler.class) final EventHandler<RuntimeStatusEvent> runtimeStatusProtoEventHandler, + @Parameter(RuntimeParameters.ResourceAllocationHandler.class) final EventHandler<ResourceAllocationEvent> resourceAllocationHandler, + @Parameter(RuntimeParameters.ResourceStatusHandler.class) final EventHandler<ResourceStatusEvent> resourceStatusHandler) { this.resourceAllocationHandler = resourceAllocationHandler; this.resourceStatusHandler = resourceStatusHandler; this.runtimeStatusHandler = runtimeStatusProtoEventHandler; http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/UploaderToJobfolder.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/UploaderToJobfolder.java b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/UploaderToJobfolder.java index 362f286..c6d8291 100644 --- a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/UploaderToJobfolder.java +++ b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/UploaderToJobfolder.java @@ -53,7 +53,7 @@ final class UploaderToJobFolder { private final FileSystem fileSystem; @Inject - UploaderToJobFolder(final @Parameter(JobSubmissionDirectory.class) String jobSubmissionDirectory, + UploaderToJobFolder(@Parameter(JobSubmissionDirectory.class) final String jobSubmissionDirectory, final YarnConfiguration yarnConfiguration) throws IOException { this.jobSubmissionDirectory = jobSubmissionDirectory; this.fileSystem = FileSystem.get(yarnConfiguration); http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/YARNResourceLaunchHandler.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/YARNResourceLaunchHandler.java b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/YARNResourceLaunchHandler.java index 4be5d60..d52f835 100644 --- a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/YARNResourceLaunchHandler.java +++ b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/YARNResourceLaunchHandler.java @@ -55,7 +55,7 @@ public final class YARNResourceLaunchHandler implements ResourceLaunchHandler { final InjectionFuture<YarnContainerManager> yarnContainerManager, final EvaluatorSetupHelper evaluatorSetupHelper, final REEFFileNames filenames, - final @Parameter(JVMHeapSlack.class) double jvmHeapSlack) { + @Parameter(JVMHeapSlack.class) final double jvmHeapSlack) { this.jvmHeapFactor = 1.0 - jvmHeapSlack; LOG.log(Level.FINEST, "Instantiating 'YARNResourceLaunchHandler'"); this.containers = containers; http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/YarnContainerManager.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/YarnContainerManager.java b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/YarnContainerManager.java index 5aeddea..45ea193 100644 --- a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/YarnContainerManager.java +++ b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/YarnContainerManager.java @@ -88,7 +88,7 @@ final class YarnContainerManager @Inject YarnContainerManager( final YarnConfiguration yarnConf, - final @Parameter(YarnHeartbeatPeriod.class) int yarnRMHeartbeatPeriod, + @Parameter(YarnHeartbeatPeriod.class) final int yarnRMHeartbeatPeriod, final REEFEventHandlers reefEventHandlers, final Containers containers, final ApplicationMasterRegistration registration, http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/CommandLine.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/CommandLine.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/CommandLine.java index 7fec4f6..07e35cc 100644 --- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/CommandLine.java +++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/CommandLine.java @@ -121,7 +121,7 @@ public final class CommandLine { */ @SafeVarargs @SuppressWarnings("checkstyle:redundantmodifier") - final public <T> CommandLine processCommandLine( + public final <T> CommandLine processCommandLine( final String[] args, Class<? extends Name<?>>... argClasses) throws IOException, BindException { http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationModuleBuilder.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationModuleBuilder.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationModuleBuilder.java index 6d58f0a..25cbe71 100644 --- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationModuleBuilder.java +++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationModuleBuilder.java @@ -37,9 +37,9 @@ import java.util.Set; public abstract class ConfigurationModuleBuilder { - private final static Set<Class<?>> paramBlacklist = new MonotonicHashSet<Class<?>>( + private static final Set<Class<?>> paramBlacklist = new MonotonicHashSet<Class<?>>( Param.class, Impl.class); - private final static Set<Class<?>> paramTypes = new MonotonicHashSet<Class<?>>( + private static final Set<Class<?>> paramTypes = new MonotonicHashSet<Class<?>>( RequiredImpl.class, OptionalImpl.class, RequiredParameter.class, OptionalParameter.class); final JavaConfigurationBuilder b = Tang.Factory.getTang() http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/ConfigurationBuilderImpl.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/ConfigurationBuilderImpl.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/ConfigurationBuilderImpl.java index 999e3dd..6a5ad70 100644 --- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/ConfigurationBuilderImpl.java +++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/ConfigurationBuilderImpl.java @@ -35,8 +35,8 @@ import java.util.Map.Entry; import java.util.Set; public class ConfigurationBuilderImpl implements ConfigurationBuilder { - public final static String IMPORT = "import"; - public final static String INIT = "<init>"; + public static final String IMPORT = "import"; + public static final String INIT = "<init>"; final TracingMonotonicMap<ClassNode<?>, ClassNode<?>> boundImpls = new TracingMonotonicTreeMap<>(); final TracingMonotonicMap<ClassNode<?>, ClassNode<? extends ExternalConstructor<?>>> boundConstructors = new TracingMonotonicTreeMap<>(); final Map<NamedParameterNode<?>, String> namedParameters = new TracingMonotonicTreeMap<>(); http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/Constructor.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/Constructor.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/Constructor.java index 099f207..27f8d1f 100644 --- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/Constructor.java +++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/Constructor.java @@ -23,7 +23,7 @@ import org.apache.reef.tang.types.ConstructorDef; import java.util.*; -final public class Constructor<T> extends InjectionPlan<T> { +public final class Constructor<T> extends InjectionPlan<T> { final ConstructorDef<T> constructor; final InjectionPlan<?>[] args; http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/InjectionPlan.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/InjectionPlan.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/InjectionPlan.java index 47e1f8a..d13750a 100644 --- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/InjectionPlan.java +++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/InjectionPlan.java @@ -61,9 +61,9 @@ public abstract class InjectionPlan<T> implements Traversable<InjectionPlan<?>> return getNumAlternatives() > 0; } - abstract public boolean isAmbiguous(); + public abstract boolean isAmbiguous(); - abstract public boolean isInjectable(); + public abstract boolean isInjectable(); protected void pad(StringBuffer sb, int n) { for (int i = 0; i < n; i++) { http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/Subplan.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/Subplan.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/Subplan.java index 71ca713..3f17a1a 100644 --- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/Subplan.java +++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/Subplan.java @@ -22,7 +22,7 @@ import org.apache.reef.tang.types.Node; import java.util.*; -final public class Subplan<T> extends InjectionPlan<T> { +public final class Subplan<T> extends InjectionPlan<T> { final InjectionPlan<? extends T>[] alternatives; final int numAlternatives; final int selectedIndex; http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/java/JavaInstance.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/java/JavaInstance.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/java/JavaInstance.java index 7080fe4..9bac12d 100644 --- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/java/JavaInstance.java +++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/java/JavaInstance.java @@ -21,7 +21,7 @@ package org.apache.reef.tang.implementation.java; import org.apache.reef.tang.implementation.InjectionPlan; import org.apache.reef.tang.types.Node; -final public class JavaInstance<T> extends InjectionPlan<T> { +public final class JavaInstance<T> extends InjectionPlan<T> { final T instance; public JavaInstance(Node name, T instance) { http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/ReflectionUtilities.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/ReflectionUtilities.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/ReflectionUtilities.java index ae77ff2..bf82216 100644 --- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/ReflectionUtilities.java +++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/ReflectionUtilities.java @@ -31,11 +31,11 @@ public class ReflectionUtilities { /** * This is used to split Java classnames. Currently, we split on . and on $ */ - public final static String regexp = "[\\.\\$]"; + public static final String regexp = "[\\.\\$]"; /** * A map from numeric classes to the number of bits used by their representations. */ - private final static Map<Class<?>, Integer> sizeof = new HashMap<>(); + private static final Map<Class<?>, Integer> sizeof = new HashMap<>(); static { sizeof.put(Byte.class, Byte.SIZE); @@ -247,7 +247,7 @@ public class ReflectionUtilities { * @return The class implemented by the interface, or null(?) if the instantiation was not generic. * @throws IllegalArgumentException if clazz does not directly implement iface. */ - static public Type getInterfaceTarget(final Class<?> iface, final Type type) throws IllegalArgumentException { + public static Type getInterfaceTarget(final Class<?> iface, final Type type) throws IllegalArgumentException { if (type instanceof ParameterizedType) { final ParameterizedType pt = (ParameterizedType) type; if (iface.isAssignableFrom((Class<?>) pt.getRawType())) { @@ -292,7 +292,7 @@ public class ReflectionUtilities { * @return T if clazz implements Name<T>, null otherwise * @throws org.apache.reef.tang.exceptions.BindException If clazz's definition incorrectly uses Name or @NamedParameter */ - static public Type getNamedParameterTargetOrNull(Class<?> clazz) + public static Type getNamedParameterTargetOrNull(Class<?> clazz) throws ClassHierarchyException { Annotation npAnnotation = clazz.getAnnotation(NamedParameter.class); boolean hasSuperClass = (clazz.getSuperclass() != Object.class); http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/Tint.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/Tint.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/Tint.java index c559761..30e0589 100644 --- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/Tint.java +++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/Tint.java @@ -51,9 +51,9 @@ import java.util.Set; import java.util.TreeSet; public class Tint { - final private static String SETTERS = "setters"; - final private static String USES = "uses"; - final private static String FULLNAME = "fullName"; + private static final String SETTERS = "setters"; + private static final String USES = "uses"; + private static final String FULLNAME = "fullName"; final JavaClassHierarchy ch; final Map<Field, ConfigurationModule> modules = new MonotonicHashMap<>(); final MonotonicMultiMap<String, String> setters = new MonotonicMultiMap<>(); http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-tests/src/main/java/org/apache/reef/tests/evaluatorreuse/EvaluatorReuseTestDriver.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-tests/src/main/java/org/apache/reef/tests/evaluatorreuse/EvaluatorReuseTestDriver.java b/lang/java/reef-tests/src/main/java/org/apache/reef/tests/evaluatorreuse/EvaluatorReuseTestDriver.java index 37eac18..9991125 100644 --- a/lang/java/reef-tests/src/main/java/org/apache/reef/tests/evaluatorreuse/EvaluatorReuseTestDriver.java +++ b/lang/java/reef-tests/src/main/java/org/apache/reef/tests/evaluatorreuse/EvaluatorReuseTestDriver.java @@ -50,7 +50,7 @@ final class EvaluatorReuseTestDriver { private String lastMessage = null; @Inject - EvaluatorReuseTestDriver(final @Parameter(NumberOfIterations.class) int n, + EvaluatorReuseTestDriver(@Parameter(NumberOfIterations.class) final int n, final JobMessageObserver client) { this.numberOfIterations = n; this.client = client; http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-tests/src/main/java/org/apache/reef/tests/fail/driver/FailDriver.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-tests/src/main/java/org/apache/reef/tests/fail/driver/FailDriver.java b/lang/java/reef-tests/src/main/java/org/apache/reef/tests/fail/driver/FailDriver.java index 33cf7e8..27038f1 100644 --- a/lang/java/reef-tests/src/main/java/org/apache/reef/tests/fail/driver/FailDriver.java +++ b/lang/java/reef-tests/src/main/java/org/apache/reef/tests/fail/driver/FailDriver.java @@ -83,7 +83,7 @@ public final class FailDriver { private transient DriverState state = DriverState.INIT; @Inject - public FailDriver(final @Parameter(FailMsgClassName.class) String failMsgClassName, + public FailDriver(@Parameter(FailMsgClassName.class) final String failMsgClassName, final EvaluatorRequestor requestor, final Clock clock) throws ClassNotFoundException { this.failMsgClass = ClassLoader.getSystemClassLoader().loadClass(failMsgClassName); http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-tests/src/main/java/org/apache/reef/tests/fail/task/Driver.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-tests/src/main/java/org/apache/reef/tests/fail/task/Driver.java b/lang/java/reef-tests/src/main/java/org/apache/reef/tests/fail/task/Driver.java index 60fceda..ebc85fa 100644 --- a/lang/java/reef-tests/src/main/java/org/apache/reef/tests/fail/task/Driver.java +++ b/lang/java/reef-tests/src/main/java/org/apache/reef/tests/fail/task/Driver.java @@ -49,7 +49,7 @@ public final class Driver { private transient String taskId; @Inject - public Driver(final @Parameter(FailTaskName.class) String failTaskName, + public Driver(@Parameter(FailTaskName.class) final String failTaskName, final EvaluatorRequestor requestor) { this.failTaskName = failTaskName; this.requestor = requestor; http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/WakeConfiguration.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/WakeConfiguration.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/WakeConfiguration.java index 03120a5..57d817a 100644 --- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/WakeConfiguration.java +++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/WakeConfiguration.java @@ -37,10 +37,10 @@ import java.util.logging.Logger; * Wake parameter configuration. */ public final class WakeConfiguration { - private final static Logger LOG = Logger.getLogger(WakeConfiguration.class.getName()); + private static final Logger LOG = Logger.getLogger(WakeConfiguration.class.getName()); @Inject - public WakeConfiguration(final @Parameter(FileName.class) String confFileName) { + public WakeConfiguration(@Parameter(FileName.class) final String confFileName) { if (confFileName.equals("")) { LOG.log(Level.WARNING, "The Wake configuration file is not specified."); } else { @@ -57,6 +57,6 @@ public final class WakeConfiguration { } @NamedParameter(doc = "Configuration file name", default_value = "") - public final static class FileName implements Name<String> { + public static final class FileName implements Name<String> { } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/WakeParameters.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/WakeParameters.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/WakeParameters.java index a79980d..9599035 100644 --- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/WakeParameters.java +++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/WakeParameters.java @@ -26,21 +26,21 @@ import org.apache.reef.tang.annotations.NamedParameter; */ public final class WakeParameters { - public final static int MAX_FRAME_LENGTH = 1 * 1024 * 1024; + public static final int MAX_FRAME_LENGTH = 1 * 1024 * 1024; - public final static long EXECUTOR_SHUTDOWN_TIMEOUT = 1000; + public static final long EXECUTOR_SHUTDOWN_TIMEOUT = 1000; - public final static long REMOTE_EXECUTOR_SHUTDOWN_TIMEOUT = 10000; + public static final long REMOTE_EXECUTOR_SHUTDOWN_TIMEOUT = 10000; @NamedParameter(doc = "Maximum frame length unit", default_value = "" + MAX_FRAME_LENGTH) - public final static class MaxFrameLength implements Name<Integer> { + public static final class MaxFrameLength implements Name<Integer> { } @NamedParameter(doc = "Executor shutdown timeout", default_value = "" + EXECUTOR_SHUTDOWN_TIMEOUT) - public final static class ExecutorShutdownTimeout implements Name<Integer> { + public static final class ExecutorShutdownTimeout implements Name<Integer> { } @NamedParameter(doc = "Remote send timeout", default_value = "" + REMOTE_EXECUTOR_SHUTDOWN_TIMEOUT) - public final static class RemoteSendTimeout implements Name<Integer> { + public static final class RemoteSendTimeout implements Name<Integer> { } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/IndependentIterationsThreadPoolStage.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/IndependentIterationsThreadPoolStage.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/IndependentIterationsThreadPoolStage.java index 530fda5..46d6191 100644 --- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/IndependentIterationsThreadPoolStage.java +++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/IndependentIterationsThreadPoolStage.java @@ -37,7 +37,7 @@ import java.util.logging.Logger; */ public class IndependentIterationsThreadPoolStage<T> extends AbstractEStage<List<T>> { - final private int granularity; + private final int granularity; private EventHandler<T> handler; private ExecutorService executor; http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/SingleThreadStage.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/SingleThreadStage.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/SingleThreadStage.java index ea66a83..6bd0455 100644 --- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/SingleThreadStage.java +++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/SingleThreadStage.java @@ -51,8 +51,8 @@ public final class SingleThreadStage<T> extends AbstractEStage<T> { * @param capacity the queue capacity */ @Inject - public SingleThreadStage(final @Parameter(StageHandler.class) EventHandler<T> handler, - final @Parameter(Capacity.class) int capacity) { + public SingleThreadStage(@Parameter(StageHandler.class) final EventHandler<T> handler, + @Parameter(Capacity.class) final int capacity) { this(handler.getClass().getName(), handler, capacity); } @@ -64,9 +64,9 @@ public final class SingleThreadStage<T> extends AbstractEStage<T> { * @param capacity the queue capacity */ @Inject - public SingleThreadStage(final @Parameter(StageName.class) String name, - final @Parameter(StageHandler.class) EventHandler<T> handler, - final @Parameter(Capacity.class) int capacity) { + public SingleThreadStage(@Parameter(StageName.class) final String name, + @Parameter(StageHandler.class) final EventHandler<T> handler, + @Parameter(Capacity.class) final int capacity) { super(name); queue = new ArrayBlockingQueue<T>(capacity); interrupted = new AtomicBoolean(false); http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/2b374dfa/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/SyncStage.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/SyncStage.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/SyncStage.java index 72913cb..547ab7d 100644 --- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/SyncStage.java +++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/SyncStage.java @@ -47,7 +47,7 @@ public final class SyncStage<T> extends AbstractEStage<T> { * @param handler the event handler */ @Inject - public SyncStage(final @Parameter(StageHandler.class) EventHandler<T> handler) { + public SyncStage(@Parameter(StageHandler.class) final EventHandler<T> handler) { this(handler.getClass().getName(), handler, null); } @@ -58,8 +58,8 @@ public final class SyncStage<T> extends AbstractEStage<T> { * @name name the stage name */ @Inject - public SyncStage(final @Parameter(StageName.class) String name, - final @Parameter(StageHandler.class) EventHandler<T> handler) { + public SyncStage(@Parameter(StageName.class) final String name, + @Parameter(StageHandler.class) final EventHandler<T> handler) { this(name, handler, null); } @@ -71,9 +71,9 @@ public final class SyncStage<T> extends AbstractEStage<T> { * @name name the stage name */ @Inject - public SyncStage(final @Parameter(StageName.class) String name, - final @Parameter(StageHandler.class) EventHandler<T> handler, - final @Parameter(ErrorHandler.class) EventHandler<Throwable> errorHandler) { + public SyncStage(@Parameter(StageName.class) final String name, + @Parameter(StageHandler.class) final EventHandler<T> handler, + @Parameter(ErrorHandler.class) final EventHandler<Throwable> errorHandler) { super(name); this.handler = handler; this.errorHandler = errorHandler;
