Repository: incubator-reef Updated Branches: refs/heads/master ff9226613 -> b459aafd8
[REEF-397]: Fix violations of FinalClass and HideUtilityClassConstructor checkstyles This addressed the issue by * declaring classes as final when required by FinalClass check * adding private constructors to utility classes * suppressing HideUtilityClassConstructor warnings for classes which produced false positives JIRA: [REEF-397](https://issues.apache.org/jira/browse/REEF-397) Pull Request: This closes #239 Project: http://git-wip-us.apache.org/repos/asf/incubator-reef/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-reef/commit/b459aafd Tree: http://git-wip-us.apache.org/repos/asf/incubator-reef/tree/b459aafd Diff: http://git-wip-us.apache.org/repos/asf/incubator-reef/diff/b459aafd Branch: refs/heads/master Commit: b459aafd8f729b2db4e1de67ed8672d7ebe8615b Parents: ff92266 Author: Mariia Mykhailova <[email protected]> Authored: Tue Jun 23 15:34:49 2015 -0700 Committer: Markus Weimer <[email protected]> Committed: Tue Jun 23 18:13:50 2015 -0700 ---------------------------------------------------------------------- .../main/java/org/apache/reef/bridge/client/Constants.java | 6 ++++++ .../apache/reef/bridge/client/YarnJobSubmissionClient.java | 1 + .../main/java/org/apache/reef/javabridge/NativeInterop.java | 8 +++++++- .../src/main/java/org/apache/reef/javabridge/Utilities.java | 8 +++++++- .../org/apache/reef/driver/evaluator/EvaluatorRequest.java | 2 +- .../reef/runtime/common/client/parameters/ClientPresent.java | 6 ++++++ .../common/driver/parameters/ClientRemoteIdentifier.java | 6 ++++++ .../reef/runtime/common/evaluator/HeartBeatManager.java | 2 +- .../common/launch/parameters/ClockConfigurationPath.java | 6 ++++++ .../runtime/common/launch/parameters/ErrorHandlerRID.java | 5 +++++ .../reef/runtime/common/launch/parameters/LaunchID.java | 6 ++++++ .../src/main/java/org/apache/reef/util/BuilderUtils.java | 6 ++++++ .../src/main/java/org/apache/reef/util/CommandUtils.java | 6 ++++++ .../src/main/java/org/apache/reef/util/EnvironmentUtils.java | 6 ++++++ .../main/java/org/apache/reef/util/logging/LogParser.java | 2 +- .../org/apache/reef/util/logging/LoggingScopeFactory.java | 2 +- .../java/org/apache/reef/examples/helloCLR/HelloCLR.java | 6 ++++++ .../java/org/apache/reef/examples/hello/HelloHDInsight.java | 8 +++++++- .../apache/reef/examples/data/loading/DataLoadingREEF.java | 8 +++++++- .../java/org/apache/reef/examples/group/bgd/BGDLocal.java | 8 +++++++- .../java/org/apache/reef/examples/group/bgd/BGDYarn.java | 8 +++++++- .../reef/examples/group/bgd/utils/SubConfiguration.java | 8 +++++++- .../apache/reef/examples/group/broadcast/BroadcastREEF.java | 8 +++++++- .../main/java/org/apache/reef/examples/hello/HelloREEF.java | 6 ++++++ .../java/org/apache/reef/examples/hello/HelloREEFMesos.java | 8 +++++++- .../org/apache/reef/examples/hello/HelloREEFNoClient.java | 6 ++++++ .../java/org/apache/reef/examples/hello/HelloReefYarn.java | 6 ++++++ .../org/apache/reef/examples/hellohttp/HelloREEFHttp.java | 6 ++++++ .../apache/reef/examples/hellohttp/HelloREEFHttpYarn.java | 8 +++++++- .../apache/reef/examples/hellohttp/HttpShellJobDriver.java | 1 + .../java/org/apache/reef/examples/library/ShellTask.java | 2 +- .../main/java/org/apache/reef/examples/pool/SleepTask.java | 2 +- .../org/apache/reef/examples/scheduler/SchedulerREEF.java | 6 ++++++ .../apache/reef/examples/scheduler/SchedulerREEFYarn.java | 6 ++++++ .../io/data/loading/impl/EvaluatorRequestSerializer.java | 8 +++++++- .../apache/reef/io/data/loading/impl/WritableSerializer.java | 7 ++++++- .../reef/io/network/group/impl/driver/GroupCommService.java | 1 + .../org/apache/reef/io/network/group/impl/utils/Utils.java | 8 +++++++- .../apache/reef/io/network/naming/NamingCodecFactory.java | 8 +++++++- .../src/main/java/org/apache/reef/io/network/util/Utils.java | 8 +++++++- .../java/org/apache/reef/poison/params/CrashProbability.java | 6 ++++++ .../java/org/apache/reef/poison/params/CrashTimeout.java | 6 ++++++ .../reef/runtime/local/client/parameters/RootFolder.java | 8 +++++++- .../tang/src/main/java/org/apache/reef/tang/Tang.java | 7 ++++++- .../java/org/apache/reef/tang/formats/ConfigurationFile.java | 8 +++++++- .../reef/tang/implementation/java/JavaNodeFactory.java | 7 ++++++- .../java/org/apache/reef/tang/util/ReflectionUtilities.java | 8 +++++++- .../java/org/apache/reef/tests/fail/driver/FailClient.java | 6 ++++++ .../main/java/org/apache/reef/tests/fail/task/Client.java | 6 ++++++ .../java/org/apache/reef/tests/library/tasks/NoopTask.java | 2 +- .../java/org/apache/reef/tests/yarn/failure/FailureREEF.java | 6 ++++++ .../main/java/org/apache/reef/util/HadoopEnvironment.java | 2 +- .../src/main/java/org/apache/reef/wake/WakeParameters.java | 6 ++++++ .../main/java/org/apache/reef/wake/impl/LoggingUtils.java | 8 +++++++- .../java/org/apache/reef/wake/impl/MergingEventHandler.java | 2 +- .../apache/reef/wake/impl/MissingStartHandlerHandler.java | 2 +- .../java/org/apache/reef/wake/metrics/EWMAParameters.java | 8 +++++++- .../src/main/java/org/apache/reef/wake/remote/NetUtils.java | 6 ++++++ .../reef/wake/remote/impl/DefaultRemoteManagerFactory.java | 2 +- .../reef/wake/remote/ports/parameters/TcpPortRangeBegin.java | 8 +++++++- .../reef/wake/remote/ports/parameters/TcpPortRangeCount.java | 8 +++++++- .../wake/remote/ports/parameters/TcpPortRangeTryCount.java | 8 +++++++- 62 files changed, 323 insertions(+), 36 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/Constants.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/Constants.java b/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/Constants.java index 6b3c8cc..8679c20 100644 --- a/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/Constants.java +++ b/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/Constants.java @@ -89,4 +89,10 @@ public final class Constants { HTTP_SERVER_CONFIGURATION, NAME_SERVER_CONFIGURATION ); + + /** + * Empty private constructor to prohibit instantiation of utility class. + */ + private Constants() { + } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/YarnJobSubmissionClient.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/YarnJobSubmissionClient.java b/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/YarnJobSubmissionClient.java index 0510a38..6f9b922 100644 --- a/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/YarnJobSubmissionClient.java +++ b/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/YarnJobSubmissionClient.java @@ -49,6 +49,7 @@ import java.util.logging.Logger; /** * The Java-side of the C# YARN Job Submission API. */ +@SuppressWarnings("checkstyle:hideutilityclassconstructor") public final class YarnJobSubmissionClient { private static final Logger LOG = Logger.getLogger(YarnJobSubmissionClient.class.getName()); http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/NativeInterop.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/NativeInterop.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/NativeInterop.java index b0d4b09..d27272f 100644 --- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/NativeInterop.java +++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/NativeInterop.java @@ -20,7 +20,7 @@ package org.apache.reef.javabridge; import java.util.HashMap; -public class NativeInterop { +public final class NativeInterop { public static final String CLASS_HIERARCHY_FILENAME = "clrClassHierarchy.bin"; public static final String GLOBAL_LIBRARIES_FILENAME = "userSuppliedGlobalLibraries.txt"; public static final String AllocatedEvaluatorKey = "AllocatedEvaluator"; @@ -158,4 +158,10 @@ public class NativeInterop { long handle, RunningTaskBridge runningTaskBridge ); + + /** + * Empty private constructor to prohibit instantiation of utility class. + */ + private NativeInterop() { + } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/Utilities.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/Utilities.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/Utilities.java index 93b6903..82d94a9 100644 --- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/Utilities.java +++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/Utilities.java @@ -31,7 +31,7 @@ import java.nio.file.Files; import java.nio.file.Path; import java.nio.file.Paths; -public class Utilities { +public final class Utilities { public static ClassHierarchy loadClassHierarchy(String classHierarchyFile) { Path p = Paths.get(classHierarchyFile); if (!Files.exists(p)) { @@ -54,4 +54,10 @@ public class Utilities { InetSocketAddress socketAddress = evaluatorDescriptor.getNodeDescriptor().getInetSocketAddress(); return "IP=" + socketAddress.getAddress() + ", Port=" + socketAddress.getPort() + ", HostName=" + socketAddress.getHostName() + ", Memory=" + evaluatorDescriptor.getMemory() + ", Core=" + evaluatorDescriptor.getNumberOfCores(); } + + /** + * Empty private constructor to prohibit instantiation of utility class. + */ + private Utilities() { + } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/EvaluatorRequest.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/EvaluatorRequest.java b/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/EvaluatorRequest.java index 5f1db52..878edfd 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/EvaluatorRequest.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/EvaluatorRequest.java @@ -100,7 +100,7 @@ public final class EvaluatorRequest { /** * {@link EvaluatorRequest}s are build using this Builder. */ - public static class Builder implements org.apache.reef.util.Builder<EvaluatorRequest> { + public static final class Builder implements org.apache.reef.util.Builder<EvaluatorRequest> { private int n = 1; private ResourceCatalog.Descriptor descriptor = null; http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/parameters/ClientPresent.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/parameters/ClientPresent.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/parameters/ClientPresent.java index 0910e18..2fb1f5a 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/parameters/ClientPresent.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/parameters/ClientPresent.java @@ -30,4 +30,10 @@ import org.apache.reef.tang.annotations.NamedParameter; public final class ClientPresent implements Name<String> { public static final String YES = "YES"; public static final String NO = "NO"; + + /** + * Empty private constructor to prohibit instantiation of utility class. + */ + private ClientPresent() { + } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/parameters/ClientRemoteIdentifier.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/parameters/ClientRemoteIdentifier.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/parameters/ClientRemoteIdentifier.java index 3f8e1d4..6ed8c1b 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/parameters/ClientRemoteIdentifier.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/parameters/ClientRemoteIdentifier.java @@ -31,4 +31,10 @@ public final class ClientRemoteIdentifier implements Name<String> { * Indicates that there is no Client. */ public static final String NONE = ErrorHandlerRID.NONE; + + /** + * Empty private constructor to prohibit instantiation of utility class. + */ + private ClientRemoteIdentifier() { + } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/HeartBeatManager.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/HeartBeatManager.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/HeartBeatManager.java index 5bb8d4e..8b6127e 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/HeartBeatManager.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/HeartBeatManager.java @@ -39,7 +39,7 @@ import java.util.logging.Level; import java.util.logging.Logger; @Unit -public class HeartBeatManager { +public final class HeartBeatManager { private static final Logger LOG = Logger.getLogger(HeartBeatManager.class.getName()); http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/parameters/ClockConfigurationPath.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/parameters/ClockConfigurationPath.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/parameters/ClockConfigurationPath.java index eae79c6..d2e578a 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/parameters/ClockConfigurationPath.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/parameters/ClockConfigurationPath.java @@ -27,4 +27,10 @@ import org.apache.reef.tang.annotations.NamedParameter; @NamedParameter(doc = "The path to process configuration.", short_name = ClockConfigurationPath.SHORT_NAME) public final class ClockConfigurationPath implements Name<String> { public static final String SHORT_NAME = "runtime_configuration"; + + /** + * Empty private constructor to prohibit instantiation of utility class. + */ + private ClockConfigurationPath() { + } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/parameters/ErrorHandlerRID.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/parameters/ErrorHandlerRID.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/parameters/ErrorHandlerRID.java index 5dadd84..38aa950 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/parameters/ErrorHandlerRID.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/parameters/ErrorHandlerRID.java @@ -34,4 +34,9 @@ public final class ErrorHandlerRID implements Name<String> { */ public static final String SHORT_NAME = "error_handler_rid"; + /** + * Empty private constructor to prohibit instantiation of utility class. + */ + private ErrorHandlerRID() { + } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/parameters/LaunchID.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/parameters/LaunchID.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/parameters/LaunchID.java index d3af9c1..ae0d23f 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/parameters/LaunchID.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/parameters/LaunchID.java @@ -24,4 +24,10 @@ import org.apache.reef.tang.annotations.NamedParameter; @NamedParameter(doc = "The launch identifier.", short_name = LaunchID.SHORT_NAME) public final class LaunchID implements Name<String> { public static final String SHORT_NAME = "launch_id"; + + /** + * Empty private constructor to prohibit instantiation of utility class. + */ + private LaunchID() { + } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-common/src/main/java/org/apache/reef/util/BuilderUtils.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/util/BuilderUtils.java b/lang/java/reef-common/src/main/java/org/apache/reef/util/BuilderUtils.java index 8e39201..dc80dee 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/util/BuilderUtils.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/util/BuilderUtils.java @@ -32,4 +32,10 @@ public final class BuilderUtils { return parameter; } } + + /** + * Empty private constructor to prohibit instantiation of utility class. + */ + private BuilderUtils() { + } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-common/src/main/java/org/apache/reef/util/CommandUtils.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/util/CommandUtils.java b/lang/java/reef-common/src/main/java/org/apache/reef/util/CommandUtils.java index c8b6144..ca9bff4 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/util/CommandUtils.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/util/CommandUtils.java @@ -52,4 +52,10 @@ public final class CommandUtils { } return sb.toString(); } + + /** + * Empty private constructor to prohibit instantiation of utility class. + */ + private CommandUtils() { + } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-common/src/main/java/org/apache/reef/util/EnvironmentUtils.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/util/EnvironmentUtils.java b/lang/java/reef-common/src/main/java/org/apache/reef/util/EnvironmentUtils.java index 6a9a126..2ff1c5e 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/util/EnvironmentUtils.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/util/EnvironmentUtils.java @@ -150,4 +150,10 @@ public final class EnvironmentUtils { public static String getClassLocation(final Class<?> clazz) { return clazz.getProtectionDomain().getCodeSource().getLocation().getFile(); } + + /** + * Empty private constructor to prohibit instantiation of utility class. + */ + private EnvironmentUtils() { + } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-common/src/main/java/org/apache/reef/util/logging/LogParser.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/util/logging/LogParser.java b/lang/java/reef-common/src/main/java/org/apache/reef/util/logging/LogParser.java index 4ab23f4..80c9796 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/util/logging/LogParser.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/util/logging/LogParser.java @@ -27,7 +27,7 @@ import java.util.ArrayList; /** * Parse logs for reporting. */ -public class LogParser { +public final class LogParser { public static String[] endIndicators = { LoggingScopeImpl.EXIT_PREFIX + LoggingScopeFactory.BRIDGE_SETUP, http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-common/src/main/java/org/apache/reef/util/logging/LoggingScopeFactory.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/util/logging/LoggingScopeFactory.java b/lang/java/reef-common/src/main/java/org/apache/reef/util/logging/LoggingScopeFactory.java index 7f12db1..02772ae 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/util/logging/LoggingScopeFactory.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/util/logging/LoggingScopeFactory.java @@ -29,7 +29,7 @@ import java.util.logging.Logger; /** * Create Logging scope objects. */ -public class LoggingScopeFactory { +public final class LoggingScopeFactory { private static final Logger LOG = Logger.getLogger(LoggingScopeFactory.class.getName()); public static final String DRIVER_START = "Driver Start Handler"; http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-examples-clr/src/main/java/org/apache/reef/examples/helloCLR/HelloCLR.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-examples-clr/src/main/java/org/apache/reef/examples/helloCLR/HelloCLR.java b/lang/java/reef-examples-clr/src/main/java/org/apache/reef/examples/helloCLR/HelloCLR.java index fbc1461..da969c0 100644 --- a/lang/java/reef-examples-clr/src/main/java/org/apache/reef/examples/helloCLR/HelloCLR.java +++ b/lang/java/reef-examples-clr/src/main/java/org/apache/reef/examples/helloCLR/HelloCLR.java @@ -90,4 +90,10 @@ public final class HelloCLR { final LauncherStatus status = runHelloCLR(runtimeConfiguration, JOB_TIMEOUT, dotNetFolder); LOG.log(Level.INFO, "REEF job completed: {0}", status); } + + /** + * Empty private constructor to prohibit instantiation of utility class. + */ + private HelloCLR() { + } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-examples-hdinsight/src/main/java/org/apache/reef/examples/hello/HelloHDInsight.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-examples-hdinsight/src/main/java/org/apache/reef/examples/hello/HelloHDInsight.java b/lang/java/reef-examples-hdinsight/src/main/java/org/apache/reef/examples/hello/HelloHDInsight.java index 7e2bc9d..6a34955 100644 --- a/lang/java/reef-examples-hdinsight/src/main/java/org/apache/reef/examples/hello/HelloHDInsight.java +++ b/lang/java/reef-examples-hdinsight/src/main/java/org/apache/reef/examples/hello/HelloHDInsight.java @@ -26,8 +26,14 @@ import java.io.IOException; /** * HelloREEF running on HDInsight. */ -public class HelloHDInsight { +public final class HelloHDInsight { public static void main(final String[] args) throws InjectionException, IOException { HelloREEFNoClient.runHelloReefWithoutClient(UnsafeHDInsightRuntimeConfiguration.fromEnvironment()); } + + /** + * Empty private constructor to prohibit instantiation of utility class. + */ + private HelloHDInsight() { + } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-examples/src/main/java/org/apache/reef/examples/data/loading/DataLoadingREEF.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/data/loading/DataLoadingREEF.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/data/loading/DataLoadingREEF.java index 0d4409f..ec253a3 100644 --- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/data/loading/DataLoadingREEF.java +++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/data/loading/DataLoadingREEF.java @@ -46,7 +46,7 @@ import java.util.logging.Logger; * Client for the data loading demo app. */ @ClientSide -public class DataLoadingREEF { +public final class DataLoadingREEF { private static final Logger LOG = Logger.getLogger(DataLoadingREEF.class.getName()); @@ -129,4 +129,10 @@ public class DataLoadingREEF { @NamedParameter(short_name = "input") public static final class InputDir implements Name<String> { } + + /** + * Empty private constructor to prohibit instantiation of utility class. + */ + private DataLoadingREEF() { + } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/BGDLocal.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/BGDLocal.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/BGDLocal.java index f2d695c..85013ed 100644 --- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/BGDLocal.java +++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/BGDLocal.java @@ -29,7 +29,7 @@ import java.util.logging.Logger; /** * Runs BGD on the local runtime. */ -public class BGDLocal { +public final class BGDLocal { private static final Logger LOG = Logger.getLogger(BGDLocal.class.getName()); @@ -50,4 +50,10 @@ public class BGDLocal { LOG.log(Level.INFO, "OUT: Status = {0}", status); } + + /** + * Empty private constructor to prohibit instantiation of utility class. + */ + private BGDLocal() { + } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/BGDYarn.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/BGDYarn.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/BGDYarn.java index 868d255..e59906a 100644 --- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/BGDYarn.java +++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/BGDYarn.java @@ -29,7 +29,7 @@ import java.util.logging.Logger; /** * Runs BGD on the YARN runtime. */ -public class BGDYarn { +public final class BGDYarn { private static final Logger LOG = Logger.getLogger(BGDYarn.class.getName()); @@ -49,4 +49,10 @@ public class BGDYarn { LOG.log(Level.INFO, "OUT: Status = {0}", status); } + + /** + * Empty private constructor to prohibit instantiation of utility class. + */ + private BGDYarn() { + } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/utils/SubConfiguration.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/utils/SubConfiguration.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/utils/SubConfiguration.java index 7211760..6c97b37 100644 --- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/utils/SubConfiguration.java +++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/utils/SubConfiguration.java @@ -33,7 +33,7 @@ import org.apache.reef.tang.formats.ConfigurationSerializer; import java.util.logging.Level; import java.util.logging.Logger; -public class SubConfiguration { +public final class SubConfiguration { private static final Logger LOG = Logger.getLogger(SubConfiguration.class.getName()); @@ -70,4 +70,10 @@ public class SubConfiguration { LOG.log(Level.INFO, "OUT: Base conf:\n{0}", confSerizalizer.toString(conf)); LOG.log(Level.INFO, "OUT: Sub conf:\n{0}", confSerizalizer.toString(subConf)); } + + /** + * Empty private constructor to prohibit instantiation of utility class. + */ + private SubConfiguration() { + } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/broadcast/BroadcastREEF.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/broadcast/BroadcastREEF.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/broadcast/BroadcastREEF.java index 22b6a80..31a78ae 100644 --- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/broadcast/BroadcastREEF.java +++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/broadcast/BroadcastREEF.java @@ -43,7 +43,7 @@ import java.util.logging.Level; import java.util.logging.Logger; @ClientSide -public class BroadcastREEF { +public final class BroadcastREEF { private static final Logger LOG = Logger.getLogger(BroadcastREEF.class.getName()); private static final String MAX_NUMBER_OF_EVALUATORS = "20"; @@ -145,4 +145,10 @@ public class BroadcastREEF { final LauncherStatus state = runBGDReef(runtimeConfiguration); LOG.log(Level.INFO, "REEF job completed: {0}", state); } + + /** + * Empty private constructor to prohibit instantiation of utility class. + */ + private BroadcastREEF() { + } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloREEF.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloREEF.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloREEF.java index 30a93f6..9a9f6ac 100644 --- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloREEF.java +++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloREEF.java @@ -78,4 +78,10 @@ public final class HelloREEF { final LauncherStatus status = runHelloReef(runtimeConfiguration, JOB_TIMEOUT); LOG.log(Level.INFO, "REEF job completed: {0}", status); } + + /** + * Empty private constructor to prohibit instantiation of utility class. + */ + private HelloREEF() { + } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloREEFMesos.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloREEFMesos.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloREEFMesos.java index 20b6172..1fce55b 100644 --- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloREEFMesos.java +++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloREEFMesos.java @@ -28,7 +28,7 @@ import org.apache.reef.tang.exceptions.InjectionException; import java.util.logging.Level; import java.util.logging.Logger; -public class HelloREEFMesos { +public final class HelloREEFMesos { private static final Logger LOG = Logger.getLogger(HelloREEFMesos.class.getName()); private static Configuration getDriverConfiguration() { @@ -52,4 +52,10 @@ public class HelloREEFMesos { .run(getDriverConfiguration()); LOG.log(Level.INFO, "REEF job completed: {0}", status); } + + /** + * Empty private constructor to prohibit instantiation of utility class. + */ + private HelloREEFMesos() { + } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloREEFNoClient.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloREEFNoClient.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloREEFNoClient.java index dde35f3..dd4b656 100644 --- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloREEFNoClient.java +++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloREEFNoClient.java @@ -61,4 +61,10 @@ public final class HelloREEFNoClient { runHelloReefWithoutClient(runtimeConfiguration); LOG.log(Level.INFO, "Job Submitted"); } + + /** + * Empty private constructor to prohibit instantiation of utility class. + */ + private HelloREEFNoClient() { + } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloReefYarn.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloReefYarn.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloReefYarn.java index f5a809a..e3ef7bf 100644 --- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloReefYarn.java +++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloReefYarn.java @@ -67,4 +67,10 @@ public final class HelloReefYarn { .run(getDriverConfiguration(), JOB_TIMEOUT); LOG.log(Level.INFO, "REEF job completed: {0}", status); } + + /** + * Empty private constructor to prohibit instantiation of utility class. + */ + private HelloReefYarn() { + } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hellohttp/HelloREEFHttp.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hellohttp/HelloREEFHttp.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hellohttp/HelloREEFHttp.java index dae6dba..40e1d12 100644 --- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hellohttp/HelloREEFHttp.java +++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hellohttp/HelloREEFHttp.java @@ -114,4 +114,10 @@ public final class HelloREEFHttp { .build(); final LauncherStatus status = runHelloReef(runtimeConfiguration, HelloREEFHttp.JOB_TIMEOUT); } + + /** + * Empty private constructor to prohibit instantiation of utility class. + */ + private HelloREEFHttp() { + } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hellohttp/HelloREEFHttpYarn.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hellohttp/HelloREEFHttpYarn.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hellohttp/HelloREEFHttpYarn.java index e3297fb..579ab9c 100644 --- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hellohttp/HelloREEFHttpYarn.java +++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hellohttp/HelloREEFHttpYarn.java @@ -31,7 +31,7 @@ import java.util.logging.Logger; /** * HelloREEFHttp for running on Yarn. */ -public class HelloREEFHttpYarn { +public final class HelloREEFHttpYarn { private static final Logger LOG = Logger.getLogger(HelloREEFHttpYarn.class.getName()); @@ -49,4 +49,10 @@ public class HelloREEFHttpYarn { final LauncherStatus status = HelloREEFHttp.runHelloReef(runtimeConfiguration, HelloREEFHttp.JOB_TIMEOUT); LOG.log(Level.INFO, "REEF job completed: {0}", status); } + + /** + * Empty private constructor to prohibit instantiation of utility class. + */ + private HelloREEFHttpYarn() { + } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hellohttp/HttpShellJobDriver.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hellohttp/HttpShellJobDriver.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hellohttp/HttpShellJobDriver.java index dc53a46..f1bea77 100644 --- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hellohttp/HttpShellJobDriver.java +++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hellohttp/HttpShellJobDriver.java @@ -50,6 +50,7 @@ import java.util.logging.Logger; /** * The Driver code for the Hello REEF Http Distributed Shell Application. */ +@SuppressWarnings("checkstyle:hideutilityclassconstructor") @Unit public final class HttpShellJobDriver { http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-examples/src/main/java/org/apache/reef/examples/library/ShellTask.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/library/ShellTask.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/library/ShellTask.java index 38e7920..74fba56 100644 --- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/library/ShellTask.java +++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/library/ShellTask.java @@ -30,7 +30,7 @@ import java.util.logging.Logger; /** * Execute command, capture its stdout, and return that string to the job driver. */ -public class ShellTask implements Task { +public final class ShellTask implements Task { /** * Standard java logger. http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-examples/src/main/java/org/apache/reef/examples/pool/SleepTask.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/pool/SleepTask.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/pool/SleepTask.java index 98b3c0a..f4be2a1 100644 --- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/pool/SleepTask.java +++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/pool/SleepTask.java @@ -28,7 +28,7 @@ import java.util.logging.Logger; /** * Sleep for delay seconds and quit. */ -public class SleepTask implements Task { +public final class SleepTask implements Task { /** * Standard java logger. http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerREEF.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerREEF.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerREEF.java index 9d40c63..f173cae 100644 --- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerREEF.java +++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerREEF.java @@ -110,4 +110,10 @@ public final class SchedulerREEF { .build(); runTaskScheduler(runtimeConfiguration, args); } + + /** + * Empty private constructor to prohibit instantiation of utility class. + */ + private SchedulerREEF() { + } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerREEFYarn.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerREEFYarn.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerREEFYarn.java index 1a462e1..46048ac 100644 --- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerREEFYarn.java +++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/SchedulerREEFYarn.java @@ -43,4 +43,10 @@ public final class SchedulerREEFYarn { YarnClientConfiguration.CONF.build(); runTaskScheduler(runtimeConfiguration, args); } + + /** + * Empty private constructor to prohibit instantiation of utility class. + */ + private SchedulerREEFYarn() { + } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/EvaluatorRequestSerializer.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/EvaluatorRequestSerializer.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/EvaluatorRequestSerializer.java index 06226db..8522e4a 100644 --- a/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/EvaluatorRequestSerializer.java +++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/EvaluatorRequestSerializer.java @@ -28,7 +28,7 @@ import java.io.*; * Currently only supports number & memory * Does not take care of Resource Descriptor */ -public class EvaluatorRequestSerializer { +public final class EvaluatorRequestSerializer { public static String serialize(EvaluatorRequest request) { try (ByteArrayOutputStream baos = new ByteArrayOutputStream()) { try (DataOutputStream daos = new DataOutputStream(baos)) { @@ -60,4 +60,10 @@ public class EvaluatorRequestSerializer { throw new RuntimeException("Unable to de-serialize compute request", e); } } + + /** + * Empty private constructor to prohibit instantiation of utility class. + */ + private EvaluatorRequestSerializer() { + } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/WritableSerializer.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/WritableSerializer.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/WritableSerializer.java index ae3dbc5..d50fbf3 100644 --- a/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/WritableSerializer.java +++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/WritableSerializer.java @@ -35,7 +35,7 @@ import java.io.*; * de-serialization. However, this also needs the jobconf * to passed in while de-serialization */ -public class WritableSerializer { +public final class WritableSerializer { public static <E extends Writable> String serialize(E writable) { final WritableCodec<E> writableCodec = new WritableCodec<>(); return Base64.encodeBase64String(writableCodec.encode(writable)); @@ -90,4 +90,9 @@ public class WritableSerializer { } } + /** + * Empty private constructor to prohibit instantiation of utility class. + */ + private WritableSerializer() { + } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/driver/GroupCommService.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/driver/GroupCommService.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/driver/GroupCommService.java index 6e4e87c..cbc57d9 100644 --- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/driver/GroupCommService.java +++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/driver/GroupCommService.java @@ -41,6 +41,7 @@ import java.util.logging.Logger; /** * The Group Communication Service. */ +@SuppressWarnings("checkstyle:hideutilityclassconstructor") @Unit public class GroupCommService { http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/utils/Utils.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/utils/Utils.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/utils/Utils.java index b053c21..64efcad 100644 --- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/utils/Utils.java +++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/utils/Utils.java @@ -28,7 +28,7 @@ import java.util.Iterator; /** * */ -public class Utils { +public final class Utils { public static final byte[] EmptyByteArr = new byte[0]; @@ -77,4 +77,10 @@ public class Utils { throw new RuntimeException("Expecting exactly one GCM object inside Message but found none"); } } + + /** + * Empty private constructor to prohibit instantiation of utility class. + */ + private Utils() { + } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NamingCodecFactory.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NamingCodecFactory.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NamingCodecFactory.java index d29db1a..7fe688a 100644 --- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NamingCodecFactory.java +++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NamingCodecFactory.java @@ -29,7 +29,7 @@ import java.util.Map; /** * Factory to create naming codecs. */ -class NamingCodecFactory { +final class NamingCodecFactory { /** * Creates a codec only for lookup. @@ -79,4 +79,10 @@ class NamingCodecFactory { Codec<NamingMessage> codec = new MultiCodec<NamingMessage>(clazzToCodecMap); return codec; } + + /** + * Empty private constructor to prohibit instantiation of utility class. + */ + private NamingCodecFactory() { + } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-io/src/main/java/org/apache/reef/io/network/util/Utils.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/util/Utils.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/util/Utils.java index f389986..84936ac 100644 --- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/util/Utils.java +++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/util/Utils.java @@ -31,7 +31,7 @@ import java.util.Collections; import java.util.Comparator; import java.util.List; -public class Utils { +public final class Utils { private static final String DELIMITER = "-"; @@ -116,4 +116,10 @@ public class Utils { return GCMBuilder.build(); } + + /** + * Empty private constructor to prohibit instantiation of utility class. + */ + private Utils() { + } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-poison/src/main/java/org/apache/reef/poison/params/CrashProbability.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-poison/src/main/java/org/apache/reef/poison/params/CrashProbability.java b/lang/java/reef-poison/src/main/java/org/apache/reef/poison/params/CrashProbability.java index f1d8ea4..7ae940d 100644 --- a/lang/java/reef-poison/src/main/java/org/apache/reef/poison/params/CrashProbability.java +++ b/lang/java/reef-poison/src/main/java/org/apache/reef/poison/params/CrashProbability.java @@ -27,4 +27,10 @@ import org.apache.reef.tang.annotations.NamedParameter; @NamedParameter(doc = "the probability with which a crash will occur.", default_value = "" + CrashProbability.DEFAULT_VALUE) public final class CrashProbability implements Name<Double> { public static final double DEFAULT_VALUE = 0.1; + + /** + * Empty private constructor to prohibit instantiation of utility class. + */ + private CrashProbability() { + } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-poison/src/main/java/org/apache/reef/poison/params/CrashTimeout.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-poison/src/main/java/org/apache/reef/poison/params/CrashTimeout.java b/lang/java/reef-poison/src/main/java/org/apache/reef/poison/params/CrashTimeout.java index 42b86c1..c70ae34 100644 --- a/lang/java/reef-poison/src/main/java/org/apache/reef/poison/params/CrashTimeout.java +++ b/lang/java/reef-poison/src/main/java/org/apache/reef/poison/params/CrashTimeout.java @@ -24,4 +24,10 @@ import org.apache.reef.tang.annotations.NamedParameter; @NamedParameter(doc = "The time window (in seconds) after ContextStart in which the crash will occur", default_value = "" + CrashTimeout.DEFAULT_VALUE) public final class CrashTimeout implements Name<Integer> { public static final int DEFAULT_VALUE = 10; + + /** + * Empty private constructor to prohibit instantiation of utility class. + */ + private CrashTimeout() { + } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/parameters/RootFolder.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/parameters/RootFolder.java b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/parameters/RootFolder.java index cb35486..9dcdf35 100644 --- a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/parameters/RootFolder.java +++ b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/parameters/RootFolder.java @@ -25,6 +25,12 @@ import org.apache.reef.tang.annotations.NamedParameter; * The folder where logs etc. shall be stored. */ @NamedParameter(default_value = RootFolder.DEFAULT_VALUE, doc = "The folder where logs etc. shall be stored.") -public class RootFolder implements Name<String> { +public final class RootFolder implements Name<String> { public static final String DEFAULT_VALUE = "REEF_LOCAL_RUNTIME"; + + /** + * Empty private constructor to prohibit instantiation of utility class. + */ + private RootFolder() { + } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/Tang.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/Tang.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/Tang.java index 3f1977f..0e0a600 100644 --- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/Tang.java +++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/Tang.java @@ -143,7 +143,12 @@ public interface Tang { public static Tang getTang() { return new TangImpl(); } - } + /** + * Empty private constructor to prohibit instantiation of utility class. + */ + private Factory() { + } + } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationFile.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationFile.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationFile.java index cf1cd72..76cca62 100644 --- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationFile.java +++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationFile.java @@ -43,7 +43,7 @@ import java.util.Map.Entry; * @deprecated in Tang 0.2 Use AvroConfigurationSerializer instead. */ @Deprecated -public class ConfigurationFile { +public final class ConfigurationFile { /** * Write Configuration to the given File. @@ -250,4 +250,10 @@ public class ConfigurationFile { } return sb; } + + /** + * Empty private constructor to prohibit instantiation of utility class. + */ + private ConfigurationFile() { + } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/java/JavaNodeFactory.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/java/JavaNodeFactory.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/java/JavaNodeFactory.java index 9311e94..ee359a7 100644 --- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/java/JavaNodeFactory.java +++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/java/JavaNodeFactory.java @@ -38,7 +38,7 @@ import java.util.Collection; import java.util.List; import java.util.Set; -public class JavaNodeFactory { +public final class JavaNodeFactory { @SuppressWarnings("unchecked") static <T> ClassNodeImpl<T> createClassNode(Node parent, Class<T> clazz) throws ClassHierarchyException { @@ -330,4 +330,9 @@ public class JavaNodeFactory { args, injectable); } + /** + * Empty private constructor to prohibit instantiation of utility class. + */ + private JavaNodeFactory() { + } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/ReflectionUtilities.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/ReflectionUtilities.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/ReflectionUtilities.java index bf82216..65f2e92 100644 --- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/ReflectionUtilities.java +++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/ReflectionUtilities.java @@ -27,7 +27,7 @@ import java.lang.annotation.Annotation; import java.lang.reflect.*; import java.util.*; -public class ReflectionUtilities { +public final class ReflectionUtilities { /** * This is used to split Java classnames. Currently, we split on . and on $ */ @@ -399,4 +399,10 @@ public class ReflectionUtilities { throw new IllegalArgumentException("Can't getRawClass for " + clazz + " of unknown type " + clazz.getClass()); } } + + /** + * Empty private constructor to prohibit instantiation of utility class. + */ + private ReflectionUtilities() { + } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-tests/src/main/java/org/apache/reef/tests/fail/driver/FailClient.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-tests/src/main/java/org/apache/reef/tests/fail/driver/FailClient.java b/lang/java/reef-tests/src/main/java/org/apache/reef/tests/fail/driver/FailClient.java index 8762ec1..8e3476b 100644 --- a/lang/java/reef-tests/src/main/java/org/apache/reef/tests/fail/driver/FailClient.java +++ b/lang/java/reef-tests/src/main/java/org/apache/reef/tests/fail/driver/FailClient.java @@ -62,4 +62,10 @@ public final class FailClient { return TestDriverLauncher.getLauncher(runtimeConfig).run(cb.build(), timeOut); } + + /** + * Empty private constructor to prohibit instantiation of utility class. + */ + private FailClient() { + } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-tests/src/main/java/org/apache/reef/tests/fail/task/Client.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-tests/src/main/java/org/apache/reef/tests/fail/task/Client.java b/lang/java/reef-tests/src/main/java/org/apache/reef/tests/fail/task/Client.java index 839608a..829c54e 100644 --- a/lang/java/reef-tests/src/main/java/org/apache/reef/tests/fail/task/Client.java +++ b/lang/java/reef-tests/src/main/java/org/apache/reef/tests/fail/task/Client.java @@ -54,4 +54,10 @@ public final class Client { return TestDriverLauncher.getLauncher(runtimeConfig).run(cb.build(), timeOut); } + + /** + * Empty private constructor to prohibit instantiation of utility class. + */ + private Client() { + } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-tests/src/main/java/org/apache/reef/tests/library/tasks/NoopTask.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-tests/src/main/java/org/apache/reef/tests/library/tasks/NoopTask.java b/lang/java/reef-tests/src/main/java/org/apache/reef/tests/library/tasks/NoopTask.java index b86561c..9565a09 100644 --- a/lang/java/reef-tests/src/main/java/org/apache/reef/tests/library/tasks/NoopTask.java +++ b/lang/java/reef-tests/src/main/java/org/apache/reef/tests/library/tasks/NoopTask.java @@ -25,7 +25,7 @@ import javax.inject.Inject; /** * A Task that does nothing and returns null. */ -public class NoopTask implements Task { +public final class NoopTask implements Task { @Inject private NoopTask() { http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-tests/src/main/java/org/apache/reef/tests/yarn/failure/FailureREEF.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-tests/src/main/java/org/apache/reef/tests/yarn/failure/FailureREEF.java b/lang/java/reef-tests/src/main/java/org/apache/reef/tests/yarn/failure/FailureREEF.java index 25f3616..48c26d2 100644 --- a/lang/java/reef-tests/src/main/java/org/apache/reef/tests/yarn/failure/FailureREEF.java +++ b/lang/java/reef-tests/src/main/java/org/apache/reef/tests/yarn/failure/FailureREEF.java @@ -108,6 +108,12 @@ public final class FailureREEF { } /** + * Empty private constructor to prohibit instantiation of utility class. + */ + private FailureREEF() { + } + + /** * Command line parameter = true to run locally, or false to run on YARN. */ @NamedParameter(doc = "Whether or not to run on the local runtime", http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-utils-hadoop/src/main/java/org/apache/reef/util/HadoopEnvironment.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-utils-hadoop/src/main/java/org/apache/reef/util/HadoopEnvironment.java b/lang/java/reef-utils-hadoop/src/main/java/org/apache/reef/util/HadoopEnvironment.java index e4c3a55..ffca1e7 100644 --- a/lang/java/reef-utils-hadoop/src/main/java/org/apache/reef/util/HadoopEnvironment.java +++ b/lang/java/reef-utils-hadoop/src/main/java/org/apache/reef/util/HadoopEnvironment.java @@ -21,7 +21,7 @@ package org.apache.reef.util; /** * Constants for the various Hadoop environment variables. */ -public class HadoopEnvironment { +public final class HadoopEnvironment { public static final String HADOOP_CONF_DIR = "HADOOP_CONF_DIR"; public static final String HADOOP_HOME = "HADOOP_HOME"; http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/WakeParameters.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/WakeParameters.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/WakeParameters.java index 9599035..9390687 100644 --- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/WakeParameters.java +++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/WakeParameters.java @@ -43,4 +43,10 @@ public final class WakeParameters { @NamedParameter(doc = "Remote send timeout", default_value = "" + REMOTE_EXECUTOR_SHUTDOWN_TIMEOUT) public static final class RemoteSendTimeout implements Name<Integer> { } + + /** + * Empty private constructor to prohibit instantiation of utility class. + */ + private WakeParameters() { + } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/LoggingUtils.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/LoggingUtils.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/LoggingUtils.java index d001390..597861b 100644 --- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/LoggingUtils.java +++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/LoggingUtils.java @@ -26,7 +26,7 @@ import java.util.logging.Logger; /** * Utility for logging. */ -public class LoggingUtils { +public final class LoggingUtils { /** * Sets the logging level. @@ -49,4 +49,10 @@ public class LoggingUtils { ch.setLevel(level); Logger.getLogger("").setLevel(level); } + + /** + * Empty private constructor to prohibit instantiation of utility class. + */ + private LoggingUtils() { + } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/MergingEventHandler.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/MergingEventHandler.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/MergingEventHandler.java index 8b1e1de..19169bf 100644 --- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/MergingEventHandler.java +++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/MergingEventHandler.java @@ -60,7 +60,7 @@ public final class MergingEventHandler<L, R> { leftEvent = null; } - public static class Pair<S1, S2> { + public static final class Pair<S1, S2> { public final S1 first; public final S2 second; http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/MissingStartHandlerHandler.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/MissingStartHandlerHandler.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/MissingStartHandlerHandler.java index 922af9b..5b8cf3f 100644 --- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/MissingStartHandlerHandler.java +++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/MissingStartHandlerHandler.java @@ -28,7 +28,7 @@ import java.util.logging.Logger; /** * The EventHandler used as the default for the Clock.StartHandler event. */ -public class MissingStartHandlerHandler implements EventHandler<StartTime> { +public final class MissingStartHandlerHandler implements EventHandler<StartTime> { @Inject private MissingStartHandlerHandler() { http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/metrics/EWMAParameters.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/metrics/EWMAParameters.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/metrics/EWMAParameters.java index 9363103..2d7c5e6 100644 --- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/metrics/EWMAParameters.java +++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/metrics/EWMAParameters.java @@ -23,7 +23,7 @@ import static java.lang.Math.exp; /** * Default EWMA parameters. */ -public class EWMAParameters { +public final class EWMAParameters { public static final int INTERVAL = 5; public static final double SECONDS_PER_MINUTE = 60.0; public static final int ONE_MINUTE = 1; @@ -32,4 +32,10 @@ public class EWMAParameters { public static final double M5_ALPHA = 1 - exp(-INTERVAL / SECONDS_PER_MINUTE / FIVE_MINUTES); public static final int FIFTEEN_MINUTES = 15; public static final double M15_ALPHA = 1 - exp(-INTERVAL / SECONDS_PER_MINUTE / FIFTEEN_MINUTES); + + /** + * Empty private constructor to prohibit instantiation of utility class. + */ + private EWMAParameters() { + } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/NetUtils.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/NetUtils.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/NetUtils.java index a5cbc87..f1c5542 100644 --- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/NetUtils.java +++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/NetUtils.java @@ -35,4 +35,10 @@ public final class NetUtils { public static String getLocalAddress() { return localAddressProvider.getLocalAddress(); } + + /** + * Empty private constructor to prohibit instantiation of utility class. + */ + private NetUtils() { + } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/DefaultRemoteManagerFactory.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/DefaultRemoteManagerFactory.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/DefaultRemoteManagerFactory.java index eacc3f4..f083aa0 100644 --- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/DefaultRemoteManagerFactory.java +++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/DefaultRemoteManagerFactory.java @@ -33,7 +33,7 @@ import javax.inject.Inject; /** * Default implementation of RemoteManagerFactory. */ -public class DefaultRemoteManagerFactory implements RemoteManagerFactory { +public final class DefaultRemoteManagerFactory implements RemoteManagerFactory { private final Codec<?> codec; private final EventHandler<Throwable> errorHandler; http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/ports/parameters/TcpPortRangeBegin.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/ports/parameters/TcpPortRangeBegin.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/ports/parameters/TcpPortRangeBegin.java index 04e5672..d499604 100644 --- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/ports/parameters/TcpPortRangeBegin.java +++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/ports/parameters/TcpPortRangeBegin.java @@ -25,6 +25,12 @@ import org.apache.reef.tang.annotations.NamedParameter; * First tcp port number to try. */ @NamedParameter(doc = "First tcp port number to try", default_value = TcpPortRangeBegin.default_value) -public class TcpPortRangeBegin implements Name<Integer> { +public final class TcpPortRangeBegin implements Name<Integer> { public static final String default_value = "10000"; + + /** + * Empty private constructor to prohibit instantiation of utility class. + */ + private TcpPortRangeBegin() { + } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/ports/parameters/TcpPortRangeCount.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/ports/parameters/TcpPortRangeCount.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/ports/parameters/TcpPortRangeCount.java index ca8c1bd..4b4a3e5 100644 --- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/ports/parameters/TcpPortRangeCount.java +++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/ports/parameters/TcpPortRangeCount.java @@ -25,6 +25,12 @@ import org.apache.reef.tang.annotations.NamedParameter; * Number of tcp ports in the range. */ @NamedParameter(doc = "Number of tcp ports in the range", default_value = TcpPortRangeCount.default_value) -public class TcpPortRangeCount implements Name<Integer> { +public final class TcpPortRangeCount implements Name<Integer> { public static final String default_value = "10000"; + + /** + * Empty private constructor to prohibit instantiation of utility class. + */ + private TcpPortRangeCount() { + } } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/b459aafd/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/ports/parameters/TcpPortRangeTryCount.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/ports/parameters/TcpPortRangeTryCount.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/ports/parameters/TcpPortRangeTryCount.java index dbf9b0b..75687a9 100644 --- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/ports/parameters/TcpPortRangeTryCount.java +++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/ports/parameters/TcpPortRangeTryCount.java @@ -25,6 +25,12 @@ import org.apache.reef.tang.annotations.NamedParameter; * Max number tries for port numbers. */ @NamedParameter(doc = "Max number tries for port numbers", default_value = TcpPortRangeTryCount.default_value) -public class TcpPortRangeTryCount implements Name<Integer> { +public final class TcpPortRangeTryCount implements Name<Integer> { public static final String default_value = "1000"; + + /** + * Empty private constructor to prohibit instantiation of utility class. + */ + private TcpPortRangeTryCount() { + } }
