Repository: incubator-reef Updated Branches: refs/heads/master 68e19c818 -> 7dd36d702
[REEF-619] Remove unused bindings from the CLR Evaluator Configuration The two start/stop handler bindings will be remain for Java only. C# doesn't need it. This PR is to remove it from the ConfigurationModuleBuilder for Evaluator JIRA: [REEF-619](https://issues.apache.org/jira/browse/REEF-619) Pull Request: This closes #394 Project: http://git-wip-us.apache.org/repos/asf/incubator-reef/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-reef/commit/7dd36d70 Tree: http://git-wip-us.apache.org/repos/asf/incubator-reef/tree/7dd36d70 Diff: http://git-wip-us.apache.org/repos/asf/incubator-reef/diff/7dd36d70 Branch: refs/heads/master Commit: 7dd36d7028fceecd7bd57eefc957acd763be8e39 Parents: 68e19c8 Author: Julia Wang <[email protected]> Authored: Thu Aug 20 15:58:48 2015 -0700 Committer: Markus Weimer <[email protected]> Committed: Thu Aug 20 16:17:03 2015 -0700 ---------------------------------------------------------------------- .../reef/runtime/common/evaluator/EvaluatorConfiguration.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/7dd36d70/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/EvaluatorConfiguration.java ---------------------------------------------------------------------- diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/EvaluatorConfiguration.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/EvaluatorConfiguration.java index a786cd9..1df8ffa 100644 --- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/EvaluatorConfiguration.java +++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/EvaluatorConfiguration.java @@ -48,8 +48,6 @@ public final class EvaluatorConfiguration extends ConfigurationModuleBuilder { * The EVALUATOR_CONFIG_MODULE_BUILDER which contains bindings shared for all kinds of Evaluators. */ private static final ConfigurationModuleBuilder EVALUATOR_CONFIG_MODULE_BUILDER = new EvaluatorConfiguration() - .bindSetEntry(Clock.RuntimeStartHandler.class, EvaluatorRuntime.RuntimeStartHandler.class) - .bindSetEntry(Clock.RuntimeStopHandler.class, EvaluatorRuntime.RuntimeStopHandler.class) .bindNamedParameter(DriverRemoteIdentifier.class, DRIVER_REMOTE_IDENTIFIER) .bindNamedParameter(ErrorHandlerRID.class, DRIVER_REMOTE_IDENTIFIER) .bindNamedParameter(EvaluatorIdentifier.class, EVALUATOR_IDENTIFIER) @@ -69,6 +67,8 @@ public final class EvaluatorConfiguration extends ConfigurationModuleBuilder { * This is ConfigurationModule for Java Evaluator. */ public static final ConfigurationModule CONF = EVALUATOR_CONFIG_MODULE_BUILDER + .bindSetEntry(Clock.RuntimeStartHandler.class, EvaluatorRuntime.RuntimeStartHandler.class) + .bindSetEntry(Clock.RuntimeStopHandler.class, EvaluatorRuntime.RuntimeStopHandler.class) .bindConstructor(ExecutorService.class, ExecutorServiceConstructor.class) .build();
