Repository: incubator-reef Updated Branches: refs/heads/master 2d67da786 -> d3a02c464
[REEF-399] Add `params` to methods accepting arrays in ITang JIRA: [REEF-399](https://issues.apache.org/jira/browse/REEF-399) Pull Request: This closes #399 Project: http://git-wip-us.apache.org/repos/asf/incubator-reef/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-reef/commit/d3a02c46 Tree: http://git-wip-us.apache.org/repos/asf/incubator-reef/tree/d3a02c46 Diff: http://git-wip-us.apache.org/repos/asf/incubator-reef/diff/d3a02c46 Branch: refs/heads/master Commit: d3a02c464387e7930833f0086e3563b2bf7e75a3 Parents: 2d67da7 Author: Markus Weimer <[email protected]> Authored: Fri Aug 21 10:43:16 2015 -0700 Committer: Mariia Mykhailova <[email protected]> Committed: Fri Aug 21 12:27:25 2015 -0700 ---------------------------------------------------------------------- .../Org.Apache.REEF.Tang/Implementations/Tang/TangImpl.cs | 10 +++++----- lang/cs/Org.Apache.REEF.Tang/Interface/ITang.cs | 10 +++++----- 2 files changed, 10 insertions(+), 10 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d3a02c46/lang/cs/Org.Apache.REEF.Tang/Implementations/Tang/TangImpl.cs ---------------------------------------------------------------------- diff --git a/lang/cs/Org.Apache.REEF.Tang/Implementations/Tang/TangImpl.cs b/lang/cs/Org.Apache.REEF.Tang/Implementations/Tang/TangImpl.cs index c57db1d..2d0a282 100644 --- a/lang/cs/Org.Apache.REEF.Tang/Implementations/Tang/TangImpl.cs +++ b/lang/cs/Org.Apache.REEF.Tang/Implementations/Tang/TangImpl.cs @@ -98,7 +98,7 @@ namespace Org.Apache.REEF.Tang.Implementations.Tang return injector; } - public IInjector NewInjector(IConfiguration[] confs) + public IInjector NewInjector(params IConfiguration[] confs) { return new InjectorImpl(new CsConfigurationBuilderImpl(confs).Build()); } @@ -118,7 +118,7 @@ namespace Org.Apache.REEF.Tang.Implementations.Tang } } - public IClassHierarchy GetClassHierarchy(string[] assemblies) + public IClassHierarchy GetClassHierarchy(params string[] assemblies) { return GetDefaultClassHierarchy(assemblies, new Type[] { }); } @@ -157,7 +157,7 @@ namespace Org.Apache.REEF.Tang.Implementations.Tang } } - public ICsConfigurationBuilder NewConfigurationBuilder(string[] assemblies) + public ICsConfigurationBuilder NewConfigurationBuilder(params string[] assemblies) { try { @@ -182,7 +182,7 @@ namespace Org.Apache.REEF.Tang.Implementations.Tang return new CsConfigurationBuilderImpl(classHierarchy); } - public ICsConfigurationBuilder NewConfigurationBuilder(IConfiguration[] confs) + public ICsConfigurationBuilder NewConfigurationBuilder(params IConfiguration[] confs) { return NewConfigurationBuilder(new string[0], confs, new Type[0]); } @@ -192,7 +192,7 @@ namespace Org.Apache.REEF.Tang.Implementations.Tang return new CsConfigurationBuilderImpl(assemblies, confs, parameterParsers); } - public ICsConfigurationBuilder NewConfigurationBuilder(Type[] parameterParsers) + public ICsConfigurationBuilder NewConfigurationBuilder(params Type[] parameterParsers) { return NewConfigurationBuilder(new string[0], new IConfiguration[0], parameterParsers); } http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d3a02c46/lang/cs/Org.Apache.REEF.Tang/Interface/ITang.cs ---------------------------------------------------------------------- diff --git a/lang/cs/Org.Apache.REEF.Tang/Interface/ITang.cs b/lang/cs/Org.Apache.REEF.Tang/Interface/ITang.cs index b9d8902..a81f1ae 100644 --- a/lang/cs/Org.Apache.REEF.Tang/Interface/ITang.cs +++ b/lang/cs/Org.Apache.REEF.Tang/Interface/ITang.cs @@ -25,23 +25,23 @@ namespace Org.Apache.REEF.Tang.Interface public interface ITang { IInjector NewInjector(); - IInjector NewInjector(IConfiguration[] confs); + IInjector NewInjector(params IConfiguration[] confs); IInjector NewInjector(IConfiguration confs); IInjector NewInjector(string[] assemblies, string configurationFileName); IInjector NewInjector(string[] assemblies, IDictionary<string, string> configurations); IInjector NewInjector(string[] assemblies, IList<KeyValuePair<string, string>> configurations); - IClassHierarchy GetClassHierarchy(string[] assemblies); + IClassHierarchy GetClassHierarchy(params string[] assemblies); ICsClassHierarchy GetDefaultClassHierarchy(); ICsClassHierarchy GetDefaultClassHierarchy(string[] assemblies, Type[] parameterParsers); ICsConfigurationBuilder NewConfigurationBuilder(); - ICsConfigurationBuilder NewConfigurationBuilder(string[] assemblies); - ICsConfigurationBuilder NewConfigurationBuilder(IConfiguration[] confs); + ICsConfigurationBuilder NewConfigurationBuilder(params string[] assemblies); + ICsConfigurationBuilder NewConfigurationBuilder(params IConfiguration[] confs); ICsConfigurationBuilder NewConfigurationBuilder(IConfiguration conf); ICsConfigurationBuilder NewConfigurationBuilder(string[] assemblies, IConfiguration[] confs, Type[] parameterParsers); IConfigurationBuilder NewConfigurationBuilder(IClassHierarchy classHierarchy); ICsConfigurationBuilder NewConfigurationBuilder(ICsClassHierarchy classHierarchy); - ICsConfigurationBuilder NewConfigurationBuilder(Type[] parameterParsers); + ICsConfigurationBuilder NewConfigurationBuilder(params Type[] parameterParsers); } }
