Repository: incubator-reef Updated Branches: refs/heads/master 1ba890433 -> db4c1b55b
[REEF-737] Sign strong name for Debug version of REEF.Net JIRA: [REEF-737](https://issues.apache.org/jira/browse/REEF-737) Pull Request: This closes #483 Project: http://git-wip-us.apache.org/repos/asf/incubator-reef/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-reef/commit/db4c1b55 Tree: http://git-wip-us.apache.org/repos/asf/incubator-reef/tree/db4c1b55 Diff: http://git-wip-us.apache.org/repos/asf/incubator-reef/diff/db4c1b55 Branch: refs/heads/master Commit: db4c1b55b8bb706f64a6977bb1044468e9f321c9 Parents: 1ba8904 Author: Julia Wang <[email protected]> Authored: Thu Sep 10 17:42:12 2015 -0700 Committer: Markus Weimer <[email protected]> Committed: Fri Sep 11 14:06:57 2015 -0700 ---------------------------------------------------------------------- lang/cs/Org.Apache.REEF.Common/Properties/AssemblyInfo.cs | 7 +------ lang/cs/Org.Apache.REEF.Driver/Properties/AssemblyInfo.cs | 6 +----- lang/cs/Org.Apache.REEF.Evaluator/Properties/AssemblyInfo.cs | 6 +----- lang/cs/Org.Apache.REEF.IMRU/Properties/AssemblyInfo.cs | 4 ---- lang/cs/Org.Apache.REEF.IO/Properties/AssemblyInfo.cs | 4 ---- lang/cs/Org.Apache.REEF.Network/Properties/AssemblyInfo.cs | 4 ---- lang/cs/Org.Apache.REEF.Tang/Properties/AssemblyInfo.cs | 4 ---- lang/cs/Org.Apache.REEF.Wake/Properties/AssemblyInfo.cs | 4 ---- lang/cs/build.props | 4 ++-- 9 files changed, 5 insertions(+), 38 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/db4c1b55/lang/cs/Org.Apache.REEF.Common/Properties/AssemblyInfo.cs ---------------------------------------------------------------------- diff --git a/lang/cs/Org.Apache.REEF.Common/Properties/AssemblyInfo.cs b/lang/cs/Org.Apache.REEF.Common/Properties/AssemblyInfo.cs index d232852..efe1c32 100644 --- a/lang/cs/Org.Apache.REEF.Common/Properties/AssemblyInfo.cs +++ b/lang/cs/Org.Apache.REEF.Common/Properties/AssemblyInfo.cs @@ -55,13 +55,8 @@ using System.Runtime.InteropServices; [assembly: AssemblyFileVersion("0.13.0.0")] // Allow the tests access to `internal` APIs - -#if DEBUG -[assembly: InternalsVisibleTo("Org.Apache.REEF.Common.Tests")] -#else [assembly: InternalsVisibleTo("Org.Apache.REEF.Common.Tests, publickey=" + "00240000048000009400000006020000002400005253413100040000010001005df3e621d886a9" + "9c03469d0f93a9f5d45aa2c883f50cd158759e93673f759ec4657fd84cc79d2db38ef1a2d914cc" + "b7c717846a897e11dd22eb260a7ce2da2dccf0263ea63e2b3f7dac24f28882aa568ef544341d17" + - "618392a1095f4049ad079d4f4f0b429bb535699155fd6a7652ec7d6c1f1ba2b560f11ef3a86b5945d288cf")] -#endif \ No newline at end of file + "618392a1095f4049ad079d4f4f0b429bb535699155fd6a7652ec7d6c1f1ba2b560f11ef3a86b5945d288cf")] \ No newline at end of file http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/db4c1b55/lang/cs/Org.Apache.REEF.Driver/Properties/AssemblyInfo.cs ---------------------------------------------------------------------- diff --git a/lang/cs/Org.Apache.REEF.Driver/Properties/AssemblyInfo.cs b/lang/cs/Org.Apache.REEF.Driver/Properties/AssemblyInfo.cs index ae8b2f4..8e71063 100644 --- a/lang/cs/Org.Apache.REEF.Driver/Properties/AssemblyInfo.cs +++ b/lang/cs/Org.Apache.REEF.Driver/Properties/AssemblyInfo.cs @@ -55,12 +55,8 @@ using System.Runtime.InteropServices; [assembly: AssemblyFileVersion("0.13.0.0")] // Allow the bridge access to `internal` APIs -#if DEBUG -[assembly: InternalsVisibleTo("Org.Apache.REEF.Bridge")] -#else [assembly: InternalsVisibleTo("Org.Apache.REEF.Bridge, publickey=" + "00240000048000009400000006020000002400005253413100040000010001005df3e621d886a9" + "9c03469d0f93a9f5d45aa2c883f50cd158759e93673f759ec4657fd84cc79d2db38ef1a2d914cc" + "b7c717846a897e11dd22eb260a7ce2da2dccf0263ea63e2b3f7dac24f28882aa568ef544341d17" + - "618392a1095f4049ad079d4f4f0b429bb535699155fd6a7652ec7d6c1f1ba2b560f11ef3a86b5945d288cf")] -#endif \ No newline at end of file + "618392a1095f4049ad079d4f4f0b429bb535699155fd6a7652ec7d6c1f1ba2b560f11ef3a86b5945d288cf")] \ No newline at end of file http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/db4c1b55/lang/cs/Org.Apache.REEF.Evaluator/Properties/AssemblyInfo.cs ---------------------------------------------------------------------- diff --git a/lang/cs/Org.Apache.REEF.Evaluator/Properties/AssemblyInfo.cs b/lang/cs/Org.Apache.REEF.Evaluator/Properties/AssemblyInfo.cs index b672ea9..17cf599 100644 --- a/lang/cs/Org.Apache.REEF.Evaluator/Properties/AssemblyInfo.cs +++ b/lang/cs/Org.Apache.REEF.Evaluator/Properties/AssemblyInfo.cs @@ -55,12 +55,8 @@ using System.Runtime.InteropServices; [assembly: AssemblyFileVersion("0.13.0.0")] // Allow the tests access to `internal` APIs -#if DEBUG -[assembly: InternalsVisibleTo("Org.Apache.REEF.Evaluator.Tests")] -#else [assembly: InternalsVisibleTo("Org.Apache.REEF.Tang.Tests, publickey=" + "00240000048000009400000006020000002400005253413100040000010001005df3e621d886a9" + "9c03469d0f93a9f5d45aa2c883f50cd158759e93673f759ec4657fd84cc79d2db38ef1a2d914cc" + "b7c717846a897e11dd22eb260a7ce2da2dccf0263ea63e2b3f7dac24f28882aa568ef544341d17" + - "618392a1095f4049ad079d4f4f0b429bb535699155fd6a7652ec7d6c1f1ba2b560f11ef3a86b5945d288cf")] -#endif \ No newline at end of file + "618392a1095f4049ad079d4f4f0b429bb535699155fd6a7652ec7d6c1f1ba2b560f11ef3a86b5945d288cf")] \ No newline at end of file http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/db4c1b55/lang/cs/Org.Apache.REEF.IMRU/Properties/AssemblyInfo.cs ---------------------------------------------------------------------- diff --git a/lang/cs/Org.Apache.REEF.IMRU/Properties/AssemblyInfo.cs b/lang/cs/Org.Apache.REEF.IMRU/Properties/AssemblyInfo.cs index ab5fd22..e6df092 100644 --- a/lang/cs/Org.Apache.REEF.IMRU/Properties/AssemblyInfo.cs +++ b/lang/cs/Org.Apache.REEF.IMRU/Properties/AssemblyInfo.cs @@ -33,12 +33,8 @@ using System.Runtime.InteropServices; [assembly: AssemblyVersion("0.13.0.0")] [assembly: AssemblyFileVersion("0.13.0.0")] // Allow the tests project access to `internal` APIs -#if DEBUG -[assembly: InternalsVisibleTo("Org.Apache.REEF.IMRU.Tests")] -#else [assembly: InternalsVisibleTo("Org.Apache.REEF.IMRU.Tests, publickey=" + "00240000048000009400000006020000002400005253413100040000010001005df3e621d886a9" + "9c03469d0f93a9f5d45aa2c883f50cd158759e93673f759ec4657fd84cc79d2db38ef1a2d914cc" + "b7c717846a897e11dd22eb260a7ce2da2dccf0263ea63e2b3f7dac24f28882aa568ef544341d17" + "618392a1095f4049ad079d4f4f0b429bb535699155fd6a7652ec7d6c1f1ba2b560f11ef3a86b5945d288cf")] -#endif \ No newline at end of file http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/db4c1b55/lang/cs/Org.Apache.REEF.IO/Properties/AssemblyInfo.cs ---------------------------------------------------------------------- diff --git a/lang/cs/Org.Apache.REEF.IO/Properties/AssemblyInfo.cs b/lang/cs/Org.Apache.REEF.IO/Properties/AssemblyInfo.cs index e0a0f47..156f05d 100644 --- a/lang/cs/Org.Apache.REEF.IO/Properties/AssemblyInfo.cs +++ b/lang/cs/Org.Apache.REEF.IO/Properties/AssemblyInfo.cs @@ -34,12 +34,8 @@ using System.Runtime.InteropServices; [assembly: AssemblyVersion("0.13.0.0")] [assembly: AssemblyFileVersion("0.13.0.0")] // Allow the tests project access to `internal` APIs -#if DEBUG - [assembly: InternalsVisibleTo("Org.Apache.REEF.IO.Tests")] -#else [assembly: InternalsVisibleTo("Org.Apache.REEF.IO.Tests, publickey=" + "00240000048000009400000006020000002400005253413100040000010001005df3e621d886a9" + "9c03469d0f93a9f5d45aa2c883f50cd158759e93673f759ec4657fd84cc79d2db38ef1a2d914cc" + "b7c717846a897e11dd22eb260a7ce2da2dccf0263ea63e2b3f7dac24f28882aa568ef544341d17" + "618392a1095f4049ad079d4f4f0b429bb535699155fd6a7652ec7d6c1f1ba2b560f11ef3a86b5945d288cf")] -#endif \ No newline at end of file http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/db4c1b55/lang/cs/Org.Apache.REEF.Network/Properties/AssemblyInfo.cs ---------------------------------------------------------------------- diff --git a/lang/cs/Org.Apache.REEF.Network/Properties/AssemblyInfo.cs b/lang/cs/Org.Apache.REEF.Network/Properties/AssemblyInfo.cs index 20cfc8a..ae72d34 100644 --- a/lang/cs/Org.Apache.REEF.Network/Properties/AssemblyInfo.cs +++ b/lang/cs/Org.Apache.REEF.Network/Properties/AssemblyInfo.cs @@ -55,12 +55,8 @@ using System.Runtime.InteropServices; [assembly: AssemblyFileVersion("0.13.0.0")] // Allow the tests access to `internal` APIs -#if DEBUG -[assembly: InternalsVisibleTo("Org.Apache.REEF.Network.Tests")] -#else [assembly: InternalsVisibleTo("Org.Apache.REEF.Network.Tests, publickey=" + "00240000048000009400000006020000002400005253413100040000010001005df3e621d886a9" + "9c03469d0f93a9f5d45aa2c883f50cd158759e93673f759ec4657fd84cc79d2db38ef1a2d914cc" + "b7c717846a897e11dd22eb260a7ce2da2dccf0263ea63e2b3f7dac24f28882aa568ef544341d17" + "618392a1095f4049ad079d4f4f0b429bb535699155fd6a7652ec7d6c1f1ba2b560f11ef3a86b5945d288cf")] -#endif \ No newline at end of file http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/db4c1b55/lang/cs/Org.Apache.REEF.Tang/Properties/AssemblyInfo.cs ---------------------------------------------------------------------- diff --git a/lang/cs/Org.Apache.REEF.Tang/Properties/AssemblyInfo.cs b/lang/cs/Org.Apache.REEF.Tang/Properties/AssemblyInfo.cs index c31b33d..4538970 100644 --- a/lang/cs/Org.Apache.REEF.Tang/Properties/AssemblyInfo.cs +++ b/lang/cs/Org.Apache.REEF.Tang/Properties/AssemblyInfo.cs @@ -55,12 +55,8 @@ using System.Runtime.InteropServices; [assembly: AssemblyFileVersion("0.13.0.0")] // Allow the tests access to `internal` APIs -#if DEBUG -[assembly: InternalsVisibleTo("Org.Apache.REEF.Tang.Tests")] -#else [assembly: InternalsVisibleTo("Org.Apache.REEF.Tang.Tests, publickey=" + "00240000048000009400000006020000002400005253413100040000010001005df3e621d886a9" + "9c03469d0f93a9f5d45aa2c883f50cd158759e93673f759ec4657fd84cc79d2db38ef1a2d914cc" + "b7c717846a897e11dd22eb260a7ce2da2dccf0263ea63e2b3f7dac24f28882aa568ef544341d17" + "618392a1095f4049ad079d4f4f0b429bb535699155fd6a7652ec7d6c1f1ba2b560f11ef3a86b5945d288cf")] -#endif \ No newline at end of file http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/db4c1b55/lang/cs/Org.Apache.REEF.Wake/Properties/AssemblyInfo.cs ---------------------------------------------------------------------- diff --git a/lang/cs/Org.Apache.REEF.Wake/Properties/AssemblyInfo.cs b/lang/cs/Org.Apache.REEF.Wake/Properties/AssemblyInfo.cs index e15e280..4b9d083 100644 --- a/lang/cs/Org.Apache.REEF.Wake/Properties/AssemblyInfo.cs +++ b/lang/cs/Org.Apache.REEF.Wake/Properties/AssemblyInfo.cs @@ -55,12 +55,8 @@ using System.Runtime.InteropServices; [assembly: AssemblyFileVersion("0.13.0.0")] // Allow the tests access to `internal` APIs -#if DEBUG -[assembly: InternalsVisibleTo("Org.Apache.REEF.Wake.Tests")] -#else [assembly: InternalsVisibleTo("Org.Apache.REEF.Wake.Tests, publickey=" + "00240000048000009400000006020000002400005253413100040000010001005df3e621d886a9" + "9c03469d0f93a9f5d45aa2c883f50cd158759e93673f759ec4657fd84cc79d2db38ef1a2d914cc" + "b7c717846a897e11dd22eb260a7ce2da2dccf0263ea63e2b3f7dac24f28882aa568ef544341d17" + "618392a1095f4049ad079d4f4f0b429bb535699155fd6a7652ec7d6c1f1ba2b560f11ef3a86b5945d288cf")] -#endif \ No newline at end of file http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/db4c1b55/lang/cs/build.props ---------------------------------------------------------------------- diff --git a/lang/cs/build.props b/lang/cs/build.props index abe9298..0edcdc1 100644 --- a/lang/cs/build.props +++ b/lang/cs/build.props @@ -26,6 +26,8 @@ under the License. <OutputPath>$(BinDir)\$(Platform)\$(Configuration)\$(RootNamespace)</OutputPath> <BaseIntermediateOutputPath>$(BinDir)\Temp\$(RootNamespace)\$(Platform)\</BaseIntermediateOutputPath> <IntermediateOutputPath>$(BaseIntermediateOutputPath)$(Configuration)\</IntermediateOutputPath> + <SignAssembly>true</SignAssembly> + <AssemblyOriginatorKeyFile>$(SolutionDir)\keyfile.snk</AssemblyOriginatorKeyFile> </PropertyGroup> <!-- Common build configurations --> @@ -42,8 +44,6 @@ under the License. </PropertyGroup> <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|x64' "> <BuildPackage>true</BuildPackage> - <SignAssembly>true</SignAssembly> - <AssemblyOriginatorKeyFile>$(SolutionDir)\keyfile.snk</AssemblyOriginatorKeyFile> <PlatformTarget>x64</PlatformTarget> <DebugType>pdbonly</DebugType> <Optimize>true</Optimize>
