cjcchen commented on code in PR #224:
URL:
https://github.com/apache/incubator-resilientdb/pull/224#discussion_r2908475975
##########
chain/storage/duckdb.cpp:
##########
@@ -0,0 +1,99 @@
+#include "chain/storage/duckdb.h"
+
+#include <glog/logging.h>
+
+#include <exception>
+#include <memory>
+#include <string>
+
+#include "duckdb.hpp"
+
+namespace resdb {
+namespace storage {
+
+std::unique_ptr<Storage> NewResQL(const std::string& path,
+ const DuckDBInfo& config) {
+ DuckDBInfo cfg = config;
+ cfg.set_path(path);
+
+ return std::make_unique<ResQL>(cfg);
+}
+
+ResQL::ResQL(const DuckDBInfo& config) : config_(config) {
Review Comment:
The filename is dockdb. Why is this called ResQL?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
