This is an automated email from the ASF dual-hosted git repository.

lizhanhui pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/rocketmq-clients.git


The following commit(s) were added to refs/heads/master by this push:
     new 3cb7fbe  Add new label(consumerGroup) for the metrics of consumer (#63)
3cb7fbe is described below

commit 3cb7fbea87b367007227e663b6deb2ea632c1bd5
Author: Aaron Ai <yangkun....@gmail.com>
AuthorDate: Wed Jul 20 11:51:56 2022 +0800

    Add new label(consumerGroup) for the metrics of consumer (#63)
---
 cpp/source/rocketmq/ConsumeTask.cpp | 8 +++++---
 cpp/source/rocketmq/SendContext.cpp | 4 ++--
 cpp/source/stats/Tag.cpp            | 7 ++++++-
 cpp/source/stats/include/Tag.h      | 4 +++-
 4 files changed, 16 insertions(+), 7 deletions(-)

diff --git a/cpp/source/rocketmq/ConsumeTask.cpp 
b/cpp/source/rocketmq/ConsumeTask.cpp
index 7af1b28..0c9802d 100644
--- a/cpp/source/rocketmq/ConsumeTask.cpp
+++ b/cpp/source/rocketmq/ConsumeTask.cpp
@@ -134,7 +134,7 @@ void ConsumeTask::process() {
       auto await_time = std::chrono::system_clock::now() - 
(*it)->extension().decode_time;
       opencensus::stats::Record(
           {{consumer->stats().awaitTime(), 
MixAll::millisecondsOf(await_time)}},
-          {{Tag::topicTag(), (*it)->topic()}, {Tag::clientIdTag(), 
consumer->config().client_id}});
+          {{Tag::topicTag(), (*it)->topic()}, {Tag::clientIdTag(), 
consumer->config().client_id}, {Tag::consumerGroupTag(), 
consumer->groupName()}});
 
       std::chrono::steady_clock::time_point start = 
std::chrono::steady_clock::now();
 
@@ -149,7 +149,8 @@ void ConsumeTask::process() {
                                     {
                                         {Tag::topicTag(), (*it)->topic()},
                                         {Tag::clientIdTag(), 
consumer->config().client_id},
-                                        {Tag::invocationStatus(), "success"},
+                                        {Tag::invocationStatusTag(), 
"success"},
+                                        {Tag::consumerGroupTag(), 
consumer->groupName()}
                                     });
           break;
         }
@@ -158,7 +159,8 @@ void ConsumeTask::process() {
                                     {
                                         {Tag::topicTag(), (*it)->topic()},
                                         {Tag::clientIdTag(), 
consumer->config().client_id},
-                                        {Tag::invocationStatus(), "failure"},
+                                        {Tag::invocationStatusTag(), 
"failure"},
+                                        {Tag::consumerGroupTag(), 
consumer->groupName()}
                                     });
           break;
         }
diff --git a/cpp/source/rocketmq/SendContext.cpp 
b/cpp/source/rocketmq/SendContext.cpp
index f73a30d..4d75a2a 100644
--- a/cpp/source/rocketmq/SendContext.cpp
+++ b/cpp/source/rocketmq/SendContext.cpp
@@ -49,7 +49,7 @@ void SendContext::onSuccess(const SendReceipt& send_receipt) 
noexcept {
                               {
                                   {Tag::topicTag(), message_->topic()},
                                   {Tag::clientIdTag(), 
publisher->config().client_id},
-                                  {Tag::invocationStatus(), "success"},
+                                  {Tag::invocationStatusTag(), "success"},
                               });
   }
 
@@ -77,7 +77,7 @@ void SendContext::onFailure(const std::error_code& ec) 
noexcept {
                               {
                                   {Tag::topicTag(), message_->topic()},
                                   {Tag::clientIdTag(), 
publisher->config().client_id},
-                                  {Tag::invocationStatus(), "failure"},
+                                  {Tag::invocationStatusTag(), "failure"},
                               });
   }
 
diff --git a/cpp/source/stats/Tag.cpp b/cpp/source/stats/Tag.cpp
index 62f2076..4ca166c 100644
--- a/cpp/source/stats/Tag.cpp
+++ b/cpp/source/stats/Tag.cpp
@@ -28,9 +28,14 @@ opencensus::tags::TagKey& Tag::clientIdTag() {
   return client_id_tag;
 }
 
-opencensus::tags::TagKey& Tag::invocationStatus() {
+opencensus::tags::TagKey& Tag::invocationStatusTag() {
   static opencensus::tags::TagKey invocation_status = 
opencensus::tags::TagKey::Register("invocation_status");
   return invocation_status;
 }
 
+opencensus::tags::TagKey& Tag::consumerGroupTag() {
+  static opencensus::tags::TagKey consumer_group_tag = 
opencensus::tags::TagKey::Register("consumer_group");
+  return consumer_group_tag;
+}
+
 ROCKETMQ_NAMESPACE_END
diff --git a/cpp/source/stats/include/Tag.h b/cpp/source/stats/include/Tag.h
index df78650..4281afd 100644
--- a/cpp/source/stats/include/Tag.h
+++ b/cpp/source/stats/include/Tag.h
@@ -27,7 +27,9 @@ public:
 
   static opencensus::tags::TagKey& clientIdTag();
 
-  static opencensus::tags::TagKey& invocationStatus();
+  static opencensus::tags::TagKey& invocationStatusTag();
+
+  static opencensus::tags::TagKey& consumerGroupTag();
 };
 
 ROCKETMQ_NAMESPACE_END
\ No newline at end of file

Reply via email to