NUAAwqy commented on PR #7124: URL: https://github.com/apache/rocketmq-dashboard/pull/7124#issuecomment-6432400613
Closing this PR: the same behavior is now covered upstream on the `rocketmq-studio` branch. `MetricsService` now ships an equivalent `NUMBER_PATTERN` (same grammar: sign, decimal point on either side of the digits, and an exponent) together with the corresponding tests (`queryShouldAcceptPrometheusDecimalAndExponentStepFormsTest`, `queryShouldStillRejectSubBudgetStepsInExponentNotationTest`), which also conflicts with this branch. The upstream implementation is a superset of what this PR proposed, so there is nothing left to merge. Thanks for reviewing! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
