lizhimins commented on issue #6986: URL: https://github.com/apache/rocketmq-dashboard/issues/6986#issuecomment-6433528505
Closing as not planned: the only production caller passes `builder.environment()`, which is already case-insensitive on Windows, so `Path` / `SystemRoot` are retained regardless of how the parent environment spells them. The proposed change is therefore behaviour-neutral on the production path, and the added tests pass with and without it. See #6987 for the review. Happy to reopen if you have a Windows reproduction where a variable really is dropped. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
